BaseManager - Code Metrics - Inspection of "Add support for complex FM variables to compiler" - stakx-io/stakx - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a41cf5...7efa4f )

by Vladimir

created 2018-02-18 08:48 UTC

BaseManager A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

81.82%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
lcom	0
cbo	1
dl	0
loc	43
ccs	9
cts	11
cp	0.8182
rs	10
c	1
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	setLogger()	4	1
A	compileManager()	4	1
A	setContainer()	4	1

<?php

/**
 * @copyright 2017 Vladimir Jimenez
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx\Manager;

use allejo\stakx\System\Filesystem;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

abstract class BaseManager implements LoggerAwareInterface, ContainerAwareInterface
{
    protected static $documentIgnoreList = array('/\.example$/');

    /** @var Container */
    protected $container;
    /** @var LoggerInterface */
    protected $output;

    /**
     * @var Filesystem
     */
    protected $fs;


    public function __construct()
    {
        $this->fs = new Filesystem();
    }

    /**
     * {@inheritdoc}
     */
    public function setLogger(LoggerInterface $logger)
    {
        $this->output = $logger;
    }

    /**
     * {@inheritdoc}
     */
    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Build the manager's internals after it's been configured.
     */
    public function compileManager()
    {

    }
}


1		<?php
2
3		/**
4		* @copyright 2017 Vladimir Jimenez
5		* @license https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
6		*/
7
8		namespace allejo\stakx\Manager;
9
10		use allejo\stakx\System\Filesystem;
11		use Psr\Log\LoggerAwareInterface;
12		use Psr\Log\LoggerInterface;
13		use Symfony\Component\DependencyInjection\Container;
14		use Symfony\Component\DependencyInjection\ContainerAwareInterface;
15		use Symfony\Component\DependencyInjection\ContainerInterface;
16
17		abstract class BaseManager implements LoggerAwareInterface, ContainerAwareInterface
18		{
19		protected static $documentIgnoreList = array('/\.example$/');
20
21		/** @var Container */
22		protected $container;
23		/** @var LoggerInterface */
24		protected $output;
25
26		/**
27		* @var Filesystem
28		*/
29		protected $fs;
		0 ignored issues – show Comprehensibility introduced 2017-03-25 02:33 UTC by Report Bug Copy Issue Report Avoid variables with short names like $fs. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
30
31	62	public function __construct()
32		{
33	62	$this->fs = new Filesystem();
34	62	}
35
36		/**
37		* {@inheritdoc}
38		*/
39	58	public function setLogger(LoggerInterface $logger)
40		{
41	58	$this->output = $logger;
42	58	}
43
44		/**
45		* {@inheritdoc}
46		*/
47	14	public function setContainer(ContainerInterface $container = null)
48		{
49	14	$this->container = $container;
		0 ignored issues – show Documentation Bug introduced 2017-11-02 23:08 UTC by Report Bug Copy Issue Report It seems like `$container` can also be of type `object<Symfony\Component...ion\ContainerInterface>`. However, the property `$container` is declared as type `object<Symfony\Component...ncyInjection\Container>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
50	14	}
51
52		/**
53		* Build the manager's internals after it's been configured.
54		*/
55		public function compileManager()
56		{
57
58		}
59		}
60

stakx-io / stakx

Push — master ( a41cf5...7efa4f )

BaseManager A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like