allejo\stakx\Utilities\HtmlUtils::htmlXPath()

Complexity

Conditions	3
Paths	3

Size

Total Lines

32

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	3.0017

Importance

Changes

0

<?php
    public static function htmlXPath(\DOMDocument &$DOMDocument, $html, $xpathQuery)
    {
        $html = self::normalizeHTML($html);

Consider using a different name than the parameter $html. This often makes code more readable.

        libxml_use_internal_errors(true);

        $DOMDocument->loadHTML(
            mb_convert_encoding($html, 'HTML-ENTITIES', 'UTF-8'),
            LIBXML_HTML_NOIMPLIED | LIBXML_HTML_NODEFDTD
        );

        $xmlErrors = libxml_get_errors();

        /** @var \LibXMLError $error */
        foreach ($xmlErrors as $error)
        {
            // Ignore errors about invalid tags
            //   http://www.xmlsoft.org/html/libxml-xmlerror.html#xmlParserErrors
            if ($error->code === 801)
            {
                continue;
            }

            @trigger_error($error->message, E_USER_WARNING);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        libxml_clear_errors();

        $xpath = new \DOMXPath($DOMDocument);

        return $xpath->query($xpathQuery);
    }