MarkdownEngine - Code Metrics - Inspection of "Support dot notation in Twig filters" - stakx-io/stakx - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#66)

by Vladimir

created 2018-05-23 04:24 UTC

MarkdownEngine A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

97.87%

Importance

Changes

Metric	Value
wmc	13
lcom	1
cbo	3
dl	0
loc	100
ccs	46
cts	47
cp	0.9787
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	slugifyHeader()	8	1
A	getTemplateTag()	4	1
A	blockHeader()	11	2
A	blockSetextHeader()	16	3
B	blockFencedCodeComplete()	26	4
A	getExtensions()	8	1

<?php

/**
 * @copyright 2018 Vladimir Jimenez
 * @license   https://github.com/stakx-io/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx\MarkupEngine;

use allejo\stakx\Configuration;
use allejo\stakx\Service;
use Highlight\Highlighter;

class MarkdownEngine extends \ParsedownExtra implements MarkupEngine
{
    protected $highlighter;

    public function __construct()
    {
        parent::__construct();

        $this->highlighter = new Highlighter();
    }

    protected function blockHeader($Line)

    {
        $Block = parent::blockHeader($Line);

        if (isset($Block['element']['text']))
        {
            $Block['element']['attributes']['id'] = $this->slugifyHeader($Block);
        }

        return $Block;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    protected function blockSetextHeader($Line, array $Block = null)

    {
        $Block = parent::blockSetextHeader($Line, $Block);


        if (isset($Block['element']['name']))
        {
            $element = $Block['element']['name'];

            if (in_array($element, ['h1', 'h2', 'h3', 'h4', 'h5', 'h6']))
            {
                $Block['element']['attributes']['id'] = $this->slugifyHeader($Block);
            }
        }

        return $Block;
    }

    private function slugifyHeader($Block)

    {
        $id = strtolower($Block['element']['text']);
        $id = str_replace(' ', '-', $id);
        $id = preg_replace('/[^0-9a-zA-Z-_]/', '', $id);

        return preg_replace('/-+/', '-', $id);
    }

    protected function blockFencedCodeComplete($block)

    {
        // The class has a `language-` prefix, remove this to get the language
        if (isset($block['element']['text']['attributes']) && Service::getParameter(Configuration::HIGHLIGHTER_ENABLED))
        {
            $cssClass = &$block['element']['text']['attributes']['class'];
            $language = substr($cssClass, 9);
            $cssClass = 'hljs ' . $cssClass;

            try
            {
                $highlighted = $this->highlighter->highlight($language, $block['element']['text']['text']);
                $block['element']['text']['text'] = $highlighted->value;

                // Only return the block if Highlighter knew the language and how to handle it.
                return $block;
            }
            // Exception thrown when language not supported
            catch (\DomainException $exception)
            {
                trigger_error("An unsupported language ($language) was detected in a code block", E_USER_WARNING);
            }
        }

        return parent::blockFencedCodeComplete($block);
    }

    ///
    // MarkupEngine Implementation
    ///

    /**
     * {@inheritdoc}
     */
    public function getTemplateTag()
    {
        return 'markdown';
    }

    /**
     * {@inheritdoc}
     */
    public function getExtensions()
    {
        return [
            'md',
            'mdown',
            'markdown',
        ];
    }
}


1		<?php
2
3		/**
4		* @copyright 2018 Vladimir Jimenez
5		* @license https://github.com/stakx-io/stakx/blob/master/LICENSE.md MIT
6		*/
7
8		namespace allejo\stakx\MarkupEngine;
9
10		use allejo\stakx\Configuration;
11		use allejo\stakx\Service;
12		use Highlight\Highlighter;
13
14		class MarkdownEngine extends \ParsedownExtra implements MarkupEngine
15		{
16		protected $highlighter;
17
18	87	public function __construct()
19		{
20	87	parent::__construct();
21
22	87	$this->highlighter = new Highlighter();
23	87	}
24
25	11	protected function blockHeader($Line)
		0 ignored issues – show Coding Style Naming introduced 2017-10-01 22:57 UTC by Report Bug Copy Issue Report The parameter $Line is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
26		{
27	11	$Block = parent::blockHeader($Line);
28
29	11	if (isset($Block['element']['text']))
30	11	{
31	11	$Block['element']['attributes']['id'] = $this->slugifyHeader($Block);
32	11	}
33
34	11	return $Block;
		0 ignored issues – show Bug Best Practice introduced 2017-06-26 02:02 UTC by Report Bug Copy Issue Report The return type of `return $Block;` (`array<string,array<string,string\|null>>`) is incompatible with the return type of the parent method `ParsedownExtra::blockHeader` of type `array<string,array<string,string>>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
35		}
36
37	3	protected function blockSetextHeader($Line, array $Block = null)
		0 ignored issues – show Coding Style Naming introduced 2017-10-01 22:57 UTC by Report Bug Copy Issue Report The parameter $Line is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history... Coding Style Naming introduced 2017-10-01 22:57 UTC by Report Bug Copy Issue Report The parameter $Block is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
38		{
39	3	$Block = parent::blockSetextHeader($Line, $Block);
		0 ignored issues – show Coding Style introduced 2017-06-26 02:02 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$Block`. This often makes code more readable. Loading history...
40
41	3	if (isset($Block['element']['name']))
42	3	{
43	1	$element = $Block['element']['name'];
44
45	1	if (in_array($element, ['h1', 'h2', 'h3', 'h4', 'h5', 'h6']))
46	1	{
47	1	$Block['element']['attributes']['id'] = $this->slugifyHeader($Block);
48	1	}
49	1	}
50
51	3	return $Block;
52		}
53
54	11	private function slugifyHeader($Block)
		0 ignored issues – show Coding Style Naming introduced 2017-10-01 22:57 UTC by Report Bug Copy Issue Report The parameter $Block is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
55		{
56	11	$id = strtolower($Block['element']['text']);
57	11	$id = str_replace(' ', '-', $id);
58	11	$id = preg_replace('/[^0-9a-zA-Z-_]/', '', $id);
59
60	11	return preg_replace('/-+/', '-', $id);
61		}
62
63	3	protected function blockFencedCodeComplete($block)
		0 ignored issues – show Documentation introduced 2017-10-01 22:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
64		{
65		// The class has a `language-` prefix, remove this to get the language
66	3	if (isset($block['element']['text']['attributes']) && Service::getParameter(Configuration::HIGHLIGHTER_ENABLED))
67	3	{
68	2	$cssClass = &$block['element']['text']['attributes']['class'];
69	2	$language = substr($cssClass, 9);
70	2	$cssClass = 'hljs ' . $cssClass;
71
72		try
73		{
74	2	$highlighted = $this->highlighter->highlight($language, $block['element']['text']['text']);
75	1	$block['element']['text']['text'] = $highlighted->value;
76
77		// Only return the block if Highlighter knew the language and how to handle it.
78	1	return $block;
79		}
80		// Exception thrown when language not supported
81	1	catch (\DomainException $exception)
82		{
83	1	trigger_error("An unsupported language ($language) was detected in a code block", E_USER_WARNING);
84		}
85		}
86
87	1	return parent::blockFencedCodeComplete($block);
88		}
89
90		///
91		// MarkupEngine Implementation
92		///
93
94		/**
95		* {@inheritdoc}
96		*/
97	76	public function getTemplateTag()
98		{
99	76	return 'markdown';
100		}
101
102		/**
103		* {@inheritdoc}
104		*/
105	76	public function getExtensions()
106		{
107		return [
108	76	'md',
109	76	'mdown',
110	76	'markdown',
111	76	];
112		}
113		}
114

stakx-io / stakx

Pull Request — master (#66)

MarkdownEngine A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like