ExecManagerTest::getManager() - Code Metrics - Inspection of "Add stream for exec start" - stage1/docker-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( b07707...ef4154 )

by Joel

created 2016-01-09 23:22 UTC

ExecManagerTest::getManager() A

↳ Parent: ExecManagerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Docker\Tests\Manager;

use Docker\API\Model\ContainerConfig;
use Docker\API\Model\ExecConfig;
use Docker\API\Model\ExecStartConfig;
use Docker\Manager\ContainerManager;
use Docker\Manager\ExecManager;
use Docker\Tests\TestCase;

class ExecManagerTest extends TestCase
{
    /**
     * Return the container manager
     *
     * @return ExecManager
     */
    private function getManager()
    {
        return self::getDocker()->getExecManager();
    }

    public function testStartStream()
    {
        $createContainerResult = $this->createContainer();

        $execConfig = new ExecConfig();
        $execConfig->setAttachStdout(true);
        $execConfig->setAttachStderr(true);
        $execConfig->setCmd(["echo", "output"]);

        $execCreateResult = $this->getManager()->create($createContainerResult->getId(), $execConfig);

        $execStartConfig = new ExecStartConfig();
        $execStartConfig->setDetach(false);
        $execStartConfig->setTty(false);

        $stream = $this->getManager()->start($execCreateResult->getId(), $execStartConfig, [], ExecManager::FETCH_STREAM);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->assertInstanceOf('Docker\Stream\DockerRawStream', $stream);

        $stdoutFull = "";
        $stream->onStdout(function ($stdout) use (&$stdoutFull) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $stdoutFull .= $stdout;
        });
        $stream->wait();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->assertEquals("output\n", $stdoutFull);

        self::getDocker()->getContainerManager()->kill($createContainerResult->getId(), [
            'signal' => 'SIGKILL'
        ]);
    }

    private function createContainer()
    {
        $containerConfig = new ContainerConfig();
        $containerConfig->setImage('busybox:latest');
        $containerConfig->setCmd(['sh']);
        $containerConfig->setOpenStdin(true);
        $containerConfig->setLabels(new \ArrayObject(['docker-php-test' => 'true']));

        $containerCreateResult = self::getDocker()->getContainerManager()->create($containerConfig);
        self::getDocker()->getContainerManager()->start($containerCreateResult->getId());

        return $containerCreateResult;
    }
}


1			<?php
2
3			namespace Docker\Tests\Manager;
4
5			use Docker\API\Model\ContainerConfig;
6			use Docker\API\Model\ExecConfig;
7			use Docker\API\Model\ExecStartConfig;
8			use Docker\Manager\ContainerManager;
9			use Docker\Manager\ExecManager;
10			use Docker\Tests\TestCase;
11
12			class ExecManagerTest extends TestCase
13			{
14			/**
15			* Return the container manager
16			*
17			* @return ExecManager
18			*/
19			private function getManager()
20			{
21			return self::getDocker()->getExecManager();
22			}
23
24			public function testStartStream()
25			{
26			$createContainerResult = $this->createContainer();
27
28			$execConfig = new ExecConfig();
29			$execConfig->setAttachStdout(true);
30			$execConfig->setAttachStderr(true);
31			$execConfig->setCmd(["echo", "output"]);
32
33			$execCreateResult = $this->getManager()->create($createContainerResult->getId(), $execConfig);
34
35			$execStartConfig = new ExecStartConfig();
36			$execStartConfig->setDetach(false);
37			$execStartConfig->setTty(false);
38
39			$stream = $this->getManager()->start($execCreateResult->getId(), $execStartConfig, [], ExecManager::FETCH_STREAM);
			0 ignored issues – show Bug introduced 2016-01-09 23:24 UTC by Report Bug Copy Issue Report The method `getId` does only exist in `Docker\API\Model\ExecCreateResult`, but not in `Psr\Http\Message\ResponseInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
40
41			$this->assertInstanceOf('Docker\Stream\DockerRawStream', $stream);
42
43			$stdoutFull = "";
44			$stream->onStdout(function ($stdout) use (&$stdoutFull) {
			0 ignored issues – show Bug introduced 2016-01-09 23:24 UTC by Report Bug Copy Issue Report The method `onStdout` does only exist in `Docker\Stream\DockerRawStream`, but not in `Psr\Http\Message\ResponseInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45			$stdoutFull .= $stdout;
46			});
47			$stream->wait();
			0 ignored issues – show Bug introduced 2016-01-09 23:24 UTC by Report Bug Copy Issue Report The method `wait` does only exist in `Docker\Stream\DockerRawStream`, but not in `Psr\Http\Message\ResponseInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48
49			$this->assertEquals("output\n", $stdoutFull);
50
51			self::getDocker()->getContainerManager()->kill($createContainerResult->getId(), [
52			'signal' => 'SIGKILL'
53			]);
54			}
55
56			private function createContainer()
57			{
58			$containerConfig = new ContainerConfig();
59			$containerConfig->setImage('busybox:latest');
60			$containerConfig->setCmd(['sh']);
61			$containerConfig->setOpenStdin(true);
62			$containerConfig->setLabels(new \ArrayObject(['docker-php-test' => 'true']));
63
64			$containerCreateResult = self::getDocker()->getContainerManager()->create($containerConfig);
65			self::getDocker()->getContainerManager()->start($containerCreateResult->getId());
66
67			return $containerCreateResult;
68			}
69			}
70

stage1 / docker-php

Push — 1.x ( b07707...ef4154 )

ExecManagerTest::getManager() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like