UserCharacterRepository::save() - Code Metrics - Inspection of "Dev" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1890)

by Janko

created 2024-08-24 11:35 UTC

UserCharacterRepository::save() A

↳ Parent: UserCharacterRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
ccs	0
cts	3
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Orm\Repository;

use Doctrine\ORM\EntityRepository;
use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Orm\Entity\UserCharacter;
use Stu\Orm\Entity\UserCharacterInterface;

/**
 * @extends EntityRepository<UserCharacter>
 */
final class UserCharacterRepository extends EntityRepository implements UserCharacterRepositoryInterface
{
    #[Override]
    public function prototype(): UserCharacterInterface
    {
        return new UserCharacter();
    }

    #[Override]
    public function save(UserCharacterInterface $userCharacters): void
    {
        $em = $this->getEntityManager();

        $em->persist($userCharacters);
    }

    #[Override]
    public function delete(UserCharacterInterface $userCharacters): void
    {
        $em = $this->getEntityManager();

        $em->remove($userCharacters);
    }

    /**
     * @return list<UserCharacterInterface>
filter:
    dependency_paths: ["lib/*"]
     */
    #[Override]
    public function findByUserId(int $userId): array
    {
        return $this->findBy(['user' => $userId], ['id' => 'ASC']);

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stu\Orm\Repository;
6
7			use Doctrine\ORM\EntityRepository;
8			use Override;
			0 ignored issues – show Bug introduced 2024-07-04 06:34 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9			use Stu\Orm\Entity\UserCharacter;
10			use Stu\Orm\Entity\UserCharacterInterface;
11
12			/**
13			* @extends EntityRepository<UserCharacter>
14			*/
15			final class UserCharacterRepository extends EntityRepository implements UserCharacterRepositoryInterface
16			{
17			#[Override]
18			public function prototype(): UserCharacterInterface
19			{
20			return new UserCharacter();
21			}
22
23			#[Override]
24			public function save(UserCharacterInterface $userCharacters): void
25			{
26			$em = $this->getEntityManager();
27
28			$em->persist($userCharacters);
29			}
30
31			#[Override]
32			public function delete(UserCharacterInterface $userCharacters): void
33			{
34			$em = $this->getEntityManager();
35
36			$em->remove($userCharacters);
37			}
38
39			/**
40			* @return list<UserCharacterInterface>
			0 ignored issues – show Bug introduced 2024-03-23 13:09 UTC by Report Bug Copy Issue Report The type `Stu\Orm\Repository\list` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
41			*/
42			#[Override]
43			public function findByUserId(int $userId): array
44			{
45			return $this->findBy(['user' => $userId], ['id' => 'ASC']);
			0 ignored issues – show Bug Best Practice introduced 2024-07-05 10:49 UTC by Report Bug Copy Issue Report The expression `return $this->findBy(arr..., array('id' => 'ASC'))` returns the type `array<mixed,mixed>` which is incompatible with the documented return type `Stu\Orm\Repository\list`. Loading history...
46			}
47			}
48

st-universe / core

Pull Request — master (#1890)

UserCharacterRepository::save() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like