PrestigeCalculation::getPrestigeOfBattleParty() - Code Metrics - Inspection of "return LocationInterface" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6d8b29...d7e053 )

by Janko

created 2024-08-20 17:34 UTC

PrestigeCalculation::getPrestigeOfBattleParty() A

↳ Parent: PrestigeCalculation

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	7
ccs	6
cts	6
cp	1
crap	1
rs	10
c	1
b	0
f	0

<?php

namespace Stu\Module\Prestige\Lib;

use Stu\Module\Ship\Lib\Battle\Party\BattlePartyInterface;
use Stu\Module\Ship\Lib\ShipWrapperInterface;
use Stu\Orm\Entity\ShipInterface;

class PrestigeCalculation implements PrestigeCalculationInterface
{

    public function getPrestigeOfSpacecraftOrFleet(ShipWrapperInterface|ShipInterface $spacecraft): int
    {
        $target = $spacecraft instanceof ShipInterface ? $spacecraft : $spacecraft->get();

        $fleet = $target->getFleet();
        if ($fleet !== null) {
            return array_reduce(
                $fleet->getShips()->toArray(),
                fn(int $value, ShipInterface $fleetShip): int => $value + $fleetShip->getRump()->getPrestige(),
                0
            );
        }

        return $target->getRump()->getPrestige();
    }

    public function targetHasPositivePrestige(ShipInterface $target): bool
    {
        $fleet = $target->getFleet();
        if ($fleet !== null) {
            foreach ($fleet->getShips() as $ship) {
                if ($ship->getRump()->getPrestige() > 0) {
                    return true;
                }
            }
        }

        return $target->getRump()->getPrestige() > 0;
    }

    public function getPrestigeOfBattleParty(BattlePartyInterface $battleParty): int
    {
        return $battleParty->getActiveMembers()
            ->map(fn(ShipWrapperInterface $wrapper) => $wrapper->get()->getRump()->getPrestige())
            ->reduce(
                fn(int $sum, int $prestige) => $sum + $prestige,
                0
            );
    }
}


1		<?php
2
3		namespace Stu\Module\Prestige\Lib;
4
5		use Stu\Module\Ship\Lib\Battle\Party\BattlePartyInterface;
6		use Stu\Module\Ship\Lib\ShipWrapperInterface;
7		use Stu\Orm\Entity\ShipInterface;
8
9		class PrestigeCalculation implements PrestigeCalculationInterface
10		{
11
12	3	public function getPrestigeOfSpacecraftOrFleet(ShipWrapperInterface\|ShipInterface $spacecraft): int
13		{
14	3	$target = $spacecraft instanceof ShipInterface ? $spacecraft : $spacecraft->get();
15
16	3	$fleet = $target->getFleet();
17	3	if ($fleet !== null) {
18	1	return array_reduce(
19	1	$fleet->getShips()->toArray(),
20	1	fn(int $value, ShipInterface $fleetShip): int => $value + $fleetShip->getRump()->getPrestige(),
21	1	0
22	1	);
23		}
24
25	2	return $target->getRump()->getPrestige();
26		}
27
28	3	public function targetHasPositivePrestige(ShipInterface $target): bool
29		{
30	3	$fleet = $target->getFleet();
31	3	if ($fleet !== null) {
32	1	foreach ($fleet->getShips() as $ship) {
33	1	if ($ship->getRump()->getPrestige() > 0) {
34	1	return true;
35		}
36		}
37		}
38
39	2	return $target->getRump()->getPrestige() > 0;
40		}
41
42	1	public function getPrestigeOfBattleParty(BattlePartyInterface $battleParty): int
43		{
44	1	return $battleParty->getActiveMembers()
45	1	->map(fn(ShipWrapperInterface $wrapper) => $wrapper->get()->getRump()->getPrestige())
46	1	->reduce(
47	1	fn(int $sum, int $prestige) => $sum + $prestige,
48	1	0
49	1	);
50		}
51		}
52

st-universe / core

Push — master ( 6d8b29...d7e053 )

PrestigeCalculation::getPrestigeOfBattleParty() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like