st-universe /
core
| Total Complexity | 59 |
| Total Lines | 379 |
| Duplicated Lines | 0 % |
| Coverage | 0% |
| Changes | 0 | ||
Complex classes like TroopTransfer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TroopTransfer, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 37 | final class TroopTransfer implements ActionControllerInterface |
||
| 38 | { |
||
| 39 | public const ACTION_IDENTIFIER = 'B_TROOP_TRANSFER'; |
||
| 40 | |||
| 41 | private ShipLoaderInterface $shipLoader; |
||
| 42 | |||
| 43 | private ShipRepositoryInterface $shipRepository; |
||
| 44 | |||
| 45 | private ColonyRepositoryInterface $colonyRepository; |
||
| 46 | |||
| 47 | private TroopTransferUtilityInterface $transferUtility; |
||
| 48 | |||
| 49 | private ActivatorDeactivatorHelperInterface $helper; |
||
| 50 | |||
| 51 | private ShipSystemManagerInterface $shipSystemManager; |
||
| 52 | |||
| 53 | private DockPrivilegeUtilityInterface $dockPrivilegeUtility; |
||
| 54 | |||
| 55 | private ShipWrapperFactoryInterface $shipWrapperFactory; |
||
| 56 | |||
| 57 | private PrivateMessageSenderInterface $privateMessageSender; |
||
| 58 | |||
| 59 | private ColonyLibFactoryInterface $colonyLibFactory; |
||
| 60 | |||
| 61 | private ShipShutdownInterface $shipShutdown; |
||
| 62 | |||
| 63 | private LoggerUtilInterface $loggerUtil; |
||
| 64 | |||
| 65 | public function __construct( |
||
| 91 | } |
||
| 92 | |||
| 93 | public function handle(GameControllerInterface $game): void |
||
| 223 | } |
||
| 224 | } |
||
| 225 | |||
| 226 | private function transferToColony(int $requestedTransferCount, ShipInterface $ship, ColonyInterface $colony): int |
||
| 227 | { |
||
| 228 | $freeAssignmentCount = $this->colonyLibFactory->createColonyPopulationCalculator( |
||
| 229 | $colony |
||
| 230 | )->getFreeAssignmentCount(); |
||
| 231 | |||
| 232 | $amount = min( |
||
| 233 | $requestedTransferCount, |
||
| 234 | $this->transferUtility->getBeamableTroopCount($ship), |
||
| 235 | $freeAssignmentCount |
||
| 236 | ); |
||
| 237 | |||
| 238 | $assignments = $ship->getCrewAssignments()->getValues(); |
||
| 239 | |||
| 240 | for ($i = 0; $i < $amount; $i++) { |
||
| 241 | //assign crew to colony |
||
| 242 | $this->transferUtility->assignCrew($assignments[$i], $colony); |
||
| 243 | } |
||
| 244 | |||
| 245 | return $amount; |
||
| 246 | } |
||
| 247 | |||
| 248 | private function transferFromColony(int $requestedTransferCount, ShipWrapperInterface $wrapper, ColonyInterface $colony, GameControllerInterface $game): int |
||
| 249 | { |
||
| 250 | $ship = $wrapper->get(); |
||
| 251 | |||
| 252 | $amount = min( |
||
| 253 | $requestedTransferCount, |
||
| 254 | $colony->getCrewAssignmentAmount(), |
||
| 255 | $this->transferUtility->getFreeQuarters($ship) |
||
| 256 | ); |
||
| 257 | |||
| 258 | if ( |
||
| 259 | $amount > 0 |
||
| 260 | && $ship->getShipSystem(ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS)->getMode() === ShipSystemModeEnum::MODE_OFF |
||
| 261 | && !$this->helper->activate($wrapper, ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS, $game) |
||
| 262 | ) { |
||
| 263 | throw new SystemNotActivatableException(); |
||
| 264 | } |
||
| 265 | |||
| 266 | $crewAssignments = $colony->getCrewAssignments(); |
||
| 267 | |||
| 268 | for ($i = 0; $i < $amount; $i++) { |
||
| 269 | /** @var ShipCrewInterface $crewAssignment */ |
||
| 270 | $crewAssignment = $crewAssignments->get(array_rand($crewAssignments->toArray())); |
||
|
Bug
introduced
by
|
|||
| 271 | |||
| 272 | $this->transferUtility->assignCrew($crewAssignment, $ship); |
||
| 273 | } |
||
| 274 | |||
| 275 | return $amount; |
||
| 276 | } |
||
| 277 | |||
| 278 | private function transferToShip( |
||
| 279 | int $requestedTransferCount, |
||
| 280 | ShipInterface $ship, |
||
| 281 | ShipInterface $target, |
||
| 282 | bool $isUplinkSituation, |
||
| 283 | int $ownCrewOnTarget, |
||
| 284 | GameControllerInterface $game |
||
| 285 | ): int { |
||
| 286 | if (!$target->hasShipSystem(ShipSystemTypeEnum::SYSTEM_LIFE_SUPPORT)) { |
||
| 287 | $game->addInformation(sprintf(_('Die %s hat keine Lebenserhaltungssysteme'), $target->getName())); |
||
| 288 | |||
| 289 | throw new SystemNotFoundException(); |
||
| 290 | } |
||
| 291 | |||
| 292 | $this->loggerUtil->log(sprintf('ownCrewOnTarget: %d', $ownCrewOnTarget)); |
||
| 293 | |||
| 294 | $amount = min( |
||
| 295 | $requestedTransferCount, |
||
| 296 | $this->transferUtility->getBeamableTroopCount($ship), |
||
| 297 | $this->transferUtility->getFreeQuarters($target), |
||
| 298 | $isUplinkSituation ? ($ownCrewOnTarget === 0 ? 1 : 0) : PHP_INT_MAX |
||
| 299 | ); |
||
| 300 | |||
| 301 | $assignments = $ship->getCrewAssignments()->getValues(); |
||
| 302 | |||
| 303 | for ($i = 0; $i < $amount; $i++) { |
||
| 304 | $this->transferUtility->assignCrew($assignments[$i], $target); |
||
| 305 | } |
||
| 306 | |||
| 307 | if ($amount > 0) { |
||
| 308 | if ( |
||
| 309 | $target->isSystemHealthy(ShipSystemTypeEnum::SYSTEM_LIFE_SUPPORT) |
||
| 310 | && $target->getShipSystem(ShipSystemTypeEnum::SYSTEM_LIFE_SUPPORT)->getMode() == ShipSystemModeEnum::MODE_OFF |
||
| 311 | ) { |
||
| 312 | $this->shipSystemManager->activate($this->shipWrapperFactory->wrapShip($target), ShipSystemTypeEnum::SYSTEM_LIFE_SUPPORT, true); |
||
| 313 | } |
||
| 314 | |||
| 315 | if ($isUplinkSituation) { |
||
| 316 | $target->getShipSystem(ShipSystemTypeEnum::SYSTEM_UPLINK)->setMode(ShipSystemModeEnum::MODE_ON); |
||
| 317 | $this->sendUplinkMessage(true, true, $ship, $target); |
||
| 318 | } |
||
| 319 | } |
||
| 320 | |||
| 321 | return $amount; |
||
| 322 | } |
||
| 323 | |||
| 324 | private function transferFromShip( |
||
| 325 | int $requestedTransferCount, |
||
| 326 | ShipWrapperInterface $wrapper, |
||
| 327 | ShipInterface $target, |
||
| 328 | bool $isUplinkSituation, |
||
| 329 | int $ownCrewOnTarget, |
||
| 330 | GameControllerInterface $game |
||
| 331 | ): int { |
||
| 332 | $ship = $wrapper->get(); |
||
| 333 | |||
| 334 | $amount = min( |
||
| 335 | $requestedTransferCount, |
||
| 336 | $this->transferUtility->getFreeQuarters($ship), |
||
| 337 | $ownCrewOnTarget |
||
| 338 | ); |
||
| 339 | |||
| 340 | if ( |
||
| 341 | $amount > 0 |
||
| 342 | && $ship->getShipSystem(ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS)->getMode() === ShipSystemModeEnum::MODE_OFF |
||
| 343 | && !$this->helper->activate($wrapper, ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS, $game) |
||
| 344 | ) { |
||
| 345 | throw new SystemNotActivatableException(); |
||
| 346 | } |
||
| 347 | |||
| 348 | $array = $target->getCrewAssignments()->getValues(); |
||
| 349 | $targetCrewCount = $target->getCrewCount(); |
||
| 350 | |||
| 351 | $i = 0; |
||
| 352 | foreach ($array as $crewAssignment) { |
||
| 353 | if ($crewAssignment->getCrew()->getUser() !== $ship->getUser()) { |
||
| 354 | continue; |
||
| 355 | } |
||
| 356 | |||
| 357 | $this->transferUtility->assignCrew($crewAssignment, $ship); |
||
| 358 | $i++; |
||
| 359 | |||
| 360 | if ($i === $amount) { |
||
| 361 | break; |
||
| 362 | } |
||
| 363 | } |
||
| 364 | |||
| 365 | if ($amount > 0 && $isUplinkSituation) { |
||
| 366 | //no foreigners left, shut down uplink |
||
| 367 | if ($this->transferUtility->foreignerCount($target) === 0) { |
||
| 368 | $target->getShipSystem(ShipSystemTypeEnum::SYSTEM_UPLINK)->setMode(ShipSystemModeEnum::MODE_OFF); |
||
| 369 | $this->sendUplinkMessage(false, false, $ship, $target); |
||
| 370 | } else { |
||
| 371 | $this->sendUplinkMessage(false, true, $ship, $target); |
||
| 372 | } |
||
| 373 | } |
||
| 374 | |||
| 375 | $targetWrapper = $this->shipWrapperFactory->wrapShip($target); |
||
| 376 | |||
| 377 | // no crew left |
||
| 378 | if ($amount === $targetCrewCount) { |
||
| 379 | $this->shipShutdown->shutdown($targetWrapper); |
||
| 380 | } elseif ( |
||
| 381 | $target->hasShipSystem(ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS) |
||
| 382 | && $target->getSystemState(ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS) |
||
| 383 | && $target->getCrewCount() <= $target->getBuildplan()->getCrew() |
||
| 384 | ) { |
||
| 385 | $this->helper->deactivate($targetWrapper, ShipSystemTypeEnum::SYSTEM_TROOP_QUARTERS, $game); |
||
| 386 | } |
||
| 387 | |||
| 388 | return $amount; |
||
| 389 | } |
||
| 390 | |||
| 391 | private function sendUplinkMessage(bool $isUnload, bool $isOn, ShipInterface $ship, ShipInterface $target): void |
||
| 410 | ); |
||
| 411 | } |
||
| 412 | |||
| 413 | public function performSessionCheck(): bool |
||
| 416 | } |
||
| 417 | } |
||
| 418 |
Loading history...