SubspaceSystemData::getHighlightedFlightSig() - Code Metrics - Inspection of "skip initialization if not present" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5c1ca2...a370b2 )

by Nico

created 2025-08-01 13:09 UTC

SubspaceSystemData::getHighlightedFlightSig() B

↳ Parent: SubspaceSystemData

Complexity

Conditions	8
Paths	7

Size

Total Lines	36
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
cc	8
eloc	23
c	0
b	0
f	0
nc	7
nop	1
dl	0
loc	36
ccs	0
cts	23
cp	0
crap	72
rs	8.4444

<?php

declare(strict_types=1);

namespace Stu\Component\Spacecraft\System\Data;

use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Module\Template\StatusBarFactoryInterface;
use Stu\Orm\Entity\FlightSignature;
use Stu\Orm\Entity\Spacecraft;
use Stu\Orm\Repository\SpacecraftSystemRepositoryInterface;
use Stu\Orm\Repository\FlightSignatureRepositoryInterface;

class SubspaceSystemData extends AbstractSystemData
{
    public ?int $spacecraftId = null;
    public ?int $analyzeTime = null;
    public ?int $flightSigId = null;

    public function __construct(
        SpacecraftSystemRepositoryInterface $shipSystemRepository,
        StatusBarFactoryInterface $statusBarFactory,
        private readonly FlightSignatureRepositoryInterface $flightSignatureRepository
    ) {
        parent::__construct($shipSystemRepository, $statusBarFactory);
    }

    #[Override]
    public function getSystemType(): SpacecraftSystemTypeEnum
    {
        return SpacecraftSystemTypeEnum::SUBSPACE_SCANNER;
    }

    public function getSpacecraftId(): ?int
    {
        return $this->spacecraftId ?? null;
    }

    public function setSpacecraftId(?int $spacecraftId): SubspaceSystemData
    {
        $this->spacecraftId = $spacecraftId;
        return $this;
    }

    public function getAnalyzeTime(): ?int
    {
        return $this->analyzeTime ?? null;
    }

    public function setAnalyzeTime(?int $analyzeTime): SubspaceSystemData
    {
        $this->analyzeTime = $analyzeTime;
        return $this;
    }

    public function getFlightSigId(): ?int
    {
        return $this->flightSigId ?? null;
    }

    public function setFlightSigId(?int $flightSigId): SubspaceSystemData
    {
        $this->flightSigId = $flightSigId;
        return $this;
    }

    public function getHighlightedFlightSig(Spacecraft $spacecraft): ?FlightSignature
    {
        $isSubspaceScannerActive = $spacecraft->getSystemState(SpacecraftSystemTypeEnum::SUBSPACE_SCANNER);
        if (!$isSubspaceScannerActive) {
            return null;
        }

        $isMatrixScannerHealthy = $spacecraft->isSystemHealthy(SpacecraftSystemTypeEnum::MATRIX_SCANNER);
        if (!$isMatrixScannerHealthy) {
            return null;
        }

        $subspaceSystem = $spacecraft->getSpacecraftSystem(SpacecraftSystemTypeEnum::SUBSPACE_SCANNER);
        if ($subspaceSystem->getData() === null) {
            return null;
        }

        $analyzeTime = $this->getAnalyzeTime();
        if ($analyzeTime === null) {
            return null;
        }

        $currentTime = time();
        $minTime = $analyzeTime + (3 * 60);
        $maxTime = $analyzeTime + (10 * 60);

        if (!($currentTime >= $minTime && $currentTime <= $maxTime)) {
            return null;
        }

        $flightSigId = $this->getFlightSigId();
        if ($flightSigId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $flightSig = $this->flightSignatureRepository->find($flightSigId);
            return $flightSig;
        } else {
            return null;
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stu\Component\Spacecraft\System\Data;
6
7			use Override;
			0 ignored issues – show Bug introduced 2025-07-17 15:13 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
9			use Stu\Module\Template\StatusBarFactoryInterface;
10			use Stu\Orm\Entity\FlightSignature;
11			use Stu\Orm\Entity\Spacecraft;
12			use Stu\Orm\Repository\SpacecraftSystemRepositoryInterface;
13			use Stu\Orm\Repository\FlightSignatureRepositoryInterface;
14
15			class SubspaceSystemData extends AbstractSystemData
16			{
17			public ?int $spacecraftId = null;
18			public ?int $analyzeTime = null;
19			public ?int $flightSigId = null;
20
21			public function __construct(
22			SpacecraftSystemRepositoryInterface $shipSystemRepository,
23			StatusBarFactoryInterface $statusBarFactory,
24			private readonly FlightSignatureRepositoryInterface $flightSignatureRepository
25			) {
26			parent::__construct($shipSystemRepository, $statusBarFactory);
27			}
28
29			#[Override]
30			public function getSystemType(): SpacecraftSystemTypeEnum
31			{
32			return SpacecraftSystemTypeEnum::SUBSPACE_SCANNER;
33			}
34
35			public function getSpacecraftId(): ?int
36			{
37			return $this->spacecraftId ?? null;
38			}
39
40			public function setSpacecraftId(?int $spacecraftId): SubspaceSystemData
41			{
42			$this->spacecraftId = $spacecraftId;
43			return $this;
44			}
45
46			public function getAnalyzeTime(): ?int
47			{
48			return $this->analyzeTime ?? null;
49			}
50
51			public function setAnalyzeTime(?int $analyzeTime): SubspaceSystemData
52			{
53			$this->analyzeTime = $analyzeTime;
54			return $this;
55			}
56
57			public function getFlightSigId(): ?int
58			{
59			return $this->flightSigId ?? null;
60			}
61
62			public function setFlightSigId(?int $flightSigId): SubspaceSystemData
63			{
64			$this->flightSigId = $flightSigId;
65			return $this;
66			}
67
68			public function getHighlightedFlightSig(Spacecraft $spacecraft): ?FlightSignature
69			{
70			$isSubspaceScannerActive = $spacecraft->getSystemState(SpacecraftSystemTypeEnum::SUBSPACE_SCANNER);
71			if (!$isSubspaceScannerActive) {
72			return null;
73			}
74
75			$isMatrixScannerHealthy = $spacecraft->isSystemHealthy(SpacecraftSystemTypeEnum::MATRIX_SCANNER);
76			if (!$isMatrixScannerHealthy) {
77			return null;
78			}
79
80			$subspaceSystem = $spacecraft->getSpacecraftSystem(SpacecraftSystemTypeEnum::SUBSPACE_SCANNER);
81			if ($subspaceSystem->getData() === null) {
82			return null;
83			}
84
85			$analyzeTime = $this->getAnalyzeTime();
86			if ($analyzeTime === null) {
87			return null;
88			}
89
90			$currentTime = time();
91			$minTime = $analyzeTime + (3 * 60);
92			$maxTime = $analyzeTime + (10 * 60);
93
94			if (!($currentTime >= $minTime && $currentTime <= $maxTime)) {
95			return null;
96			}
97
98			$flightSigId = $this->getFlightSigId();
99			if ($flightSigId) {
			0 ignored issues – show Bug Best Practice introduced 2025-08-01 10:25 UTC by Report Bug Copy Issue Report The expression `$flightSigId` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
100			$flightSig = $this->flightSignatureRepository->find($flightSigId);
101			return $flightSig;
102			} else {
103			return null;
104			}
105			}
106			}
107

st-universe / core

Push — master ( 5c1ca2...a370b2 )

SubspaceSystemData::getHighlightedFlightSig() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like