EnemyDeterminator::__construct() - Code Metrics - Inspection of "introduce BattleParties" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 59981f...f2247e )

by Janko

created 2024-06-20 08:56 UTC

EnemyDeterminator::__construct() A

↳ Parent: EnemyDeterminator

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	6
ccs	3
cts	3
cp	1
crap	1
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Component\Player\Relation;

use Stu\Component\Alliance\AllianceEnum;
use Stu\Orm\Entity\UserInterface;
use Stu\Orm\Repository\AllianceRelationRepositoryInterface;
use Stu\Orm\Repository\ContactRepositoryInterface;

class EnemyDeterminator
{
    private AllianceRelationRepositoryInterface $allianceRelationRepository;

    private ContactRepositoryInterface $contactRepository;

    public function __construct(
        AllianceRelationRepositoryInterface $allianceRelationRepository,
        ContactRepositoryInterface $contactRepository
    ) {
        $this->allianceRelationRepository = $allianceRelationRepository;
        $this->contactRepository = $contactRepository;
    }

    public function isEnemy(UserInterface $user, UserInterface $otherUser): bool
    {
        $alliance = $user->getAlliance();

        $otherUserAlliance = $otherUser->getAlliance();

        if ($alliance !== null && $otherUserAlliance !== null) {
            if ($alliance === $otherUserAlliance) {
                return false;
            }

            $result = $this->allianceRelationRepository->getActiveByTypeAndAlliancePair(
                [
                    AllianceEnum::ALLIANCE_RELATION_WAR,
                ],
                $otherUserAlliance->getId(),
                $alliance->getId()
            );

            if ($result !== null) {
                return true;
            }
        }

        $contact = $this->contactRepository->getByUserAndOpponent(
            $user->getId(),
            $otherUser->getId()
        );

        return $contact !== null && $contact->isEnemy();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Component\Player\Relation;
6
7		use Stu\Component\Alliance\AllianceEnum;
8		use Stu\Orm\Entity\UserInterface;
9		use Stu\Orm\Repository\AllianceRelationRepositoryInterface;
10		use Stu\Orm\Repository\ContactRepositoryInterface;
11
12		class EnemyDeterminator
13		{
14		private AllianceRelationRepositoryInterface $allianceRelationRepository;
15
16		private ContactRepositoryInterface $contactRepository;
17
18	4	public function __construct(
19		AllianceRelationRepositoryInterface $allianceRelationRepository,
20		ContactRepositoryInterface $contactRepository
21		) {
22	4	$this->allianceRelationRepository = $allianceRelationRepository;
23	4	$this->contactRepository = $contactRepository;
24		}
25
26	4	public function isEnemy(UserInterface $user, UserInterface $otherUser): bool
27		{
28	4	$alliance = $user->getAlliance();
29
30	4	$otherUserAlliance = $otherUser->getAlliance();
31
32	4	if ($alliance !== null && $otherUserAlliance !== null) {
33	3	if ($alliance === $otherUserAlliance) {
34	1	return false;
35		}
36
37	2	$result = $this->allianceRelationRepository->getActiveByTypeAndAlliancePair(
38	2	[
39	2	AllianceEnum::ALLIANCE_RELATION_WAR,
40	2	],
41	2	$otherUserAlliance->getId(),
42	2	$alliance->getId()
43	2	);
44
45	2	if ($result !== null) {
46	1	return true;
47		}
48		}
49
50	2	$contact = $this->contactRepository->getByUserAndOpponent(
51	2	$user->getId(),
52	2	$otherUser->getId()
53	2	);
54
55	2	return $contact !== null && $contact->isEnemy();
56		}
57		}
58

st-universe / core

Push — dev ( 59981f...f2247e )

EnemyDeterminator::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like