st-universe /
core
| Conditions | 10 |
| Paths | 24 |
| Total Lines | 66 |
| Code Lines | 44 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 110 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function intercept(ShipInterface $ship, ShipInterface $target, InformationInterface $informations): void |
||
| 33 | { |
||
| 34 | $userId = $ship->getUser()->getId(); |
||
| 35 | $wrapper = $this->shipWrapperFactory->wrapShip($ship); |
||
| 36 | $targetWrapper = $this->shipWrapperFactory->wrapShip($target); |
||
| 37 | |||
| 38 | if ($ship->getDockedTo() !== null) { |
||
| 39 | $informations->addInformation('Das Schiff hat abgedockt'); |
||
| 40 | $ship->setDockedTo(null); |
||
| 41 | } |
||
| 42 | if ($target->getFleet() !== null) { |
||
| 43 | foreach ($target->getFleet()->getShips() as $fleetShip) { |
||
| 44 | try { |
||
| 45 | $this->shipSystemManager->deactivate($this->shipWrapperFactory->wrapShip($fleetShip), ShipSystemTypeEnum::SYSTEM_WARPDRIVE); |
||
| 46 | } catch (AlreadyOffException $e) { |
||
|
Coding Style
Comprehensibility
introduced
by
|
|||
| 47 | } |
||
| 48 | $this->shipRepository->save($fleetShip); |
||
| 49 | } |
||
| 50 | |||
| 51 | $informations->addInformationf("Die Flotte %s wurde abgefangen", $target->getFleet()->getName()); |
||
| 52 | $pm = "Die Flotte " . $target->getFleet()->getName() . " wurde von der " . $ship->getName() . " abgefangen"; |
||
| 53 | } else { |
||
| 54 | $this->shipSystemManager->deactivate($targetWrapper, ShipSystemTypeEnum::SYSTEM_WARPDRIVE); |
||
| 55 | |||
| 56 | $informations->addInformationf("Die %s wurde abgefangen", $target->getName()); |
||
| 57 | $pm = "Die " . $target->getName() . " wurde von der " . $ship->getName() . " abgefangen"; |
||
| 58 | |||
| 59 | $this->shipRepository->save($target); |
||
| 60 | } |
||
| 61 | |||
| 62 | $href = sprintf('ship.php?%s=1&id=%d', ShowShip::VIEW_IDENTIFIER, $target->getId()); |
||
| 63 | |||
| 64 | $this->privateMessageSender->send( |
||
| 65 | $userId, |
||
| 66 | $target->getUser()->getId(), |
||
| 67 | $pm, |
||
| 68 | PrivateMessageFolderSpecialEnum::PM_SPECIAL_SHIP, |
||
| 69 | $href |
||
| 70 | ); |
||
| 71 | $interceptorLeftWarp = false; |
||
| 72 | if ($ship->getFleet() !== null) { |
||
| 73 | foreach ($ship->getFleet()->getShips() as $fleetShip) { |
||
| 74 | try { |
||
| 75 | $this->shipSystemManager->deactivate($this->shipWrapperFactory->wrapShip($fleetShip), ShipSystemTypeEnum::SYSTEM_WARPDRIVE); |
||
| 76 | $interceptorLeftWarp = true; |
||
| 77 | } catch (AlreadyOffException $e) { |
||
| 78 | } |
||
| 79 | $this->shipRepository->save($fleetShip); |
||
| 80 | } |
||
| 81 | } else { |
||
| 82 | try { |
||
| 83 | $this->shipSystemManager->deactivate($wrapper, ShipSystemTypeEnum::SYSTEM_WARPDRIVE); |
||
| 84 | $interceptorLeftWarp = true; |
||
| 85 | } catch (AlreadyOffException $e) { |
||
| 86 | } |
||
| 87 | |||
| 88 | $this->shipRepository->save($ship); |
||
| 89 | } |
||
| 90 | $this->entityManager->flush(); |
||
| 91 | |||
| 92 | //Alert red check for the target(s) |
||
| 93 | $this->alertRedHelper->doItAll($target, $informations); |
||
| 94 | |||
| 95 | //Alert red check for the interceptor(s) |
||
| 96 | if ($interceptorLeftWarp) { |
||
| 97 | $this->alertRedHelper->doItAll($ship, $informations); |
||
| 98 | } |
||
| 106 |
Loading history...