PlayerRelationDeterminator::isEnemy() - Code Metrics - Inspection of "fixed ticket-0698" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e661f4...30021e )

by Nico

created 2025-04-29 07:11 UTC

PlayerRelationDeterminator::isEnemy() A

↳ Parent: PlayerRelationDeterminator

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	8
nc	3
nop	2
dl	0
loc	14
ccs	8
cts	8
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Component\Player\Relation;

use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Orm\Entity\UserInterface;

/**
 * Some locations require to determine if a certain user is friendly towards the player
 */
final class PlayerRelationDeterminator implements PlayerRelationDeterminatorInterface
{
    public function __construct(
        private FriendDeterminator $friendDeterminator,
        private EnemyDeterminator $enemyDeterminator
    ) {}

    #[Override]
    public function isFriend(?UserInterface $user, ?UserInterface $otherUser): bool
    {
        if ($user === null || $otherUser === null) {
            return false;
        }

        if ($user === $otherUser) {
            return true;
        }

        $friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
        if ($friendRelation->isDominant()) {
            return true;
        }

        $enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
        if ($enemyRelation->isDominant()) {
            return false;
        }

        return $friendRelation !== PlayerRelationTypeEnum::NONE;
    }

    #[Override]
    public function isEnemy(UserInterface $user, UserInterface $otherUser): bool
    {
        $enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
        if ($enemyRelation->isDominant()) {
            return true;
        }

        $friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
        if ($friendRelation->isDominant()) {
            return false;
        }

        return $enemyRelation !== PlayerRelationTypeEnum::NONE;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Component\Player\Relation;
6
7		use Override;
		0 ignored issues – show Bug introduced 2024-07-04 06:34 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8		use Stu\Orm\Entity\UserInterface;
9
10		/**
11		* Some locations require to determine if a certain user is friendly towards the player
12		*/
13		final class PlayerRelationDeterminator implements PlayerRelationDeterminatorInterface
14		{
15	16	public function __construct(
16		private FriendDeterminator $friendDeterminator,
17		private EnemyDeterminator $enemyDeterminator
18	16	) {}
19
20	21	#[Override]
21		public function isFriend(?UserInterface $user, ?UserInterface $otherUser): bool
22		{
23	21	if ($user === null \|\| $otherUser === null) {
24		return false;
25		}
26
27	21	if ($user === $otherUser) {
28	13	return true;
29		}
30
31	8	$friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
32	8	if ($friendRelation->isDominant()) {
33	2	return true;
34		}
35
36	6	$enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
37	6	if ($enemyRelation->isDominant()) {
38	2	return false;
39		}
40
41	4	return $friendRelation !== PlayerRelationTypeEnum::NONE;
42		}
43
44	7	#[Override]
45		public function isEnemy(UserInterface $user, UserInterface $otherUser): bool
46		{
47	7	$enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
48	7	if ($enemyRelation->isDominant()) {
49	2	return true;
50		}
51
52	5	$friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
53	5	if ($friendRelation->isDominant()) {
54	2	return false;
55		}
56
57	3	return $enemyRelation !== PlayerRelationTypeEnum::NONE;
58		}
59		}
60

st-universe / core

Push — master ( e661f4...30021e )

PlayerRelationDeterminator::isEnemy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like