Location::__construct() - Code Metrics - Inspection of "anomaly consequences" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 840a26...5b15b7 )

by Janko

created 2023-07-07 15:51 UTC

Location::__construct() A

↳ Parent: Location

Complexity

Conditions	6
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	5
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	10
ccs	0
cts	5
cp	0
crap	42
rs	9.2222

<?php

declare(strict_types=1);

namespace Stu\Lib\Map;

use Doctrine\Common\Collections\Collection;
use InvalidArgumentException;
use Stu\Orm\Entity\MapInterface;
use Stu\Orm\Entity\ShipInterface;
use Stu\Orm\Entity\StarSystemMapInterface;

class Location
{
    private MapInterface|StarSystemMapInterface $location;

    public function __construct(?MapInterface $map, ?StarSystemMapInterface $sysMap)
    {
        if (
            $map === null && $sysMap === null

            || $map !== null && $sysMap !== null
        ) {
            throw new InvalidArgumentException('Either map or systemMap has to be filled');
        }

        $this->location = $map !== null ? $map : $sysMap;
    }

    /**
     * @return Collection<int, ShipInterface>
     */
    public function getShips(): Collection
    {
        return $this->location->getShips();
    }

    public function getSectorString(): string
    {
        return $this->location->getSectorString();
    }

    public function hasAnomaly(int $anomalyType): bool
    {
        foreach ($this->location->getAnomalies() as $anomaly) {
            if ($anomaly->getAnomalyType()->getId() === $anomalyType) {
                return true;
            }
        }

        return false;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stu\Lib\Map;
6
7			use Doctrine\Common\Collections\Collection;
8			use InvalidArgumentException;
9			use Stu\Orm\Entity\MapInterface;
10			use Stu\Orm\Entity\ShipInterface;
11			use Stu\Orm\Entity\StarSystemMapInterface;
12
13			class Location
14			{
15			private MapInterface\|StarSystemMapInterface $location;
16
17			public function __construct(?MapInterface $map, ?StarSystemMapInterface $sysMap)
18			{
19			if (
20			$map === null && $sysMap === null
			0 ignored issues – show introduced 2023-07-07 16:09 UTC by Report Bug Copy Issue Report Consider adding parentheses for clarity. Current Interpretation: `($map === null && $sysMa...ull && $sysMap !== null`, Probably Intended Meaning: `$map === null && ($sysMa...ll && $sysMap !== null)` Loading history...
21			\|\| $map !== null && $sysMap !== null
22			) {
23			throw new InvalidArgumentException('Either map or systemMap has to be filled');
24			}
25
26			$this->location = $map !== null ? $map : $sysMap;
27			}
28
29			/**
30			* @return Collection<int, ShipInterface>
31			*/
32			public function getShips(): Collection
33			{
34			return $this->location->getShips();
35			}
36
37			public function getSectorString(): string
38			{
39			return $this->location->getSectorString();
40			}
41
42			public function hasAnomaly(int $anomalyType): bool
43			{
44			foreach ($this->location->getAnomalies() as $anomaly) {
45			if ($anomaly->getAnomalyType()->getId() === $anomalyType) {
46			return true;
47			}
48			}
49
50			return false;
51			}
52			}
53

st-universe / core

Push — dev ( 840a26...5b15b7 )

Location::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like