Stu\Component\Player\Deletion\Handler\AllianceDeletionHandler

Complexity

Total Complexity

14

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Test Coverage

Coverage

75%

Importance

Changes	1
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getLastOnlineMember()	0	13	3
A	__construct()	0	1	1
B	delete()	0	43	10

<?php

declare(strict_types=1);

namespace Stu\Component\Player\Deletion\Handler;

use Override;

The type Override was not found. Maybe you did not declare it correctly or list all dependencies?

use Doctrine\Common\Collections\Collection;
use Stu\Component\Alliance\AllianceEnum;

The type Stu\Component\Alliance\AllianceEnum was not found. Maybe you did not declare it correctly or list all dependencies?

use Stu\Module\Alliance\Lib\AllianceActionManagerInterface;
use Stu\Orm\Entity\UserInterface;
use Stu\Orm\Repository\AllianceJobRepositoryInterface;
use Stu\Orm\Repository\UserRepositoryInterface;

final class AllianceDeletionHandler implements PlayerDeletionHandlerInterface
{
    public function __construct(private AllianceJobRepositoryInterface $allianceJobRepository, private AllianceActionManagerInterface $allianceActionManager, private UserRepositoryInterface $userRepository) {}

    #[Override]
    public function delete(UserInterface $user): void
    {
        foreach ($this->allianceJobRepository->getByUser($user->getId()) as $job) {
            if ($job->getType() === AllianceEnum::ALLIANCE_JOBS_FOUNDER) {

                $alliance = $job->getAlliance();
                $successor = $alliance->getSuccessor();
                $diplomatic = $alliance->getDiplomatic();

                $members = $alliance->getMembers();
                $members->removeElement($user);
                $user->setAlliance(null);
                $this->userRepository->save($user);

                $lastonlinemember = $this->getLastOnlineMember($members);

Are you sure the assignment to $lastonlinemember is correct as $this->getLastOnlineMember($members) targeting Stu\Component\Player\Deletion\Handler\AllianceDeletionHandler::getLastOnlineMember() seems to always return null.

                if ($successor === null && $lastonlinemember === null) {
                    $this->allianceJobRepository->delete($job);
                    $this->allianceActionManager->delete($alliance);
                }
                if ($successor !== null) {
                    $successorUserId = $successor->getUserId();

                    $this->allianceActionManager->setJobForUser(
                        $alliance->getId(),
                        $successorUserId,
                        AllianceEnum::ALLIANCE_JOBS_FOUNDER
                    );
                    $this->allianceJobRepository->delete($successor);
                }
                if ($successor == null && $lastonlinemember != null) {
                    if ($diplomatic !== null && $lastonlinemember == $diplomatic->getUser()) {
                        $this->allianceJobRepository->delete($diplomatic);
                    }
                    $this->allianceActionManager->setJobForUser(
                        $alliance->getId(),
                        $lastonlinemember->getId(),
                        AllianceEnum::ALLIANCE_JOBS_FOUNDER
                    );
                }
            } else {
                $this->allianceJobRepository->delete($job);
            }
        }
    }

    /**
     * @param Collection<int, UserInterface> $members
     */
    private function getLastOnlineMember(Collection $members): ?UserInterface
    {
        $lastOnlineMember = null;
        $maxLastAction = 0;

        foreach ($members as $member) {
            if ($member->getLastAction() > $maxLastAction) {
                $maxLastAction = $member->getLastAction();
                $lastOnlineMember = $member;
            }
        }

        return $lastOnlineMember;
    }
}