ShipAttacker::isShieldPenetration() - Code Metrics - Inspection of "init shield penetration on existing ships" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 25c3eb...86a4f2 )

by Nico

created 2024-07-03 06:31 UTC

ShipAttacker::isShieldPenetration() A

↳ Parent: ShipAttacker

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	8
ccs	0
cts	5
cp	0
crap	6
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Module\Ship\Lib\Battle\Provider;

use RuntimeException;
use Stu\Component\Ship\System\ShipSystemTypeEnum;
use Stu\Module\Control\StuRandom;
use Stu\Module\Ship\Lib\ShipWrapperInterface;
use Stu\Module\Ship\Lib\Torpedo\ShipTorpedoManagerInterface;
use Stu\Orm\Entity\ModuleInterface;
use Stu\Orm\Entity\ShipInterface;
use Stu\Orm\Entity\TorpedoTypeInterface;
use Stu\Orm\Entity\UserInterface;

class ShipAttacker extends AbstractEnergyAttacker implements ProjectileAttackerInterface
{
    public function __construct(
        private ShipWrapperInterface $wrapper,
        private ShipTorpedoManagerInterface $shipTorpedoManager,
        private StuRandom $stuRandom
    ) {
    }

    public function getPhaserVolleys(): int
    {
        return $this->get()->getRump()->getPhaserVolleys();
    }

    public function getPhaserState(): bool
    {
        return $this->get()->getPhaserState();
    }

    public function hasSufficientEnergy(int $amount): bool
    {
        $epsSystemData = $this->wrapper->getEpsSystemData();
        if ($epsSystemData === null) {
            return false;
        }
        return $epsSystemData->getEps() >= $amount;
    }

    public function getWeaponModule(): ModuleInterface
    {
        if ($this->module === null) {
            $shipSystem = $this->get()->getShipSystem(ShipSystemTypeEnum::SYSTEM_PHASER);

            $module = $shipSystem->getModule();
            if ($module === null) {
                throw new RuntimeException('weapon system should have a module');
            }

            $this->module = $module;
        }

        return $this->module;

    }

    public function getEnergyWeaponBaseDamage(): int
    {
        return $this->get()->getBaseDamage();
    }

    public function reduceEps(int $amount): void
    {
        $epsSystemData = $this->wrapper->getEpsSystemData();
        if ($epsSystemData === null) {
            return;
        }
        $epsSystemData->lowerEps($amount)->update();
    }

    public function getName(): string
    {
        return $this->get()->getName();
    }

    public function getUser(): UserInterface
    {
        return $this->get()->getUser();
    }

    private function get(): ShipInterface
    {
        return $this->wrapper->get();
    }

    public function getHitChance(): int
    {
        return $this->get()->getHitChance();
    }

    public function getPhaserShieldDamageFactor(): int
    {
        return $this->get()->getRump()->getPhaserShieldDamageFactor();
    }

    public function getPhaserHullDamageFactor(): int
    {
        return $this->get()->getRump()->getPhaserHullDamageFactor();
    }

    public function getTorpedoVolleys(): int
    {
        return $this->get()->getRump()->getTorpedoVolleys();
    }

    public function getTorpedoState(): bool
    {
        return $this->get()->getTorpedoState();
    }

    public function getTorpedoCount(): int
    {
        return $this->get()->getTorpedoCount();
    }

    public function getTorpedo(): ?TorpedoTypeInterface
    {
        return $this->get()->getTorpedo();
    }

    public function lowerTorpedoCount(int $amount): void
    {
        $this->shipTorpedoManager->changeTorpedo($this->wrapper, -$amount);
    }

    public function isShieldPenetration(): bool
    {
        $systemData = $this->wrapper->getProjectileLauncherSystemData();
        if ($systemData === null) {
            throw new RuntimeException('this should not happen');
        }

        return $this->stuRandom->rand(1, 10000) <= $systemData->getShieldPenetration();
    }

    public function getProjectileWeaponDamage(bool $isCritical): int
    {
        $torpedo = $this->getTorpedo();
        if ($torpedo === null) {
            return 0;
        }

        $module = $this->get()->getShipSystem(ShipSystemTypeEnum::SYSTEM_TORPEDO)->getModule();
        if ($module === null) {
            return 0;
        }

        $variance = (int) round($torpedo->getBaseDamage() / 100 * $torpedo->getVariance());
        $basedamage = $torpedo->getBaseDamage();
        $damage = random_int($basedamage - $variance, $basedamage + $variance);

        return $isCritical ? $damage * 2 : $damage;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Module\Ship\Lib\Battle\Provider;
6
7		use RuntimeException;
8		use Stu\Component\Ship\System\ShipSystemTypeEnum;
9		use Stu\Module\Control\StuRandom;
10		use Stu\Module\Ship\Lib\ShipWrapperInterface;
11		use Stu\Module\Ship\Lib\Torpedo\ShipTorpedoManagerInterface;
12		use Stu\Orm\Entity\ModuleInterface;
13		use Stu\Orm\Entity\ShipInterface;
14		use Stu\Orm\Entity\TorpedoTypeInterface;
15		use Stu\Orm\Entity\UserInterface;
16
17		class ShipAttacker extends AbstractEnergyAttacker implements ProjectileAttackerInterface
18		{
19	24	public function __construct(
20		private ShipWrapperInterface $wrapper,
21		private ShipTorpedoManagerInterface $shipTorpedoManager,
22		private StuRandom $stuRandom
23		) {
24	24	}
25
26	1	public function getPhaserVolleys(): int
27		{
28	1	return $this->get()->getRump()->getPhaserVolleys();
29		}
30
31	1	public function getPhaserState(): bool
32		{
33	1	return $this->get()->getPhaserState();
34		}
35
36	3	public function hasSufficientEnergy(int $amount): bool
37		{
38	3	$epsSystemData = $this->wrapper->getEpsSystemData();
39	3	if ($epsSystemData === null) {
40	1	return false;
41		}
42	2	return $epsSystemData->getEps() >= $amount;
43		}
44
45	2	public function getWeaponModule(): ModuleInterface
46		{
47	2	if ($this->module === null) {
48	2	$shipSystem = $this->get()->getShipSystem(ShipSystemTypeEnum::SYSTEM_PHASER);
49
50	2	$module = $shipSystem->getModule();
51	2	if ($module === null) {
52	1	throw new RuntimeException('weapon system should have a module');
53		}
54
55	1	$this->module = $module;
56		}
57
58	1	return $this->module;
		0 ignored issues – show Bug Best Practice introduced 2023-11-28 21:50 UTC by Report Bug Copy Issue Report The expression `return $this->module` could return the type `null` which is incompatible with the type-hinted return `Stu\Orm\Entity\ModuleInterface`. Consider adding an additional type-check to rule them out. Loading history...
59		}
60
61	1	public function getEnergyWeaponBaseDamage(): int
62		{
63	1	return $this->get()->getBaseDamage();
64		}
65
66	2	public function reduceEps(int $amount): void
67		{
68	2	$epsSystemData = $this->wrapper->getEpsSystemData();
69	2	if ($epsSystemData === null) {
70	1	return;
71		}
72	1	$epsSystemData->lowerEps($amount)->update();
73		}
74
75	1	public function getName(): string
76		{
77	1	return $this->get()->getName();
78		}
79
80	1	public function getUser(): UserInterface
81		{
82	1	return $this->get()->getUser();
83		}
84
85	17	private function get(): ShipInterface
86		{
87	17	return $this->wrapper->get();
88		}
89
90	1	public function getHitChance(): int
91		{
92	1	return $this->get()->getHitChance();
93		}
94
95	1	public function getPhaserShieldDamageFactor(): int
96		{
97	1	return $this->get()->getRump()->getPhaserShieldDamageFactor();
98		}
99
100	1	public function getPhaserHullDamageFactor(): int
101		{
102	1	return $this->get()->getRump()->getPhaserHullDamageFactor();
103		}
104
105	1	public function getTorpedoVolleys(): int
106		{
107	1	return $this->get()->getRump()->getTorpedoVolleys();
108		}
109
110	1	public function getTorpedoState(): bool
111		{
112	1	return $this->get()->getTorpedoState();
113		}
114
115	1	public function getTorpedoCount(): int
116		{
117	1	return $this->get()->getTorpedoCount();
118		}
119
120	4	public function getTorpedo(): ?TorpedoTypeInterface
121		{
122	4	return $this->get()->getTorpedo();
123		}
124
125	1	public function lowerTorpedoCount(int $amount): void
126		{
127	1	$this->shipTorpedoManager->changeTorpedo($this->wrapper, -$amount);
128		}
129
130		public function isShieldPenetration(): bool
131		{
132		$systemData = $this->wrapper->getProjectileLauncherSystemData();
133		if ($systemData === null) {
134		throw new RuntimeException('this should not happen');
135		}
136
137		return $this->stuRandom->rand(1, 10000) <= $systemData->getShieldPenetration();
138		}
139
140	3	public function getProjectileWeaponDamage(bool $isCritical): int
141		{
142	3	$torpedo = $this->getTorpedo();
143	3	if ($torpedo === null) {
144	1	return 0;
145		}
146
147	2	$module = $this->get()->getShipSystem(ShipSystemTypeEnum::SYSTEM_TORPEDO)->getModule();
148	2	if ($module === null) {
149	1	return 0;
150		}
151
152	1	$variance = (int) round($torpedo->getBaseDamage() / 100 * $torpedo->getVariance());
153	1	$basedamage = $torpedo->getBaseDamage();
154	1	$damage = random_int($basedamage - $variance, $basedamage + $variance);
155
156	1	return $isCritical ? $damage * 2 : $damage;
157		}
158		}
159

st-universe / core

Push — master ( 25c3eb...86a4f2 )

ShipAttacker::isShieldPenetration() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like