Stu\Module\Spacecraft\Lib\Battle\Provider\AbstractEnergyAttacker

Complexity

Total Complexity

6

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getFiringMode()	0	6	1
A	getWeapon()	0	13	3
A	getWeaponDamage()	0	8	2

<?php

declare(strict_types=1);

namespace Stu\Module\Spacecraft\Lib\Battle\Provider;

use Override;

The type Override was not found. Maybe you did not declare it correctly or list all dependencies?

use RuntimeException;
use Stu\Orm\Entity\ModuleInterface;
use Stu\Orm\Entity\WeaponInterface;

abstract class AbstractEnergyAttacker implements EnergyAttackerInterface
{
    protected ?ModuleInterface $module = null;
    private ?WeaponInterface $weapon = null;

    #[Override]
    public function getFiringMode(): int
    {
        $weapon = $this->getWeapon();

        return $weapon->getFiringMode();
    }

    abstract public function getWeaponModule(): ModuleInterface;

    #[Override]
    public function getWeapon(): WeaponInterface
    {
        if ($this->weapon === null) {
            $weapon = $this->getWeaponModule()->getWeapon();
            if ($weapon === null) {
                throw new RuntimeException('module system should have a weapon');
            }

            $this->weapon = $weapon;
        }

        return $this->weapon;

The expression return $this->weapon could return the type null which is incompatible with the type-hinted return Stu\Orm\Entity\WeaponInterface. Consider adding an additional type-check to rule them out.

    }

    abstract public function getEnergyWeaponBaseDamage(): int;

    #[Override]
    public function getWeaponDamage(bool $isCritical): int
    {
        $basedamage = $this->getEnergyWeaponBaseDamage();
        $variance = (int) round($basedamage / 100 * $this->getWeapon()->getVariance());
        $damage = random_int($basedamage - $variance, $basedamage + $variance);

        return $isCritical ? $damage * 2 : $damage;
    }
}