AlertStateManager::setAlertGreen() - Code Metrics - Inspection of "Update actions/checkout action to v5" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8cd431...bc71f5 )

by Janko

created 2025-08-13 06:04 UTC

AlertStateManager::setAlertGreen() A

↳ Parent: AlertStateManager

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
nc	3
nop	1
dl	0
loc	11
ccs	9
cts	9
cp	1
crap	3
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Component\Spacecraft\System\Control;

use BadMethodCallException;
use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Component\Spacecraft\SpacecraftAlertStateEnum;
use Stu\Component\Spacecraft\System\Exception\InsufficientEnergyException;
use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Module\Control\GameControllerInterface;
use Stu\Module\Spacecraft\Lib\SpacecraftLoaderInterface;
use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
use Stu\Orm\Repository\SpacecraftRepositoryInterface;

final class AlertStateManager implements AlertStateManagerInterface
{
    use GetTargetWrapperTrait;

    /** @param SpacecraftLoaderInterface<SpacecraftWrapperInterface> $spacecraftLoader*/
    public function __construct(
        private readonly SpacecraftLoaderInterface $spacecraftLoader,
        private readonly SpacecraftRepositoryInterface $spacecraftRepository,
        private readonly SystemActivation $systemActivation,
        private readonly SystemDeactivation $systemDeactivation,
        private readonly GameControllerInterface $game
    ) {}

    #[Override]
    public function setAlertState(
        SpacecraftWrapperInterface|int $target,
        SpacecraftAlertStateEnum $alertState
    ): void {
        $wrapper = $this->getTargetWrapper(
            $target,
            false,
            $this->spacecraftLoader,
            $this->game
        );

        if (!$this->setAlertStateShip($wrapper, $alertState)) {
            return;
        }

        if ($alertState === SpacecraftAlertStateEnum::ALERT_RED) {
            $this->game->getInfo()->addInformation("Die Alarmstufe wurde auf [b][color=red]Rot[/color][/b] geändert");
        } elseif ($alertState === SpacecraftAlertStateEnum::ALERT_YELLOW) {
            $this->game->getInfo()->addInformation("Die Alarmstufe wurde auf [b][color=yellow]Gelb[/color][/b] geändert");
        } elseif ($alertState === SpacecraftAlertStateEnum::ALERT_GREEN) {
            $this->game->getInfo()->addInformation("Die Alarmstufe wurde auf [b][color=green]Grün[/color][/b] geändert");
        }
    }

    #[Override]
    public function setAlertStateFleet(
        int $shipId,
        SpacecraftAlertStateEnum $alertState
    ): void {
        $userId = $this->game->getUser()->getId();

        $wrapper = $this->spacecraftLoader->getWrapperByIdAndUser(
            $shipId,
            $userId
        );

        $fleetWrapper = $wrapper->getFleetWrapper();
        if ($fleetWrapper === null) {
            throw new BadMethodCallException('ship not in fleet');
        }

        $success = false;
        foreach ($fleetWrapper->getShipWrappers() as $wrapper) {
            $success = $this->setAlertStateShip($wrapper, $alertState) || $success;
        }

        // only show info if at least one ship was able to change
        if (!$success) {
            return;
        }

        if ($alertState === SpacecraftAlertStateEnum::ALERT_RED) {
            $this->game->getInfo()->addInformation(_('Flottenbefehl ausgeführt: Alarmstufe [b][color=red]Rot[/color][/b]'));
        } elseif ($alertState === SpacecraftAlertStateEnum::ALERT_YELLOW) {
            $this->game->getInfo()->addInformation(_('Flottenbefehl ausgeführt: Alarmstufe [b][color=yellow]Gelb[/color][/b]'));
        } elseif ($alertState === SpacecraftAlertStateEnum::ALERT_GREEN) {
            $this->game->getInfo()->addInformation(_('Flottenbefehl ausgeführt: Alarmstufe [b][color=green]Grün[/color][/b]'));
        }
    }

    private function setAlertStateShip(SpacecraftWrapperInterface $wrapper, SpacecraftAlertStateEnum $alertState): bool
    {
        $ship = $wrapper->get();

        // station constructions can't change alert state
        if ($ship->isConstruction()) {
            $this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Konstrukte können die Alarmstufe nicht ändern[/color][/b]', $ship->getName());
            return false;
        }

        // can only change when there is enough crew
        if (!$ship->hasEnoughCrew()) {
            $this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Mangel an Crew verhindert den Wechsel der Alarmstufe[/color][/b]', $ship->getName());
            return false;
        }

        if ($alertState === SpacecraftAlertStateEnum::ALERT_RED && $ship->isCloaked()) {
            $this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Tarnung verhindert den Wechsel zu Alarm-Rot[/color][/b]', $ship->getName());
            return false;
        }

        try {
            $alertMsg = $wrapper->setAlertState($alertState);
            $this->spacecraftRepository->save($ship);

            if ($alertMsg !== null) {
                $this->game->getInfo()->addInformationf('%s: [b][color=FAFA03]%s[/color][/b]', $ship->getName(), $alertMsg);
            }
        } catch (InsufficientEnergyException $e) {
            $this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Nicht genügend Energie um die Alarmstufe zu wechseln (%d benötigt)[/color][/b]', $ship->getName(), $e->getNeededEnergy());
            return false;
        }

        match ($alertState) {
            SpacecraftAlertStateEnum::ALERT_RED =>
            $this->setAlertRed($wrapper),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            SpacecraftAlertStateEnum::ALERT_YELLOW =>
            $this->setAlertYellow($wrapper),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            SpacecraftAlertStateEnum::ALERT_GREEN =>
            $this->setAlertGreen($wrapper)
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        };

        $this->spacecraftRepository->save($ship);

        return true;
    }

    private function setAlertRed(SpacecraftWrapperInterface $wrapper): void
    {
        $alertSystems = [
            SpacecraftSystemTypeEnum::SHIELDS,
            SpacecraftSystemTypeEnum::NBS,
            SpacecraftSystemTypeEnum::PHASER,
            SpacecraftSystemTypeEnum::TORPEDO
        ];

        foreach ($alertSystems as $type) {
            $this->systemActivation->activateIntern($wrapper, $type, $this->game->getInfo(), false);
        }
    }

    private function setAlertYellow(SpacecraftWrapperInterface $wrapper): void
    {
        $alertSystems = [
            SpacecraftSystemTypeEnum::NBS
        ];

        foreach ($alertSystems as $type) {
            $this->systemActivation->activateIntern($wrapper, $type, $this->game->getInfo(), false);
        }
    }

    private function setAlertGreen(SpacecraftWrapperInterface $wrapper): void
    {
        $deactivateSystems = [
            SpacecraftSystemTypeEnum::PHASER,
            SpacecraftSystemTypeEnum::TORPEDO,
            SpacecraftSystemTypeEnum::SHIELDS
        ];

        foreach ($deactivateSystems as $type) {
            if ($wrapper->get()->hasSpacecraftSystem($type)) {
                $this->systemDeactivation->deactivateIntern($wrapper, $type, $this->game->getInfo());
            }
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Component\Spacecraft\System\Control;
6
7		use BadMethodCallException;
8		use Override;
		0 ignored issues – show Bug introduced 2024-12-14 23:56 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9		use Stu\Component\Spacecraft\SpacecraftAlertStateEnum;
10		use Stu\Component\Spacecraft\System\Exception\InsufficientEnergyException;
11		use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
12		use Stu\Module\Control\GameControllerInterface;
13		use Stu\Module\Spacecraft\Lib\SpacecraftLoaderInterface;
14		use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
15		use Stu\Orm\Repository\SpacecraftRepositoryInterface;
16
17		final class AlertStateManager implements AlertStateManagerInterface
18		{
19		use GetTargetWrapperTrait;
20
21		/** @param SpacecraftLoaderInterface<SpacecraftWrapperInterface> $spacecraftLoader*/
22	4	public function __construct(
23		private readonly SpacecraftLoaderInterface $spacecraftLoader,
24		private readonly SpacecraftRepositoryInterface $spacecraftRepository,
25		private readonly SystemActivation $systemActivation,
26		private readonly SystemDeactivation $systemDeactivation,
27		private readonly GameControllerInterface $game
28	4	) {}
29
30	3	#[Override]
31		public function setAlertState(
32		SpacecraftWrapperInterface\|int $target,
33		SpacecraftAlertStateEnum $alertState
34		): void {
35	3	$wrapper = $this->getTargetWrapper(
36	3	$target,
37	3	false,
38	3	$this->spacecraftLoader,
39	3	$this->game
40	3	);
41
42	3	if (!$this->setAlertStateShip($wrapper, $alertState)) {
43		return;
44		}
45
46	3	if ($alertState === SpacecraftAlertStateEnum::ALERT_RED) {
47	1	$this->game->getInfo()->addInformation("Die Alarmstufe wurde auf [b][color=red]Rot[/color][/b] geändert");
48	2	} elseif ($alertState === SpacecraftAlertStateEnum::ALERT_YELLOW) {
49	1	$this->game->getInfo()->addInformation("Die Alarmstufe wurde auf [b][color=yellow]Gelb[/color][/b] geändert");
50	1	} elseif ($alertState === SpacecraftAlertStateEnum::ALERT_GREEN) {
51	1	$this->game->getInfo()->addInformation("Die Alarmstufe wurde auf [b][color=green]Grün[/color][/b] geändert");
52		}
53		}
54
55		#[Override]
56		public function setAlertStateFleet(
57		int $shipId,
58		SpacecraftAlertStateEnum $alertState
59		): void {
60		$userId = $this->game->getUser()->getId();
61
62		$wrapper = $this->spacecraftLoader->getWrapperByIdAndUser(
63		$shipId,
64		$userId
65		);
66
67		$fleetWrapper = $wrapper->getFleetWrapper();
68		if ($fleetWrapper === null) {
69		throw new BadMethodCallException('ship not in fleet');
70		}
71
72		$success = false;
73		foreach ($fleetWrapper->getShipWrappers() as $wrapper) {
74		$success = $this->setAlertStateShip($wrapper, $alertState) \|\| $success;
75		}
76
77		// only show info if at least one ship was able to change
78		if (!$success) {
79		return;
80		}
81
82		if ($alertState === SpacecraftAlertStateEnum::ALERT_RED) {
83		$this->game->getInfo()->addInformation(_('Flottenbefehl ausgeführt: Alarmstufe [b][color=red]Rot[/color][/b]'));
84		} elseif ($alertState === SpacecraftAlertStateEnum::ALERT_YELLOW) {
85		$this->game->getInfo()->addInformation(_('Flottenbefehl ausgeführt: Alarmstufe [b][color=yellow]Gelb[/color][/b]'));
86		} elseif ($alertState === SpacecraftAlertStateEnum::ALERT_GREEN) {
87		$this->game->getInfo()->addInformation(_('Flottenbefehl ausgeführt: Alarmstufe [b][color=green]Grün[/color][/b]'));
88		}
89		}
90
91	3	private function setAlertStateShip(SpacecraftWrapperInterface $wrapper, SpacecraftAlertStateEnum $alertState): bool
92		{
93	3	$ship = $wrapper->get();
94
95		// station constructions can't change alert state
96	3	if ($ship->isConstruction()) {
97		$this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Konstrukte können die Alarmstufe nicht ändern[/color][/b]', $ship->getName());
98		return false;
99		}
100
101		// can only change when there is enough crew
102	3	if (!$ship->hasEnoughCrew()) {
103		$this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Mangel an Crew verhindert den Wechsel der Alarmstufe[/color][/b]', $ship->getName());
104		return false;
105		}
106
107	3	if ($alertState === SpacecraftAlertStateEnum::ALERT_RED && $ship->isCloaked()) {
108		$this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Tarnung verhindert den Wechsel zu Alarm-Rot[/color][/b]', $ship->getName());
109		return false;
110		}
111
112		try {
113	3	$alertMsg = $wrapper->setAlertState($alertState);
114	3	$this->spacecraftRepository->save($ship);
115
116	3	if ($alertMsg !== null) {
117	3	$this->game->getInfo()->addInformationf('%s: [b][color=FAFA03]%s[/color][/b]', $ship->getName(), $alertMsg);
118		}
119		} catch (InsufficientEnergyException $e) {
120		$this->game->getInfo()->addInformationf('%s: [b][color=#ff2626]Nicht genügend Energie um die Alarmstufe zu wechseln (%d benötigt)[/color][/b]', $ship->getName(), $e->getNeededEnergy());
121		return false;
122		}
123
124	3	match ($alertState) {
125	3	SpacecraftAlertStateEnum::ALERT_RED =>
126	1	$this->setAlertRed($wrapper),
		0 ignored issues – show Bug introduced 2025-08-03 11:15 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->setAlertRed($wrapper)` targeting `Stu\Component\Spacecraft...eManager::setAlertRed()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
127	3	SpacecraftAlertStateEnum::ALERT_YELLOW =>
128	1	$this->setAlertYellow($wrapper),
		0 ignored issues – show Bug introduced 2025-08-03 11:15 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->setAlertYellow($wrapper)` targeting `Stu\Component\Spacecraft...nager::setAlertYellow()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
129	3	SpacecraftAlertStateEnum::ALERT_GREEN =>
130	1	$this->setAlertGreen($wrapper)
		0 ignored issues – show Bug introduced 2025-08-03 11:15 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->setAlertGreen($wrapper)` targeting `Stu\Component\Spacecraft...anager::setAlertGreen()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
131	3	};
132
133	3	$this->spacecraftRepository->save($ship);
134
135	3	return true;
136		}
137
138	1	private function setAlertRed(SpacecraftWrapperInterface $wrapper): void
139		{
140	1	$alertSystems = [
141	1	SpacecraftSystemTypeEnum::SHIELDS,
142	1	SpacecraftSystemTypeEnum::NBS,
143	1	SpacecraftSystemTypeEnum::PHASER,
144	1	SpacecraftSystemTypeEnum::TORPEDO
145	1	];
146
147	1	foreach ($alertSystems as $type) {
148	1	$this->systemActivation->activateIntern($wrapper, $type, $this->game->getInfo(), false);
149		}
150		}
151
152	1	private function setAlertYellow(SpacecraftWrapperInterface $wrapper): void
153		{
154	1	$alertSystems = [
155	1	SpacecraftSystemTypeEnum::NBS
156	1	];
157
158	1	foreach ($alertSystems as $type) {
159	1	$this->systemActivation->activateIntern($wrapper, $type, $this->game->getInfo(), false);
160		}
161		}
162
163	1	private function setAlertGreen(SpacecraftWrapperInterface $wrapper): void
164		{
165	1	$deactivateSystems = [
166	1	SpacecraftSystemTypeEnum::PHASER,
167	1	SpacecraftSystemTypeEnum::TORPEDO,
168	1	SpacecraftSystemTypeEnum::SHIELDS
169	1	];
170
171	1	foreach ($deactivateSystems as $type) {
172	1	if ($wrapper->get()->hasSpacecraftSystem($type)) {
173	1	$this->systemDeactivation->deactivateIntern($wrapper, $type, $this->game->getInfo());
174		}
175		}
176		}
177		}
178

st-universe / core

Push — master ( 8cd431...bc71f5 )

AlertStateManager::setAlertGreen() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like