AchievementManager::checkDatabaseItem() - Code Metrics - Inspection of "Dev" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2234)

by Janko

created 2025-08-11 10:27 UTC

AchievementManager::checkDatabaseItem() A

↳ Parent: AchievementManager

Complexity

Conditions	5
Paths	4

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	12
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	18
ccs	11
cts	11
cp	1
crap	5
rs	9.5555

<?php

declare(strict_types=1);

namespace Stu\Component\Database;

use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Module\Database\Lib\CreateDatabaseEntryInterface;
use Stu\Orm\Entity\User;
use Stu\Orm\Repository\DatabaseUserRepositoryInterface;

class AchievementManager implements AchievementManagerInterface
{
    /** @var array<string> */
    private static array $achievements = [];

    public function __construct(
        private readonly DatabaseUserRepositoryInterface $databaseUserRepository,
        private readonly CreateDatabaseEntryInterface $createDatabaseEntry
    ) {}

    #[Override]
    public function getAchievements(): array
    {
        return self::$achievements;
    }

    #[Override]
    public function checkDatabaseItem(?int $databaseEntryId, User $user): void
    {
        if (
            $databaseEntryId === null
            || $databaseEntryId < 1
        ) {
            return;
        }

        if (!$this->databaseUserRepository->exists($user->getId(), $databaseEntryId)) {
            $entry = $this->createDatabaseEntry->createDatabaseEntryForUser($user, $databaseEntryId);

            if ($entry !== null) {
                self::$achievements[] = sprintf(
                    'Neuer Datenbankeintrag: %s (+%d Punkte)',
                    $entry->getDescription(),
                    $entry->getCategory()->getPoints()
                );
            }
        }
    }

    #[Override]
    public static function reset(): void
    {
        self::$achievements = [];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Component\Database;
6
7		use Override;
		0 ignored issues – show Bug introduced 2025-08-05 19:03 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8		use Stu\Module\Database\Lib\CreateDatabaseEntryInterface;
9		use Stu\Orm\Entity\User;
10		use Stu\Orm\Repository\DatabaseUserRepositoryInterface;
11
12		class AchievementManager implements AchievementManagerInterface
13		{
14		/** @var array<string> */
15		private static array $achievements = [];
16
17	7	public function __construct(
18		private readonly DatabaseUserRepositoryInterface $databaseUserRepository,
19		private readonly CreateDatabaseEntryInterface $createDatabaseEntry
20	7	) {}
21
22	211	#[Override]
23		public function getAchievements(): array
24		{
25	211	return self::$achievements;
26		}
27
28	7	#[Override]
29		public function checkDatabaseItem(?int $databaseEntryId, User $user): void
30		{
31		if (
32	7	$databaseEntryId === null
33	7	\|\| $databaseEntryId < 1
34		) {
35	4	return;
36		}
37
38	3	if (!$this->databaseUserRepository->exists($user->getId(), $databaseEntryId)) {
39	1	$entry = $this->createDatabaseEntry->createDatabaseEntryForUser($user, $databaseEntryId);
40
41	1	if ($entry !== null) {
42	1	self::$achievements[] = sprintf(
43	1	'Neuer Datenbankeintrag: %s (+%d Punkte)',
44	1	$entry->getDescription(),
45	1	$entry->getCategory()->getPoints()
46	1	);
47		}
48		}
49		}
50
51	222	#[Override]
52		public static function reset(): void
53		{
54	222	self::$achievements = [];
55		}
56		}
57

st-universe / core

Pull Request — master (#2234)

AchievementManager::checkDatabaseItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like