Stu\Module\Crew\Lib\CrewCreator

Complexity

Total Complexity

20

Size/Duplication

Total Lines	138
Duplicated Lines	0 %

Test Coverage

Coverage

2.53%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	create()	0	45	5
A	getCrewByType()	0	15	3
B	createCrewAssignment()	0	46	9
A	getCrew()	0	14	2

<?php

declare(strict_types=1);

namespace Stu\Module\Crew\Lib;

use Override;

The type Override was not found. Maybe you did not declare it correctly or list all dependencies?

use RuntimeException;
use Stu\Component\Crew\CrewEnum;

The type Stu\Component\Crew\CrewEnum was not found. Maybe you did not declare it correctly or list all dependencies?

use Stu\Component\Crew\CrewOriginException;
use Stu\Orm\Entity\ColonyInterface;
use Stu\Orm\Entity\CrewAssignmentInterface;
use Stu\Orm\Entity\SpacecraftInterface;
use Stu\Orm\Repository\CrewRaceRepositoryInterface;
use Stu\Orm\Repository\CrewRepositoryInterface;
use Stu\Orm\Repository\CrewAssignmentRepositoryInterface;
use Stu\Orm\Repository\ShipRumpCategoryRoleCrewRepositoryInterface;
use Stu\Orm\Repository\UserRepositoryInterface;

final class CrewCreator implements CrewCreatorInterface
{
    public function __construct(
        private CrewRaceRepositoryInterface $crewRaceRepository,
        private ShipRumpCategoryRoleCrewRepositoryInterface $shipRumpCategoryRoleCrewRepository,
        private CrewAssignmentRepositoryInterface $shipCrewRepository,
        private CrewRepositoryInterface $crewRepository,
        private UserRepositoryInterface $userRepository
    ) {}

    #[Override]
    public function create(int $userId, ?ColonyInterface $colony = null): CrewAssignmentInterface
    {
        $user = $this->userRepository->find($userId);

        if ($user === null) {
            throw new RuntimeException('user not found1');
        }

        $arr = [];
        $raceList = $this->crewRaceRepository->getByFaction((int)$user->getFactionId());
        foreach ($raceList as $obj) {
            $min = key($arr) + 1;
            $amount = range($min, $min + $obj->getChance());
            array_walk(
                $amount,
                function (&$value) use ($obj): void {
                    $value = $obj->getId();
                }
            );
            $arr = [...$arr, ...$amount];
        }
        $race = $this->crewRaceRepository->find($arr[array_rand($arr)]);

        $gender = random_int(1, 100) > $race->getMaleRatio() ? CrewEnum::CREW_GENDER_FEMALE : CrewEnum::CREW_GENDER_MALE;

        $crew = $this->crewRepository->prototype();

        $crew->setUser($user);
        $crew->setName('Crew');
        $crew->setRace($race);

It seems like $race can also be of type null; however, parameter $crewRace of Stu\Orm\Entity\CrewInterface::setRace() does only seem to accept Stu\Orm\Entity\CrewRaceInterface, maybe add an additional type check?

        $crew->setGender($gender);
        $crew->setType(CrewEnum::CREW_TYPE_CREWMAN);
        $this->crewRepository->save($crew);

        $crewAssignment = $this->shipCrewRepository->prototype();
        $crewAssignment->setUser($user);
        $crewAssignment->setCrew($crew);
        if ($colony !== null) {
            $crewAssignment->setColony($colony);
            $colony->getCrewAssignments()->add($crewAssignment);
        }
        $this->shipCrewRepository->save($crewAssignment);

        return $crewAssignment;
    }

    #[Override]
    public function createCrewAssignment(
        SpacecraftInterface $spacecraft,
        ColonyInterface|SpacecraftInterface $crewProvider,
        ?int $amount = null
    ): void {
        $crewToSetup = $amount ?? $spacecraft->getBuildPlan()->getCrew();

        foreach (CrewEnum::CREW_ORDER as $crewType) {
            $createdcount = 1;
            $slot = $crewType == CrewEnum::CREW_TYPE_CREWMAN ? 'getJob6Crew' : 'getJob' . $crewType . 'Crew';
            $config = $this->shipRumpCategoryRoleCrewRepository->getByShipRumpCategoryAndRole(
                $spacecraft->getRump()->getShipRumpCategory()->getId(),
                $spacecraft->getRump()->getShipRumpRole()->getId()
            );
            if ($config === null) {
                throw new RuntimeException(sprintf(
                    'no rump category role crew for rumpCategoryId: %d, rumpRoleId: %d',
                    $spacecraft->getRump()->getShipRumpCategory()->getId(),
                    $spacecraft->getRump()->getShipRumpRole()->getId()
                ));
            }

            while ($crewToSetup > 0 && ($crewType == CrewEnum::CREW_TYPE_CREWMAN || $createdcount <= $config->$slot())) {
                $createdcount++;
                $crewToSetup--;

                $crewAssignment = $this->getCrewByType($crewType, $crewProvider);

Are you sure the assignment to $crewAssignment is correct as $this->getCrewByType($crewType, $crewProvider) targeting Stu\Module\Crew\Lib\CrewCreator::getCrewByType() seems to always return null.

                if ($crewAssignment === null) {
                    $crewAssignment = $this->getCrew($crewProvider);
                }

                if ($crewAssignment === null) {
                    throw new CrewOriginException('no assignable crew found');
                }

                $crewAssignment->setSpacecraft($spacecraft);
                $crewAssignment->setColony(null);
                $crewAssignment->setTradepost(null);
                //TODO set both ship and crew user
                $crewAssignment->setUser($spacecraft->getUser());
                $crewAssignment->setSlot($crewType);

                $spacecraft->getCrewAssignments()->add($crewAssignment);

                $this->shipCrewRepository->save($crewAssignment);
            }
        }
    }

    private function getCrewByType(
        int $crewType,
        ColonyInterface|SpacecraftInterface $crewProvider
    ): ?CrewAssignmentInterface {

        foreach ($crewProvider->getCrewAssignments() as $crewAssignment) {
            $crew = $crewAssignment->getCrew();
            if ($crew->getType() === $crewType) {
                $crewProvider->getCrewAssignments()->removeElement($crewAssignment);

                return $crewAssignment;
            }
        }

        return null;
    }

    private function getCrew(ColonyInterface|SpacecraftInterface $crewProvider): ?CrewAssignmentInterface
    {
        $crewAssignments = $crewProvider->getCrewAssignments();

        if ($crewAssignments->isEmpty()) {
            return null;
        }

        /** @var CrewAssignmentInterface $random */
        $random = $crewAssignments->get(array_rand($crewAssignments->toArray()));

It seems like array_rand($crewAssignments->toArray()) can also be of type array; however, parameter $key of Doctrine\Common\Collections\ReadableCollection::get() does only seem to accept integer|string, maybe add an additional type check?

        $crewAssignments->removeElement($random);

        return $random;
    }
}