Stu\Module\Commodity\Lib\CommodityCache

Complexity

Total Complexity

6

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

83.33%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	get()	0	8	2
A	getAll()	0	12	3

<?php

declare(strict_types=1);

namespace Stu\Module\Commodity\Lib;

use Override;

The type Override was not found. Maybe you did not declare it correctly or list all dependencies?

use Stu\Orm\Entity\Commodity;
use Stu\Orm\Repository\CommodityRepositoryInterface;

final class CommodityCache implements CommodityCacheInterface
{
    /**
     * @var array<int, Commodity>|null
     */
    private ?array $commodityArray = null;

    public function __construct(private CommodityRepositoryInterface $commodityRepository)
    {
    }

    #[Override]
    public function get(int $commodityId): Commodity
    {
        if ($this->commodityArray === null) {
            $this->commodityArray = $this->commodityRepository->getAll();
        }

        return $this->commodityArray[$commodityId];
    }

    #[Override]
    public function getAll(?int $type = null): array
    {
        if ($this->commodityArray === null) {
            $this->commodityArray = $this->commodityRepository->getAll();
        }

        if ($type !== null) {
            return array_filter($this->commodityArray, fn (Commodity $commodity): bool => $commodity->getType() === $type);

It seems like $this->commodityArray can also be of type null; however, parameter $array of array_filter() does only seem to accept array, maybe add an additional type check?

        }

        return $this->commodityArray;

The expression return $this->commodityArray could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}