StuBbCodeWithImageDefinitionSet::getCodeDefinitions()

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	2

Importance

Changes

0

<?php
    #[Override]
    public function getCodeDefinitions(): array
    {
        if ($this->definitions === null) {
            $this->definitions = [
                (new CodeDefinitionBuilder('b', '<strong>{param}</strong>'))->build(),
                (new CodeDefinitionBuilder('i', '<em>{param}</em>'))->build(),
                (new CodeDefinitionBuilder('u', '<u>{param}</u>'))->build(),
                (new CodeDefinitionBuilder(
                    'color',
                    '<span style="color: {option}">{param}</span>'
                ))
                    ->setUseOption(true)
                    ->setOptionValidator(new CssColorValidator())
                    ->build(),
                (new CodeDefinitionBuilder(
                    'img',
                    '<img src="{param}" style="max-height: 100%;max-width:100%;" />'
                ))
                    ->setBodyValidator(new StuBbCodeImageValidator())
                    ->build(),
            ];
        }
        return $this->definitions;

The expression return $this->definitions could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }