FlightDirectionConsequence::triggerSpecific() - Code Metrics - Inspection of "refactor move" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 288b46...98b0e3 )

by Nico

created 2023-10-02 07:15 UTC

FlightDirectionConsequence::triggerSpecific() A

↳ Parent: FlightDirectionConsequence

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	6
c	1
b	0
f	0
nc	3
nop	3
dl	0
loc	16
ccs	7
cts	7
cp	1
crap	3
rs	10

<?php

declare(strict_types=1);

namespace Stu\Module\Ship\Lib\Movement\Component\Consequence\Flight;

use RuntimeException;
use Stu\Module\Ship\Lib\Message\MessageCollectionInterface;
use Stu\Module\Ship\Lib\Movement\Component\Consequence\AbstractFlightConsequence;
use Stu\Module\Ship\Lib\Movement\Route\FlightRouteInterface;
use Stu\Module\Ship\Lib\Movement\Route\RouteModeEnum;
use Stu\Module\Ship\Lib\Movement\Route\UpdateFlightDirectionInterface;
use Stu\Module\Ship\Lib\ShipWrapperInterface;
use Stu\Orm\Entity\StarSystemMapInterface;

class FlightDirectionConsequence extends AbstractFlightConsequence
{
    private UpdateFlightDirectionInterface $updateFlightDirection;

    public function __construct(
        UpdateFlightDirectionInterface $updateFlightDirection
    ) {
        $this->updateFlightDirection = $updateFlightDirection;
    }

    protected function triggerSpecific(
        ShipWrapperInterface $wrapper,
        FlightRouteInterface $flightRoute,
        MessageCollectionInterface $messages
    ): void {

        $ship = $wrapper->get();

        //leaving star system
        if ($flightRoute->getRouteMode() === RouteModeEnum::ROUTE_MODE_SYSTEM_EXIT) {
            $oldWaypoint = $ship->getCurrentMapField();
            if (!$oldWaypoint instanceof StarSystemMapInterface) {
                throw new RuntimeException('this should not happen');
            }

            $this->updateFlightDirection->updateWhenSystemExit($ship, $oldWaypoint);
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Module\Ship\Lib\Movement\Component\Consequence\Flight;
6
7		use RuntimeException;
8		use Stu\Module\Ship\Lib\Message\MessageCollectionInterface;
9		use Stu\Module\Ship\Lib\Movement\Component\Consequence\AbstractFlightConsequence;
10		use Stu\Module\Ship\Lib\Movement\Route\FlightRouteInterface;
11		use Stu\Module\Ship\Lib\Movement\Route\RouteModeEnum;
12		use Stu\Module\Ship\Lib\Movement\Route\UpdateFlightDirectionInterface;
13		use Stu\Module\Ship\Lib\ShipWrapperInterface;
14		use Stu\Orm\Entity\StarSystemMapInterface;
15
16		class FlightDirectionConsequence extends AbstractFlightConsequence
17		{
18		private UpdateFlightDirectionInterface $updateFlightDirection;
19
20	5	public function __construct(
21		UpdateFlightDirectionInterface $updateFlightDirection
22		) {
23	5	$this->updateFlightDirection = $updateFlightDirection;
24		}
25
26	3	protected function triggerSpecific(
27		ShipWrapperInterface $wrapper,
28		FlightRouteInterface $flightRoute,
29		MessageCollectionInterface $messages
30		): void {
31
32	3	$ship = $wrapper->get();
33
34		//leaving star system
35	3	if ($flightRoute->getRouteMode() === RouteModeEnum::ROUTE_MODE_SYSTEM_EXIT) {
36	2	$oldWaypoint = $ship->getCurrentMapField();
37	2	if (!$oldWaypoint instanceof StarSystemMapInterface) {
38	1	throw new RuntimeException('this should not happen');
39		}
40
41	1	$this->updateFlightDirection->updateWhenSystemExit($ship, $oldWaypoint);
42		}
43		}
44		}
45

st-universe / core

Push — master ( 288b46...98b0e3 )

FlightDirectionConsequence::triggerSpecific() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like