MessageCollection::getRecipientIds() - Code Metrics - Inspection of "refactor move" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 288b46...98b0e3 )

by Nico

created 2023-10-02 07:15 UTC

MessageCollection::getRecipientIds() A

↳ Parent: MessageCollection

Complexity

Conditions	6
Paths	5

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6.027

Importance

Changes

Metric	Value
cc	6
eloc	10
nc	5
nop	0
dl	0
loc	21
ccs	10
cts	11
cp	0.9091
crap	6.027
rs	9.2222
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Module\Ship\Lib\Message;

use Stu\Lib\InformationWrapper;
use Stu\Module\PlayerSetting\Lib\UserEnum;

final class MessageCollection implements MessageCollectionInterface
{
    /**
     * @var MessageInterface[]
     */
    private array $messages = [];

    public function add(MessageInterface $msg): void
    {
        $this->messages[] = $msg;
    }

    public function addMultiple(array $messages): void
    {
        foreach ($messages as $msg) {
            $this->messages[] = $msg;
        }
    }

    public function getRecipientIds(): array
    {
        $recipientIds = [];

        foreach ($this->messages as $message) {
            if ($message->isEmpty()) {
                continue;
            }

            $recipientId = $message->getRecipientId();

            if ($recipientId === null || $recipientId === UserEnum::USER_NOONE) {
                continue;
            }

            if (!in_array($recipientId, $recipientIds)) {
                $recipientIds[] = $recipientId;
            }
        }

        return $recipientIds;
    }

    public function getInformationDump(?int $userId = null): InformationWrapper
    {
        $result = new InformationWrapper();

        foreach ($this->messages as $message) {
            if ($message->isEmpty()) {
                continue;
            }

            if (
                $userId === null
                || $message->getSenderId() === $userId
                || $message->getRecipientId() === null
                || $message->getRecipientId() === $userId
            ) {
                $result->addInformationArray($message->getMessage());
            }
        }

        return $result;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Module\Ship\Lib\Message;
6
7		use Stu\Lib\InformationWrapper;
8		use Stu\Module\PlayerSetting\Lib\UserEnum;
9
10		final class MessageCollection implements MessageCollectionInterface
11		{
12		/**
13		* @var MessageInterface[]
14		*/
15		private array $messages = [];
16
17	3	public function add(MessageInterface $msg): void
18		{
19	3	$this->messages[] = $msg;
20		}
21
22	2	public function addMultiple(array $messages): void
23		{
24	2	foreach ($messages as $msg) {
25	2	$this->messages[] = $msg;
26		}
27		}
28
29	1	public function getRecipientIds(): array
30		{
31	1	$recipientIds = [];
32
33	1	foreach ($this->messages as $message) {
34	1	if ($message->isEmpty()) {
35		continue;
36		}
37
38	1	$recipientId = $message->getRecipientId();
39
40	1	if ($recipientId === null \|\| $recipientId === UserEnum::USER_NOONE) {
41	1	continue;
42		}
43
44	1	if (!in_array($recipientId, $recipientIds)) {
45	1	$recipientIds[] = $recipientId;
46		}
47		}
48
49	1	return $recipientIds;
50		}
51
52	4	public function getInformationDump(?int $userId = null): InformationWrapper
53		{
54	4	$result = new InformationWrapper();
55
56	4	foreach ($this->messages as $message) {
57	4	if ($message->isEmpty()) {
58		continue;
59		}
60
61		if (
62	4	$userId === null
63	1	\|\| $message->getSenderId() === $userId
64	1	\|\| $message->getRecipientId() === null
65	4	\|\| $message->getRecipientId() === $userId
66		) {
67	4	$result->addInformationArray($message->getMessage());
68		}
69		}
70
71	4	return $result;
72		}
73		}
74

st-universe / core

Push — master ( 288b46...98b0e3 )

MessageCollection::getRecipientIds() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like