Message::getSenderId() - Code Metrics - Inspection of "refactor move" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 288b46...98b0e3 )

by Nico

created 2023-10-02 07:15 UTC

Message::getSenderId() A

↳ Parent: Message

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Module\Ship\Lib\Message;

use Stu\Module\PlayerSetting\Lib\UserEnum;

final class Message implements MessageInterface
{
    /**
     * @var array<string>
     */
    private array $msg = [];

    private int $senderId;

    private ?int $recipientId;

    /**
     * @param array<string>|null $msg
     */
    public function __construct(
        ?int $senderId = null,
        ?int $recipientId = null,
        ?array $msg = null
    ) {
        $this->senderId = $senderId ?? UserEnum::USER_NOONE;
        $this->recipientId = $recipientId;
        if ($msg !== null) {
            $this->msg = $msg;
        }
    }

    public function getSenderId(): int
    {
        return $this->senderId;
    }

    public function getRecipientId(): ?int
    {
        return $this->recipientId;
    }

    public function getMessage(): array
    {
        return $this->msg;
    }

    public function add(?string $msg): void
    {
        if ($msg === null) {
            return;
        }

        $this->msg[] = $msg;
    }

    public function addMessageMerge(array $msg): void
    {
        if ($msg === []) {
            return;
        }

        $this->msg = array_merge($this->msg, $msg);
    }

    public function isEmpty(): bool
    {
        return empty($this->getMessage());
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Module\Ship\Lib\Message;
6
7		use Stu\Module\PlayerSetting\Lib\UserEnum;
8
9		final class Message implements MessageInterface
10		{
11		/**
12		* @var array<string>
13		*/
14		private array $msg = [];
15
16		private int $senderId;
17
18		private ?int $recipientId;
19
20		/**
21		* @param array<string>\|null $msg
22		*/
23	36	public function __construct(
24		?int $senderId = null,
25		?int $recipientId = null,
26		?array $msg = null
27		) {
28	36	$this->senderId = $senderId ?? UserEnum::USER_NOONE;
29	36	$this->recipientId = $recipientId;
30	36	if ($msg !== null) {
31	6	$this->msg = $msg;
32		}
33		}
34
35	1	public function getSenderId(): int
36		{
37	1	return $this->senderId;
38		}
39
40	12	public function getRecipientId(): ?int
41		{
42	12	return $this->recipientId;
43		}
44
45	29	public function getMessage(): array
46		{
47	29	return $this->msg;
48		}
49
50	20	public function add(?string $msg): void
51		{
52	20	if ($msg === null) {
53	2	return;
54		}
55
56	18	$this->msg[] = $msg;
57		}
58
59	6	public function addMessageMerge(array $msg): void
60		{
61	6	if ($msg === []) {
62	2	return;
63		}
64
65	4	$this->msg = array_merge($this->msg, $msg);
66		}
67
68	3	public function isEmpty(): bool
69		{
70	3	return empty($this->getMessage());
71		}
72		}
73

st-universe / core

Push — master ( 288b46...98b0e3 )

Message::getSenderId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like