LeaveStarSystem::isSanityCheckFaultyConcrete() - Code Metrics - Inspection of "refactor move" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 288b46...98b0e3 )

by Nico

created 2023-10-02 07:15 UTC

LeaveStarSystem::isSanityCheckFaultyConcrete() A

↳ Parent: LeaveStarSystem

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	8
c	0
b	0
f	0
nc	3
nop	2
dl	0
loc	16
ccs	0
cts	9
cp	0
crap	12
rs	10

<?php

declare(strict_types=1);

namespace Stu\Module\Ship\Action\LeaveStarSystem;

use RuntimeException;
use Stu\Module\Control\GameControllerInterface;
use Stu\Module\Ship\Action\MoveShip\AbstractDirectedMovement;
use Stu\Module\Ship\Lib\Movement\Route\FlightRouteInterface;
use Stu\Module\Ship\Lib\ShipWrapperInterface;

final class LeaveStarSystem extends AbstractDirectedMovement
{
    public const ACTION_IDENTIFIER = 'B_LEAVE_STARSYSTEM';

    protected function isSanityCheckFaultyConcrete(ShipWrapperInterface $wrapper, GameControllerInterface $game): bool
    {
        $ship = $wrapper->get();

        $starsystemMap = $ship->getStarsystemMap();
        if ($starsystemMap === null) {
            return true;
        }

        //the destination map field
        $outerMap = $starsystemMap->getSystem()->getMapField();
        if ($outerMap === null) {
            return true;
        }

        return false;
    }

    protected function getFlightRoute(ShipWrapperInterface $wrapper): FlightRouteInterface
    {
        $ship = $wrapper->get();

        $starsystemMap = $ship->getStarsystemMap();
        if ($starsystemMap === null) {
            throw new RuntimeException('should not happen');
        }

        //the destination map field
        $destination = $starsystemMap->getSystem()->getMapField();
        if ($destination === null) {
            throw new RuntimeException('should not happen');
        }

        return $this->flightRouteFactory->getRouteForMapDestination($destination);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stu\Module\Ship\Action\LeaveStarSystem;
6
7			use RuntimeException;
8			use Stu\Module\Control\GameControllerInterface;
9			use Stu\Module\Ship\Action\MoveShip\AbstractDirectedMovement;
10			use Stu\Module\Ship\Lib\Movement\Route\FlightRouteInterface;
11			use Stu\Module\Ship\Lib\ShipWrapperInterface;
12
13			final class LeaveStarSystem extends AbstractDirectedMovement
14			{
15			public const ACTION_IDENTIFIER = 'B_LEAVE_STARSYSTEM';
16
17			protected function isSanityCheckFaultyConcrete(ShipWrapperInterface $wrapper, GameControllerInterface $game): bool
18			{
19			$ship = $wrapper->get();
20
21			$starsystemMap = $ship->getStarsystemMap();
22			if ($starsystemMap === null) {
23			return true;
24			}
25
26			//the destination map field
27			$outerMap = $starsystemMap->getSystem()->getMapField();
28			if ($outerMap === null) {
29			return true;
30			}
31
32			return false;
33			}
34
35			protected function getFlightRoute(ShipWrapperInterface $wrapper): FlightRouteInterface
36			{
37			$ship = $wrapper->get();
38
39			$starsystemMap = $ship->getStarsystemMap();
40			if ($starsystemMap === null) {
41			throw new RuntimeException('should not happen');
42			}
43
44			//the destination map field
45			$destination = $starsystemMap->getSystem()->getMapField();
46			if ($destination === null) {
47			throw new RuntimeException('should not happen');
48			}
49
50			return $this->flightRouteFactory->getRouteForMapDestination($destination);
51			}
52			}
53

st-universe / core

Push — master ( 288b46...98b0e3 )

LeaveStarSystem::isSanityCheckFaultyConcrete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like