ModuleRumpWrapperProjectileWeapon::getSecondValue() - Code Metrics - Inspection of "introduce spacecraft corrector" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 0dbbcc...f29cfd )

by Janko

created 2025-01-03 14:50 UTC

getSecondValue() A

↳ Parent: ModuleRumpWrapperProjectileWeapon

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Lib\ModuleRumpWrapper;

use Override;
filter:
    dependency_paths: ["lib/*"]
use RuntimeException;
use Stu\Component\Spacecraft\SpacecraftModuleTypeEnum;
use Stu\Module\Spacecraft\Lib\ModuleValueCalculator;
use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
use Stu\Orm\Entity\ModuleInterface;

final class ModuleRumpWrapperProjectileWeapon extends ModuleRumpWrapperBase implements ModuleRumpWrapperInterface
{
    #[Override]
    public function getValue(?ModuleInterface $module = null): int
    {
        $module ??= current($this->getModule());
        if ($module === false) {
            return 0;
        }

        return (new ModuleValueCalculator())->calculateModuleValue(
            $this->rump,
            $module,
            200 //TODO use property of rump / rumpRole
        );
    }

    #[Override]
    public function getModuleType(): SpacecraftModuleTypeEnum
    {
        return SpacecraftModuleTypeEnum::TORPEDO;
    }

    #[Override]
    public function apply(SpacecraftWrapperInterface $wrapper): void
    {
        $systemData = $wrapper->getProjectileLauncherSystemData();
        if ($systemData === null) {
            throw new RuntimeException('this should not happen');
        }

        $systemData->setShieldPenetration($this->getValue())->update();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stu\Lib\ModuleRumpWrapper;
6
7			use Override;
			0 ignored issues – show Bug introduced 2024-07-04 06:34 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use RuntimeException;
9			use Stu\Component\Spacecraft\SpacecraftModuleTypeEnum;
10			use Stu\Module\Spacecraft\Lib\ModuleValueCalculator;
11			use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
12			use Stu\Orm\Entity\ModuleInterface;
13
14			final class ModuleRumpWrapperProjectileWeapon extends ModuleRumpWrapperBase implements ModuleRumpWrapperInterface
15			{
16			#[Override]
17			public function getValue(?ModuleInterface $module = null): int
18			{
19			$module ??= current($this->getModule());
20			if ($module === false) {
21			return 0;
22			}
23
24			return (new ModuleValueCalculator())->calculateModuleValue(
25			$this->rump,
26			$module,
27			200 //TODO use property of rump / rumpRole
28			);
29			}
30
31			#[Override]
32			public function getModuleType(): SpacecraftModuleTypeEnum
33			{
34			return SpacecraftModuleTypeEnum::TORPEDO;
35			}
36
37			#[Override]
38			public function apply(SpacecraftWrapperInterface $wrapper): void
39			{
40			$systemData = $wrapper->getProjectileLauncherSystemData();
41			if ($systemData === null) {
42			throw new RuntimeException('this should not happen');
43			}
44
45			$systemData->setShieldPenetration($this->getValue())->update();
46			}
47			}
48

st-universe / core

Push — dev ( 0dbbcc...f29cfd )

getSecondValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like