Passed
Pull Request — master (#1821)
by Nico
52:02 queued 25:23
created

ShipSystemDataFactory::createSystemData()   B

Complexity

Conditions 10
Paths 10

Size

Total Lines 33
Code Lines 25

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 110

Importance

Changes 0
Metric Value
cc 10
eloc 25
c 0
b 0
f 0
nc 10
nop 2
dl 0
loc 33
ccs 0
cts 27
cp 0
crap 110
rs 7.6666

How to fix   Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Stu\Component\Ship\System\Data;
6
7
use Stu\Component\Ship\System\Exception\InvalidSystemException;
8
use Stu\Component\Ship\System\ShipSystemTypeEnum;
9
use Stu\Module\Ship\Lib\ShipWrapperFactoryInterface;
10
use Stu\Orm\Repository\ShipRepositoryInterface;
11
use Stu\Orm\Repository\ShipSystemRepositoryInterface;
12
use Stu\Orm\Repository\TholianWebRepositoryInterface;
13
14
final class ShipSystemDataFactory implements ShipSystemDataFactoryInterface
15
{
16
17 2
    public function __construct(
18
        private ShipRepositoryInterface $shipRepository,
19
        private ShipSystemRepositoryInterface $shipSystemRepository,
20
        private TholianWebRepositoryInterface $tholianWebRepository
21
    ) {
22 2
    }
23
24
    public function createSystemData(
25
        ShipSystemTypeEnum $systemType,
26
        ShipWrapperFactoryInterface $shipWrapperFactory
27
    ): AbstractSystemData {
28
        switch ($systemType) {
29
            case ShipSystemTypeEnum::SYSTEM_HULL:
30
                return  new HullSystemData();
31
            case ShipSystemTypeEnum::SYSTEM_SHIELDS:
32
                return  new ShieldSystemData();
33
            case ShipSystemTypeEnum::SYSTEM_EPS:
34
                return  new EpsSystemData($this->shipSystemRepository);
35
            case ShipSystemTypeEnum::SYSTEM_TRACKER:
36
                return  new TrackerSystemData(
37
                    $this->shipRepository,
38
                    $this->shipSystemRepository,
39
                    $shipWrapperFactory
40
                );
41
            case ShipSystemTypeEnum::SYSTEM_THOLIAN_WEB:
42
                return  new WebEmitterSystemData(
43
                    $this->shipSystemRepository,
44
                    $this->tholianWebRepository
45
                );
46
            case ShipSystemTypeEnum::SYSTEM_WARPDRIVE:
47
                return  new WarpDriveSystemData($this->shipSystemRepository);
48
            case ShipSystemTypeEnum::SYSTEM_WARPCORE:
49
                return  new WarpCoreSystemData($this->shipSystemRepository);
50
            case ShipSystemTypeEnum::SYSTEM_SINGULARITY_REACTOR:
51
                return  new SingularityCoreSystemData($this->shipSystemRepository);
52
            case ShipSystemTypeEnum::SYSTEM_FUSION_REACTOR:
53
                return  new FusionCoreSystemData($this->shipSystemRepository);
54
        }
55
56
        throw new InvalidSystemException(sprintf('no system data present for systemType: %d', $systemType->value));
57
    }
58
}
59