PlayerRelationDeterminator::isEnemy() - Code Metrics - Inspection of "fix ticket 086" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1821)

by Nico

created 2024-06-23 09:33 UTC

PlayerRelationDeterminator::isEnemy() A

↳ Parent: PlayerRelationDeterminator

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
nc	3
nop	2
dl	0
loc	13
ccs	8
cts	8
cp	1
crap	3
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Component\Player\Relation;

use Stu\Orm\Entity\UserInterface;

/**
 * Some locations require to determine if a certain user is friendly towards the player
 */
final class PlayerRelationDeterminator implements PlayerRelationDeterminatorInterface
{
    public function __construct(
        private FriendDeterminator $friendDeterminator,
        private EnemyDeterminator $enemyDeterminator
    ) {
    }

    public function isFriend(UserInterface $user, UserInterface $otherUser): bool
    {
        $friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
        if ($friendRelation->isDominant()) {
            return true;
        }

        $enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
        if ($enemyRelation->isDominant()) {
            return false;
        }

        return $friendRelation !== PlayerRelationTypeEnum::NONE;
    }

    public function isEnemy(UserInterface $user, UserInterface $otherUser): bool
    {
        $enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
        if ($enemyRelation->isDominant()) {
            return true;
        }

        $friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
        if ($friendRelation->isDominant()) {
            return false;
        }

        return $enemyRelation !== PlayerRelationTypeEnum::NONE;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Component\Player\Relation;
6
7		use Stu\Orm\Entity\UserInterface;
8
9		/**
10		* Some locations require to determine if a certain user is friendly towards the player
11		*/
12		final class PlayerRelationDeterminator implements PlayerRelationDeterminatorInterface
13		{
14	14	public function __construct(
15		private FriendDeterminator $friendDeterminator,
16		private EnemyDeterminator $enemyDeterminator
17		) {
18	14	}
19
20	7	public function isFriend(UserInterface $user, UserInterface $otherUser): bool
21		{
22	7	$friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
23	7	if ($friendRelation->isDominant()) {
24	2	return true;
25		}
26
27	5	$enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
28	5	if ($enemyRelation->isDominant()) {
29	2	return false;
30		}
31
32	3	return $friendRelation !== PlayerRelationTypeEnum::NONE;
33		}
34
35	7	public function isEnemy(UserInterface $user, UserInterface $otherUser): bool
36		{
37	7	$enemyRelation = $this->enemyDeterminator->isEnemy($user, $otherUser);
38	7	if ($enemyRelation->isDominant()) {
39	2	return true;
40		}
41
42	5	$friendRelation = $this->friendDeterminator->isFriend($user, $otherUser);
43	5	if ($friendRelation->isDominant()) {
44	2	return false;
45		}
46
47	3	return $enemyRelation !== PlayerRelationTypeEnum::NONE;
48		}
49		}
50

st-universe / core

Pull Request — master (#1821)

PlayerRelationDeterminator::isEnemy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like