SpacecraftRepository::getSingleSpacecraftScannerResults() - Code Metrics - Inspection of "extract logic from spacecraft entity" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed
Pull Request — master (#2138)

by Nico
created 2025-06-12 19:19 UTC
getSingleSpacecraftScannerResults() B

↳ Parent: SpacecraftRepository
Complexity

Conditions	2
Paths	1
Size

Total Lines	71
Code Lines	60
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	22
CRAP Score	2.0145
Importance

Changes
Metric	Value
cc	2
eloc	60
c	0
b	0
f	0
nc	1
nop	3
dl	0
loc	71
ccs	22
cts	26
cp	0.8462
crap	2.0145
rs	8.8727
How to fix Long Method

<?php

declare(strict_types=1);

namespace Stu\Orm\Repository;

use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Query\ResultSetMapping;
use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Component\Anomaly\Type\AnomalyTypeEnum;
use Stu\Component\Spacecraft\SpacecraftStateEnum;
use Stu\Component\Spacecraft\SpacecraftTypeEnum;
use Stu\Component\Spacecraft\System\SpacecraftSystemModeEnum;
use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Module\PlayerSetting\Lib\UserEnum;
filter:
    dependency_paths: ["lib/*"]
use Stu\Module\Ship\Lib\TShipItem;
use Stu\Module\Spacecraft\Lib\ShipRumpSpecialAbilityEnum;
filter:
    dependency_paths: ["lib/*"]
use Stu\Orm\Entity\Anomaly;
use Stu\Orm\Entity\SpacecraftBuildplan;
use Stu\Orm\Entity\CrewAssignment;
use Stu\Orm\Entity\MapInterface;
use Stu\Orm\Entity\ShipRumpSpecial;
use Stu\Orm\Entity\Spacecraft;
use Stu\Orm\Entity\SpacecraftCondition;
use Stu\Orm\Entity\SpacecraftInterface;
use Stu\Orm\Entity\SpacecraftSystem;
use Stu\Orm\Entity\StarSystemMapInterface;
use Stu\Orm\Entity\User;
use Stu\Orm\Entity\UserInterface;

/**
 * @extends EntityRepository<Spacecraft>
 */
final class SpacecraftRepository extends EntityRepository implements SpacecraftRepositoryInterface
{
    #[Override]
    public function save(SpacecraftInterface $spacecraft): void
    {
        $em = $this->getEntityManager();

        $em->persist($spacecraft);
    }

    #[Override]
    public function delete(SpacecraftInterface $spacecraft): void
    {
        $em = $this->getEntityManager();

        $em->remove($spacecraft);
    }

    #[Override]
    public function getAmountByUserAndSpecialAbility(
        int $userId,
        int $specialAbilityId
    ): int {
        return (int) $this->getEntityManager()->createQuery(
            sprintf(
                'SELECT COUNT(s)
                FROM %s s
                JOIN %s bp
                WITH s.plan_id = bp.id
                WHERE s.user_id = :userId AND s.rump_id IN (
                    SELECT rs.rump_id FROM %s rs WHERE rs.special = :specialAbilityId
                )
                %s',
                Spacecraft::class,
                SpacecraftBuildplan::class,
                ShipRumpSpecial::class,
                $specialAbilityId === ShipRumpSpecialAbilityEnum::COLONIZE ? 'AND bp.crew = 0' : ''
            )
        )->setParameters([
            'userId' => $userId,
            'specialAbilityId' => $specialAbilityId,
        ])->getSingleScalarResult();
    }

    #[Override]
    public function getAmountByUserAndRump(int $userId, int $rumpId): int
    {
        return $this->count([
            'user_id' => $userId,
            'rump_id' => $rumpId,
        ]);
    }

    #[Override]
    public function getByUser(UserInterface $user): array
    {
        return $this->findBy([
            'user_id' => $user,
        ]);
    }

    #[Override]
    public function getSuitableForShieldRegeneration(): array
    {
        return $this->getEntityManager()->createQuery(
            sprintf(
                'SELECT s FROM %s s
                JOIN %s sc
                WITH s = sc.spacecraft
                JOIN %s ss
                WITH s.id = ss.spacecraft_id
                JOIN %s bp
                WITH s.plan_id = bp.id
                WHERE ss.system_type = :shieldType
                AND ss.mode < :modeOn
                AND sc.shield < s.max_schilde
                AND (SELECT count(ca.crew) FROM %s ca WHERE s = ca.spacecraft) >= bp.crew
                AND NOT EXISTS (SELECT a FROM %s a
                                WHERE a.location_id = s.location_id
                                AND a.anomaly_type_id in (:anomalyTypes)
                                AND a.remaining_ticks > 0)',
                Spacecraft::class,
                SpacecraftCondition::class,
                SpacecraftSystem::class,
                SpacecraftBuildplan::class,
                CrewAssignment::class,
                Anomaly::class
            )
        )->setParameters([
            'shieldType' => SpacecraftSystemTypeEnum::SHIELDS->value,
            'modeOn' => SpacecraftSystemModeEnum::MODE_ON->value,
            'anomalyTypes' => [AnomalyTypeEnum::SUBSPACE_ELLIPSE, AnomalyTypeEnum::ION_STORM]
        ])->getResult();
    }

    #[Override]
    public function getPlayerSpacecraftsForTick(): iterable
    {
        return $this->getEntityManager()->createQuery(
            sprintf(
                'SELECT s
                FROM %s s
                JOIN %s sc
                WITH s = sc.spacecraft
                JOIN %s p
                WITH s.plan_id = p.id
                JOIN %s u
                WITH s.user_id = u.id
                WHERE s.user_id > :firstUserId
                AND (   ((SELECT count(ca.crew)
                        FROM %s ca
                        WHERE ca.spacecraft = s) > 0)
                    OR
                        (sc.state IN (:scrapping, :underConstruction))
                    OR
                        (p.crew = 0))
                AND (u.vac_active = :false OR u.vac_request_date > :vacationThreshold)',
                Spacecraft::class,
                SpacecraftCondition::class,
                SpacecraftBuildplan::class,
                User::class,
                CrewAssignment::class
            )
        )->setParameters([
            'underConstruction' => SpacecraftStateEnum::UNDER_CONSTRUCTION,
            'scrapping' => SpacecraftStateEnum::UNDER_SCRAPPING,
            'vacationThreshold' => time() - UserEnum::VACATION_DELAY_IN_SECONDS,
            'firstUserId' => UserEnum::USER_FIRST_ID,
            'false' => false
        ])->toIterable();
    }

    #[Override]
    public function getNpcSpacecraftsForTick(): array
    {
        return $this->getEntityManager()->createQuery(
            sprintf(
                'SELECT s FROM %s s WHERE s.user_id BETWEEN 2 AND (:firstUserId - 1)',
                Spacecraft::class
            )
        )->setParameter('firstUserId', UserEnum::USER_FIRST_ID)->getResult();
    }

    #[Override]
    public function isCloakedSpacecraftAtLocation(
        SpacecraftInterface $spacecraft
    ): bool {

        $result = $this->getEntityManager()->createQuery(
            sprintf(
                'SELECT COUNT(s.id) FROM %s s
                    WHERE s.location = :location
                    AND EXISTS (SELECT ss.id
                            FROM %s ss
                            WHERE s = ss.spacecraft
                            AND ss.system_type = %d
                            AND ss.mode > 1)
                    AND s.user != :ignoreUser',
                Spacecraft::class,
                SpacecraftSystem::class,
                SpacecraftSystemTypeEnum::CLOAK->value
            )
        )->setParameters([
            'location' => $spacecraft->getLocation(),
            'ignoreUser' => $spacecraft->getUser()
        ])->getSingleScalarResult();

        return $result > 0;
    }

    #[Override]
    public function getSingleSpacecraftScannerResults(
        SpacecraftInterface $spacecraft,
        bool $showCloaked = false,
        MapInterface|StarSystemMapInterface|null $field = null
    ): array {

        $rsm = new ResultSetMapping();
        $rsm->addEntityResult(TShipItem::class, 's');
        TShipItem::addTSpacecraftItemFields($rsm);

        $location = $field ?? $spacecraft->getLocation();

        $query = $this->getEntityManager()->createNativeQuery(
            sprintf(
                'SELECT sp.id as shipid, s.fleet_id as fleetid, sp.rump_id as rumpid , ss.mode as warpstate,
                    twd.mode as tractorwarpstate, COALESCE(ss2.mode,0) as cloakstate, ss3.mode as shieldstate, COALESCE(ss4.status,0) as uplinkstate,
                    sp.type as spacecrafttype, sp.name as shipname, sc.hull as hull, sp.max_huelle as maxhull,
                    sc.shield as shield, sp.holding_web_id as webid, tw.finished_time as webfinishtime, u.id as userid, u.username,
                    r.category_id as rumpcategoryid, r.name as rumpname, r.role_id as rumproleid,
                    (SELECT count(*) > 0 FROM stu_ship_log sl WHERE sl.spacecraft_id = sp.id AND sl.is_private = :false) as haslogbook,
                    (SELECT count(*) > 0 FROM stu_crew_assign ca WHERE ca.spacecraft_id = sp.id) as hascrew
                FROM stu_spacecraft sp
                JOIN stu_spacecraft_condition sc
                ON sp.id = sc.spacecraft_id
                LEFT JOIN stu_ship s
                ON s.id = sp.id
                LEFT JOIN stu_spacecraft_system ss
                ON sp.id = ss.spacecraft_id
                AND ss.system_type = :warpdriveType
                LEFT JOIN stu_spacecraft tractor
                ON tractor.tractored_ship_id = s.id
                LEFT JOIN stu_spacecraft_system twd
                ON tractor.id = twd.spacecraft_id
                AND twd.system_type = :warpdriveType
                LEFT JOIN stu_spacecraft_system ss2
                ON sp.id = ss2.spacecraft_id
                AND ss2.system_type = :cloakType
                LEFT JOIN stu_spacecraft_system ss3
                ON sp.id = ss3.spacecraft_id
                AND ss3.system_type = :shieldType
                LEFT JOIN stu_spacecraft_system ss4
                ON sp.id = ss4.spacecraft_id
                AND ss4.system_type = :uplinkType
                JOIN stu_rump r
                ON sp.rump_id = r.id
                LEFT OUTER JOIN stu_tholian_web tw
                ON sp.holding_web_id = tw.id
                JOIN stu_user u
                ON sp.user_id = u.id
                WHERE sp.location_id = :locationId
                AND sp.id != :ignoreId
                AND s.fleet_id IS NULL
                AND sp.type != :stationType
                %s
                ORDER BY r.category_id ASC, r.role_id ASC, r.id ASC, sp.name ASC',
                $showCloaked ? '' : sprintf(' AND (sp.user_id = %d OR COALESCE(ss2.mode,0) < %d) ', $spacecraft->getUser()->getId(), SpacecraftSystemModeEnum::MODE_ON->value)
            ),
            $rsm
        )->setParameters([
            'locationId' => $location->getId(),
            'locationId' => $location->/** @scrutinizer ignore-call */ getId(),
            'ignoreId' => $spacecraft->getId(),
            'cloakType' => SpacecraftSystemTypeEnum::CLOAK->value,
            'warpdriveType' => SpacecraftSystemTypeEnum::WARPDRIVE->value,
            'shieldType' => SpacecraftSystemTypeEnum::SHIELDS->value,
            'uplinkType' => SpacecraftSystemTypeEnum::UPLINK->value,
            'false' => false,
            'stationType' => SpacecraftTypeEnum::STATION->value
        ]);

        return $query->getResult();
    }

    #[Override]
    public function getRandomSpacecraftWithCrewByUser(int $userId): ?SpacecraftInterface
    {
        $rsm = new ResultSetMapping();
        $rsm->addScalarResult('id', 'id', 'integer');

        $result = $this->getEntityManager()
            ->createNativeQuery(
                'SELECT s.id as id FROM stu_spacecraft s
                WHERE s.user_id = :userId
                AND EXISTS (SELECT ca
                            FROM stu_crew_assign ca
                            WHERE s.id = ca.spacecraft_id)
                ORDER BY RANDOM()
                LIMIT 1',
                $rsm
            )
            ->setParameters([
                'userId' => $userId
            ])
            ->getOneOrNullResult();

        return $result != null
            ? $this->findOneBy(['id' => $result['id']])
            : null;
    }

    #[Override]
    public function getAllTractoringSpacecrafts(): array
    {
        return $this->getEntityManager()->createQuery(
            sprintf(
                'SELECT s FROM %s s
                WHERE s.tractored_ship_id IS NOT NULL',
                Spacecraft::class
            )
        )->getResult();
    }

    #[Override]
    public function truncateAllSpacecrafts(): void
    {
        $this->getEntityManager()->createQuery(
            sprintf(
                'DELETE FROM %s s',
                Spacecraft::class
            )
        )->execute();
    }
}

st-universe / core

Pull Request — master (#2138)

getSingleSpacecraftScannerResults() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
