SpacecraftAttacker::getPhaserHullDamageFactor() - Code Metrics - Inspection of "fix ticket-0665" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 83c248...96a6f5 )

by Janko

created 2025-02-20 20:05 UTC

SpacecraftAttacker::getPhaserHullDamageFactor() A

↳ Parent: SpacecraftAttacker

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stu\Module\Spacecraft\Lib\Battle\Provider;

use Override;
filter:
    dependency_paths: ["lib/*"]
use RuntimeException;
use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Module\Control\StuRandom;
use Stu\Module\Spacecraft\Lib\Torpedo\ShipTorpedoManagerInterface;
use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
use Stu\Orm\Entity\LocationInterface;
use Stu\Orm\Entity\ModuleInterface;
use Stu\Orm\Entity\SpacecraftInterface;
use Stu\Orm\Entity\TorpedoTypeInterface;

class SpacecraftAttacker extends AbstractEnergyAttacker implements ProjectileAttackerInterface
{
    public function __construct(
        private SpacecraftWrapperInterface $wrapper,
        private ShipTorpedoManagerInterface $shipTorpedoManager,
        StuRandom $stuRandom
    ) {
        parent::__construct($stuRandom);
    }

    #[Override]
    public function getPhaserVolleys(): int
    {
        return $this->get()->getRump()->getPhaserVolleys();
    }

    #[Override]
    public function getPhaserState(): bool
    {
        return $this->get()->getPhaserState();
    }

    #[Override]
    public function hasSufficientEnergy(int $amount): bool
    {
        $epsSystemData = $this->wrapper->getEpsSystemData();
        if ($epsSystemData === null) {
            return false;
        }
        return $epsSystemData->getEps() >= $amount;
    }

    #[Override]
    public function getWeaponModule(): ModuleInterface
    {
        if ($this->module === null) {
            $shipSystem = $this->get()->getSpacecraftSystem(SpacecraftSystemTypeEnum::PHASER);

            $module = $shipSystem->getModule();
            if ($module === null) {
                throw new RuntimeException('weapon system should have a module');
            }

            $this->module = $module;
        }

        return $this->module;

    }

    #[Override]
    public function getEnergyWeaponBaseDamage(): int
    {
        return $this->get()->getBaseDamage();
    }

    #[Override]
    public function reduceEps(int $amount): void
    {
        $epsSystemData = $this->wrapper->getEpsSystemData();
        if ($epsSystemData === null) {
            return;
        }
        $epsSystemData->lowerEps($amount)->update();
    }

    #[Override]
    public function getName(): string
    {
        return $this->get()->getName();
    }

    #[Override]
    public function getUserId(): int
    {
        return $this->get()->getUser()->getId();
    }

    private function get(): SpacecraftInterface
    {
        return $this->wrapper->get();
    }

    #[Override]
    public function getHitChance(): int
    {
        return $this->get()->getHitChance();
    }

    #[Override]
    public function getPhaserShieldDamageFactor(): int
    {
        return $this->get()->getRump()->getPhaserShieldDamageFactor();
    }

    #[Override]
    public function getPhaserHullDamageFactor(): int
    {
        return $this->get()->getRump()->getPhaserHullDamageFactor();
    }

    #[Override]
    public function getTorpedoVolleys(): int
    {
        return $this->get()->getRump()->getTorpedoVolleys();
    }

    #[Override]
    public function getTorpedoState(): bool
    {
        return $this->get()->getTorpedoState();
    }

    #[Override]
    public function getTorpedoCount(): int
    {
        return $this->get()->getTorpedoCount();
    }

    #[Override]
    public function getTorpedo(): ?TorpedoTypeInterface
    {
        return $this->get()->getTorpedo();
    }

    #[Override]
    public function lowerTorpedoCount(int $amount): void
    {
        $this->shipTorpedoManager->changeTorpedo($this->wrapper, -$amount);
    }

    #[Override]
    public function isShieldPenetration(): bool
    {
        $systemData = $this->wrapper->getProjectileLauncherSystemData();
        if ($systemData === null) {
            throw new RuntimeException('this should not happen');
        }

        return $this->stuRandom->rand(1, 10000) <= $systemData->getShieldPenetration();
    }

    #[Override]
    public function getProjectileWeaponDamage(bool $isCritical): int
    {
        $torpedo = $this->getTorpedo();
        if ($torpedo === null) {
            return 0;
        }

        $module = $this->get()->getSpacecraftSystem(SpacecraftSystemTypeEnum::TORPEDO)->getModule();
        if ($module === null) {
            return 0;
        }

        $variance = (int) round($torpedo->getBaseDamage() / 100 * $torpedo->getVariance());
        $basedamage = $torpedo->getBaseDamage();
        $damage = random_int($basedamage - $variance, $basedamage + $variance);

        return $isCritical ? $damage * 2 : $damage;
    }

    #[Override]
    public function getLocation(): LocationInterface
    {
        return $this->get()->getLocation();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Module\Spacecraft\Lib\Battle\Provider;
6
7		use Override;
		0 ignored issues – show Bug introduced 2024-07-04 06:34 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8		use RuntimeException;
9		use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
10		use Stu\Module\Control\StuRandom;
11		use Stu\Module\Spacecraft\Lib\Torpedo\ShipTorpedoManagerInterface;
12		use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
13		use Stu\Orm\Entity\LocationInterface;
14		use Stu\Orm\Entity\ModuleInterface;
15		use Stu\Orm\Entity\SpacecraftInterface;
16		use Stu\Orm\Entity\TorpedoTypeInterface;
17
18		class SpacecraftAttacker extends AbstractEnergyAttacker implements ProjectileAttackerInterface
19		{
20	24	public function __construct(
21		private SpacecraftWrapperInterface $wrapper,
22		private ShipTorpedoManagerInterface $shipTorpedoManager,
23		StuRandom $stuRandom
24		) {
25	24	parent::__construct($stuRandom);
26		}
27
28	1	#[Override]
29		public function getPhaserVolleys(): int
30		{
31	1	return $this->get()->getRump()->getPhaserVolleys();
32		}
33
34	1	#[Override]
35		public function getPhaserState(): bool
36		{
37	1	return $this->get()->getPhaserState();
38		}
39
40	3	#[Override]
41		public function hasSufficientEnergy(int $amount): bool
42		{
43	3	$epsSystemData = $this->wrapper->getEpsSystemData();
44	3	if ($epsSystemData === null) {
45	1	return false;
46		}
47	2	return $epsSystemData->getEps() >= $amount;
48		}
49
50	2	#[Override]
51		public function getWeaponModule(): ModuleInterface
52		{
53	2	if ($this->module === null) {
54	2	$shipSystem = $this->get()->getSpacecraftSystem(SpacecraftSystemTypeEnum::PHASER);
55
56	2	$module = $shipSystem->getModule();
57	2	if ($module === null) {
58	1	throw new RuntimeException('weapon system should have a module');
59		}
60
61	1	$this->module = $module;
62		}
63
64	1	return $this->module;
		0 ignored issues – show Bug Best Practice introduced 2023-11-28 21:50 UTC by Report Bug Copy Issue Report The expression `return $this->module` could return the type `null` which is incompatible with the type-hinted return `Stu\Orm\Entity\ModuleInterface`. Consider adding an additional type-check to rule them out. Loading history...
65		}
66
67	1	#[Override]
68		public function getEnergyWeaponBaseDamage(): int
69		{
70	1	return $this->get()->getBaseDamage();
71		}
72
73	2	#[Override]
74		public function reduceEps(int $amount): void
75		{
76	2	$epsSystemData = $this->wrapper->getEpsSystemData();
77	2	if ($epsSystemData === null) {
78	1	return;
79		}
80	1	$epsSystemData->lowerEps($amount)->update();
81		}
82
83	1	#[Override]
84		public function getName(): string
85		{
86	1	return $this->get()->getName();
87		}
88
89	1	#[Override]
90		public function getUserId(): int
91		{
92	1	return $this->get()->getUser()->getId();
93		}
94
95	17	private function get(): SpacecraftInterface
96		{
97	17	return $this->wrapper->get();
98		}
99
100	1	#[Override]
101		public function getHitChance(): int
102		{
103	1	return $this->get()->getHitChance();
104		}
105
106	1	#[Override]
107		public function getPhaserShieldDamageFactor(): int
108		{
109	1	return $this->get()->getRump()->getPhaserShieldDamageFactor();
110		}
111
112	1	#[Override]
113		public function getPhaserHullDamageFactor(): int
114		{
115	1	return $this->get()->getRump()->getPhaserHullDamageFactor();
116		}
117
118	1	#[Override]
119		public function getTorpedoVolleys(): int
120		{
121	1	return $this->get()->getRump()->getTorpedoVolleys();
122		}
123
124	1	#[Override]
125		public function getTorpedoState(): bool
126		{
127	1	return $this->get()->getTorpedoState();
128		}
129
130	1	#[Override]
131		public function getTorpedoCount(): int
132		{
133	1	return $this->get()->getTorpedoCount();
134		}
135
136	4	#[Override]
137		public function getTorpedo(): ?TorpedoTypeInterface
138		{
139	4	return $this->get()->getTorpedo();
140		}
141
142	1	#[Override]
143		public function lowerTorpedoCount(int $amount): void
144		{
145	1	$this->shipTorpedoManager->changeTorpedo($this->wrapper, -$amount);
146		}
147
148		#[Override]
149		public function isShieldPenetration(): bool
150		{
151		$systemData = $this->wrapper->getProjectileLauncherSystemData();
152		if ($systemData === null) {
153		throw new RuntimeException('this should not happen');
154		}
155
156		return $this->stuRandom->rand(1, 10000) <= $systemData->getShieldPenetration();
157		}
158
159	3	#[Override]
160		public function getProjectileWeaponDamage(bool $isCritical): int
161		{
162	3	$torpedo = $this->getTorpedo();
163	3	if ($torpedo === null) {
164	1	return 0;
165		}
166
167	2	$module = $this->get()->getSpacecraftSystem(SpacecraftSystemTypeEnum::TORPEDO)->getModule();
168	2	if ($module === null) {
169	1	return 0;
170		}
171
172	1	$variance = (int) round($torpedo->getBaseDamage() / 100 * $torpedo->getVariance());
173	1	$basedamage = $torpedo->getBaseDamage();
174	1	$damage = random_int($basedamage - $variance, $basedamage + $variance);
175
176	1	return $isCritical ? $damage * 2 : $damage;
177		}
178
179		#[Override]
180		public function getLocation(): LocationInterface
181		{
182		return $this->get()->getLocation();
183		}
184		}
185

st-universe / core

Push — dev ( 83c248...96a6f5 )

SpacecraftAttacker::getPhaserHullDamageFactor() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like