SubspaceSensorSystemSettings::setSignatures() - Code Metrics - Inspection of "code optimizations" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 32c6f4...c9ac14 )

by Janko

created 2025-07-19 16:51 UTC

SubspaceSensorSystemSettings::setSignatures() B

↳ Parent: SubspaceSensorSystemSettings

Complexity

Conditions	6
Paths	5

Size

Total Lines	33
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
cc	6
eloc	23
c	0
b	0
f	0
nc	5
nop	3
dl	0
loc	33
ccs	0
cts	24
cp	0
crap	42
rs	8.9297

<?php

declare(strict_types=1);

namespace Stu\Module\Spacecraft\View\ShowSystemSettings;

use Stu\Component\Spacecraft\System\Data\SubspaceSystemData;
use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Component\Spacecraft\System\SpacecraftSystemWrapperFactoryInterface;
use Stu\Module\Control\GameControllerInterface;
filter:
    dependency_paths: ["lib/*"]
use Stu\Module\Control\StuTime;
use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
use Stu\Orm\Repository\FlightSignatureRepositoryInterface;

class SubspaceSensorSystemSettings implements SystemSettingsProviderInterface
{
    public function __construct(
        private readonly SpacecraftSystemWrapperFactoryInterface $spacecraftSystemWrapperFactory,
        private readonly FlightSignatureRepositoryInterface $flightSignatureRepository,
        private readonly StuTime $stuTime
    ) {}

    public function setTemplateVariables(
        SpacecraftSystemTypeEnum $systemType,
        SpacecraftWrapperInterface $wrapper,
        GameControllerInterface $game
    ): void {
        $game->setMacroInAjaxWindow('html/spacecraft/system/subspaceScanner.twig');

        $spacecraft = $wrapper->get();

        $isSubspaceScannerActive = $spacecraft->getSystemState(SpacecraftSystemTypeEnum::SUBSPACE_SCANNER);
        $isMatrixScannerHealthy = $spacecraft->isSystemHealthy(SpacecraftSystemTypeEnum::MATRIX_SCANNER);

        if ($isMatrixScannerHealthy && $isSubspaceScannerActive) {

            $subspaceSystemData = $wrapper->getSubspaceSystemData();
            if ($subspaceSystemData === null) {
                return;
            }

            $time = $this->stuTime->time();

            $this->setAnalyzedSignature($subspaceSystemData, $game);
            $this->setAnalyzeTime($time, $subspaceSystemData, $game);
            $this->setSignatures($wrapper, $time, $game);
        } else {
            $game->setTemplateVar('SYSTEMWARNING', true);
        }

        $game->setTemplateVar('USER', $game->getUser());
        $game->setTemplateVar('SPACECRAFT', $spacecraft);
        $game->setTemplateVar(
            'systemWrapper',
            $this->spacecraftSystemWrapperFactory->create($wrapper->get(), $systemType)
        );
    }

    private function setAnalyzedSignature(SubspaceSystemData $subspaceSystemData, GameControllerInterface $game): void
    {
        $flightSigId = $subspaceSystemData->getFlightSigId();
        if ($flightSigId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $flightSig = $this->flightSignatureRepository->find($flightSigId);
            $game->setTemplateVar('ANALYZED_SIGNATURE', $flightSig);
        }
    }

    private function setAnalyzeTime(int $time, SubspaceSystemData $subspaceSystemData, GameControllerInterface $game): void
    {
        $analyzeTime = $subspaceSystemData->getAnalyzeTime();
        if ($analyzeTime) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $currentTime = $time;
            $maxTime = $analyzeTime + (10 * 60);
            $game->setTemplateVar('ANALYZE_TIME', $analyzeTime);

            if ($currentTime <= $maxTime) {
                $game->setTemplateVar('ANALYZE_TIME', $analyzeTime);
            }
        }
    }

    private function setSignatures(SpacecraftWrapperInterface $wrapper, int $time, GameControllerInterface $game): void
    {
        $spacecraft = $wrapper->get();
        $location = $spacecraft->getLocation();

        $layerId = $location->getLayer()?->getId();
        if ($layerId === null) {
            return;
        }

        $system = $spacecraft->getSystem();
        if ($system) {
            $cx = $system->getCx();
            $cy = $system->getCy();
        } else {
            $cx = $location->getCx();
            $cy = $location->getCy();
        }

        if ($cx && $cy && $layerId) {

            $timeThreshold = $time - (12 * 3600);
            $sensorRange = $wrapper->getLssSystemData()?->getSensorRange() ?? 0;

            $signatures = $this->flightSignatureRepository->getSignaturesInSensorRange(
                $game->getUser()->getId(),
                $cx,
                $cy,
                $layerId,
                $sensorRange,
                $timeThreshold
            );
            $game->setTemplateVar('SIGNATURES', $signatures);
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stu\Module\Spacecraft\View\ShowSystemSettings;
6
7		use Stu\Component\Spacecraft\System\Data\SubspaceSystemData;
8		use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
9		use Stu\Component\Spacecraft\System\SpacecraftSystemWrapperFactoryInterface;
10		use Stu\Module\Control\GameControllerInterface;
		0 ignored issues – show Bug introduced 2025-07-17 15:24 UTC by Report Bug Copy Issue Report The type `Stu\Module\Control\GameControllerInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11		use Stu\Module\Control\StuTime;
12		use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
13		use Stu\Orm\Repository\FlightSignatureRepositoryInterface;
14
15		class SubspaceSensorSystemSettings implements SystemSettingsProviderInterface
16		{
17	1	public function __construct(
18		private readonly SpacecraftSystemWrapperFactoryInterface $spacecraftSystemWrapperFactory,
19		private readonly FlightSignatureRepositoryInterface $flightSignatureRepository,
20		private readonly StuTime $stuTime
21	1	) {}
22
23		public function setTemplateVariables(
24		SpacecraftSystemTypeEnum $systemType,
25		SpacecraftWrapperInterface $wrapper,
26		GameControllerInterface $game
27		): void {
28		$game->setMacroInAjaxWindow('html/spacecraft/system/subspaceScanner.twig');
29
30		$spacecraft = $wrapper->get();
31
32		$isSubspaceScannerActive = $spacecraft->getSystemState(SpacecraftSystemTypeEnum::SUBSPACE_SCANNER);
33		$isMatrixScannerHealthy = $spacecraft->isSystemHealthy(SpacecraftSystemTypeEnum::MATRIX_SCANNER);
34
35		if ($isMatrixScannerHealthy && $isSubspaceScannerActive) {
36
37		$subspaceSystemData = $wrapper->getSubspaceSystemData();
38		if ($subspaceSystemData === null) {
39		return;
40		}
41
42		$time = $this->stuTime->time();
43
44		$this->setAnalyzedSignature($subspaceSystemData, $game);
45		$this->setAnalyzeTime($time, $subspaceSystemData, $game);
46		$this->setSignatures($wrapper, $time, $game);
47		} else {
48		$game->setTemplateVar('SYSTEMWARNING', true);
49		}
50
51		$game->setTemplateVar('USER', $game->getUser());
52		$game->setTemplateVar('SPACECRAFT', $spacecraft);
53		$game->setTemplateVar(
54		'systemWrapper',
55		$this->spacecraftSystemWrapperFactory->create($wrapper->get(), $systemType)
56		);
57		}
58
59		private function setAnalyzedSignature(SubspaceSystemData $subspaceSystemData, GameControllerInterface $game): void
60		{
61		$flightSigId = $subspaceSystemData->getFlightSigId();
62		if ($flightSigId) {
		0 ignored issues – show Bug Best Practice introduced 2025-07-18 20:51 UTC by Report Bug Copy Issue Report The expression `$flightSigId` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
63		$flightSig = $this->flightSignatureRepository->find($flightSigId);
64		$game->setTemplateVar('ANALYZED_SIGNATURE', $flightSig);
65		}
66		}
67
68		private function setAnalyzeTime(int $time, SubspaceSystemData $subspaceSystemData, GameControllerInterface $game): void
69		{
70		$analyzeTime = $subspaceSystemData->getAnalyzeTime();
71		if ($analyzeTime) {
		0 ignored issues – show Bug Best Practice introduced 2025-07-18 20:51 UTC by Report Bug Copy Issue Report The expression `$analyzeTime` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
72		$currentTime = $time;
73		$maxTime = $analyzeTime + (10 * 60);
74		$game->setTemplateVar('ANALYZE_TIME', $analyzeTime);
75
76		if ($currentTime <= $maxTime) {
77		$game->setTemplateVar('ANALYZE_TIME', $analyzeTime);
78		}
79		}
80		}
81
82		private function setSignatures(SpacecraftWrapperInterface $wrapper, int $time, GameControllerInterface $game): void
83		{
84		$spacecraft = $wrapper->get();
85		$location = $spacecraft->getLocation();
86
87		$layerId = $location->getLayer()?->getId();
88		if ($layerId === null) {
89		return;
90		}
91
92		$system = $spacecraft->getSystem();
93		if ($system) {
94		$cx = $system->getCx();
95		$cy = $system->getCy();
96		} else {
97		$cx = $location->getCx();
98		$cy = $location->getCy();
99		}
100
101		if ($cx && $cy && $layerId) {
102
103		$timeThreshold = $time - (12 * 3600);
104		$sensorRange = $wrapper->getLssSystemData()?->getSensorRange() ?? 0;
105
106		$signatures = $this->flightSignatureRepository->getSignaturesInSensorRange(
107		$game->getUser()->getId(),
108		$cx,
109		$cy,
110		$layerId,
111		$sensorRange,
112		$timeThreshold
113		);
114		$game->setTemplateVar('SIGNATURES', $signatures);
115		}
116		}
117		}
118

st-universe / core

Push — dev ( 32c6f4...c9ac14 )

SubspaceSensorSystemSettings::setSignatures() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like