Stu\Component\Map\EncodedMap

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getKey()	0	13	3
A	getEncodedMapPath()	0	8	1

<?php

declare(strict_types=1);

namespace Stu\Component\Map;

use RuntimeException;
use Stu\Module\Config\StuConfigInterface;
use Stu\Orm\Entity\LayerInterface;

class EncodedMap implements EncodedMapInterface
{
    private StuConfigInterface $stuConfig;

    private ?string $key = null;

    public function __construct(StuConfigInterface $stuConfig)
    {
        $this->stuConfig = $stuConfig;
    }

    public function getEncodedMapPath(int $mapFieldType, LayerInterface $layer): string
    {
        $key = $this->getKey();

        return sprintf(
            '%d/encoded/%s.png',
            $layer->getId(),
            implode("/", str_split(bin2hex(base64_encode(crypt((string)$mapFieldType, $key))), 8))

It seems like str_split(bin2hex(base64_encode(crypt((string)$mapFieldType, $key))), 8) can also be of type true; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

        );
    }

    private function getKey(): string
    {
        if ($this->key === null) {
            $key = $this->stuConfig->getGameSettings()->getMapSettings()->getEncryptionKey();

            if ($key === null) {
                throw new RuntimeException('encoding key is missing in configuration');
            }

            $this->key = $key;
        }

        return $this->key;

The expression return $this->key could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}