FlightCompanyFactory::getSubject() - Code Metrics - Inspection of "introduce flightCompany (#2072)" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 6e0cf6...2a5475 )

by Janko

created 2025-04-10 09:39 UTC

FlightCompanyFactory::getSubject() A

↳ Parent: FlightCompanyFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
nc	3
nop	1
dl	0
loc	13
ccs	0
cts	8
cp	0
crap	12
rs	10
c	1
b	0
f	0

<?php

namespace Stu\Module\Spacecraft\Lib\Movement;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Stu\Module\Ship\Lib\FleetWrapperInterface;
use Stu\Module\Spacecraft\Lib\Movement\Component\PreFlight\PreFlightConditionsCheckInterface;
use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;

class FlightCompanyFactory
{
    public function __construct(private PreFlightConditionsCheckInterface $preFlightConditionsCheck) {}

    public function create(SpacecraftWrapperInterface $leadWrapper): FlightCompany
    {
        $subject = $this->getSubject($leadWrapper);

        return new FlightCompany(
            $subject,
            $this->getMembers($subject),
            $this->preFlightConditionsCheck
        );
    }

    private function getSubject(SpacecraftWrapperInterface $leadWrapper): SpacecraftWrapperInterface|FleetWrapperInterface
    {
        $fleetWrapper = $leadWrapper->getFleetWrapper();
        if ($fleetWrapper === null) {
            return $leadWrapper;
        }

        $fleetLeader = $fleetWrapper->getLeadWrapper()->get();

        //TODO check for isFleetLeader too?
        return $fleetLeader === $leadWrapper->get()

            ? $fleetWrapper
            : $leadWrapper;
    }

    /** @return Collection<int, covariant SpacecraftWrapperInterface> */
    private function getMembers(SpacecraftWrapperInterface|FleetWrapperInterface $subject): Collection
    {
        return $subject instanceof FleetWrapperInterface
            ? $subject->getShipWrappers()
            : new ArrayCollection([$subject->get()->getId() => $subject]);
    }
}


1		<?php
2
3		namespace Stu\Module\Spacecraft\Lib\Movement;
4
5		use Doctrine\Common\Collections\ArrayCollection;
6		use Doctrine\Common\Collections\Collection;
7		use Stu\Module\Ship\Lib\FleetWrapperInterface;
8		use Stu\Module\Spacecraft\Lib\Movement\Component\PreFlight\PreFlightConditionsCheckInterface;
9		use Stu\Module\Spacecraft\Lib\SpacecraftWrapperInterface;
10
11		class FlightCompanyFactory
12		{
13	1	public function __construct(private PreFlightConditionsCheckInterface $preFlightConditionsCheck) {}
14
15		public function create(SpacecraftWrapperInterface $leadWrapper): FlightCompany
16		{
17		$subject = $this->getSubject($leadWrapper);
18
19		return new FlightCompany(
20		$subject,
21		$this->getMembers($subject),
22		$this->preFlightConditionsCheck
23		);
24		}
25
26		private function getSubject(SpacecraftWrapperInterface $leadWrapper): SpacecraftWrapperInterface\|FleetWrapperInterface
27		{
28		$fleetWrapper = $leadWrapper->getFleetWrapper();
29		if ($fleetWrapper === null) {
30		return $leadWrapper;
31		}
32
33		$fleetLeader = $fleetWrapper->getLeadWrapper()->get();
34
35		//TODO check for isFleetLeader too?
36		return $fleetLeader === $leadWrapper->get()
		0 ignored issues – show introduced 2025-04-10 07:26 UTC by Report Bug Copy Issue Report The condition `$fleetLeader === $leadWrapper->get()` is always `false`. Loading history...
37		? $fleetWrapper
38		: $leadWrapper;
39		}
40
41		/** @return Collection<int, covariant SpacecraftWrapperInterface> */
42		private function getMembers(SpacecraftWrapperInterface\|FleetWrapperInterface $subject): Collection
43		{
44		return $subject instanceof FleetWrapperInterface
45		? $subject->getShipWrappers()
46		: new ArrayCollection([$subject->get()->getId() => $subject]);
47		}
48		}
49

st-universe / core

Push — dev ( 6e0cf6...2a5475 )

FlightCompanyFactory::getSubject() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like