ColonyMember::canBeAccessedFrom() - Code Metrics - Inspection of "ships in web don't shoot back when shot from outsi..." - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 0aa780...31f66c )

by Janko

created 2024-12-30 14:17 UTC

ColonyMember::canBeAccessedFrom() A

↳ Parent: ColonyMember

Complexity

Conditions	3
Paths	2

Size

Total Lines	15
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.072

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	2
nop	3
dl	0
loc	15
ccs	4
cts	5
cp	0.8
crap	3.072
rs	10
c	0
b	0
f	0

<?php

namespace Stu\Lib\Interaction\Member;

use Override;
filter:
    dependency_paths: ["lib/*"]
use Stu\Lib\Interaction\InteractionCheckType;
use Stu\Module\Ship\Lib\TholianWebUtilInterface;
use Stu\Orm\Entity\ColonyInterface;
use Stu\Orm\Entity\MapInterface;
use Stu\Orm\Entity\StarSystemMapInterface;
use Stu\Orm\Entity\UserInterface;

class ColonyMember implements InteractionMemberInterface
{
    public function __construct(
        private TholianWebUtilInterface $tholianWebUtil,
        private ColonyInterface $colony
    ) {}

    #[Override]
    public function get(): ColonyInterface
    {
        return $this->colony;
    }

    #[Override]
    public function canAccess(
        InteractionMemberInterface $other,
        callable $shouldCheck
    ): ?InteractionCheckType {
        return null;
    }

    #[Override]
    public function canBeAccessedFrom(
        InteractionMemberInterface $other,
        bool $isFriend,
        callable $shouldCheck
    ): ?InteractionCheckType {

        if (
            $shouldCheck(InteractionCheckType::EXPECT_TARGET_ALSO_IN_FINISHED_WEB)
            && $this->tholianWebUtil->isTargetOutsideFinishedTholianWeb($other->get(), $this->colony)
        ) {
            return InteractionCheckType::EXPECT_TARGET_ALSO_IN_FINISHED_WEB;
        }

        return null;
    }

    #[Override]
    public function getLocation(): MapInterface|StarSystemMapInterface
    {
        return $this->colony->getLocation();
    }

    #[Override]
    public function getUser(): ?UserInterface
    {
        return $this->colony->getUser();
    }
}


1		<?php
2
3		namespace Stu\Lib\Interaction\Member;
4
5		use Override;
		0 ignored issues – show Bug introduced 2024-12-14 23:56 UTC by Report Bug Copy Issue Report The type `Override` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6		use Stu\Lib\Interaction\InteractionCheckType;
7		use Stu\Module\Ship\Lib\TholianWebUtilInterface;
8		use Stu\Orm\Entity\ColonyInterface;
9		use Stu\Orm\Entity\MapInterface;
10		use Stu\Orm\Entity\StarSystemMapInterface;
11		use Stu\Orm\Entity\UserInterface;
12
13		class ColonyMember implements InteractionMemberInterface
14		{
15	4	public function __construct(
16		private TholianWebUtilInterface $tholianWebUtil,
17		private ColonyInterface $colony
18	4	) {}
19
20		#[Override]
21		public function get(): ColonyInterface
22		{
23		return $this->colony;
24		}
25
26	2	#[Override]
27		public function canAccess(
28		InteractionMemberInterface $other,
29		callable $shouldCheck
30		): ?InteractionCheckType {
31	2	return null;
32		}
33
34	2	#[Override]
35		public function canBeAccessedFrom(
36		InteractionMemberInterface $other,
37		bool $isFriend,
38		callable $shouldCheck
39		): ?InteractionCheckType {
40
41		if (
42	2	$shouldCheck(InteractionCheckType::EXPECT_TARGET_ALSO_IN_FINISHED_WEB)
43	2	&& $this->tholianWebUtil->isTargetOutsideFinishedTholianWeb($other->get(), $this->colony)
44		) {
45		return InteractionCheckType::EXPECT_TARGET_ALSO_IN_FINISHED_WEB;
46		}
47
48	2	return null;
49		}
50
51	4	#[Override]
52		public function getLocation(): MapInterface\|StarSystemMapInterface
53		{
54	4	return $this->colony->getLocation();
55		}
56
57	4	#[Override]
58		public function getUser(): ?UserInterface
59		{
60	4	return $this->colony->getUser();
61		}
62		}
63

st-universe / core

Push — dev ( 0aa780...31f66c )

ColonyMember::canBeAccessedFrom() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like