Stu\Module\Tick\Lock\LockManager

Complexity

Total Complexity

8

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

90%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getLockPath()	0	7	1
A	setLock()	0	3	1
A	isLocked()	0	3	1
A	getGroupCount()	0	7	3
A	__construct()	0	3	1
A	clearLock()	0	3	1

<?php

declare(strict_types=1);

namespace Stu\Module\Tick\Lock;

use Stu\Module\Config\StuConfigInterface;

final class LockManager implements LockManagerInterface
{
    private StuConfigInterface $config;

    public function __construct(StuConfigInterface $config)
    {
        $this->config = $config;
    }

    public function setLock(int $batchGroupId, LockTypeEnum $type): void
    {
        @touch($this->getLockPath($batchGroupId, $type));

It seems like you do not handle an error condition for touch(). This can introduce security issues, and is generally not recommended.

    }

    public function clearLock(int $batchGroupId, LockTypeEnum $type): void
    {
        @unlink($this->getLockPath($batchGroupId, $type));

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

    }

    public function isLocked(int $entityId, LockTypeEnum $type): bool
    {
        return @file_exists($this->getLockPath($entityId % $this->getGroupCount($type) + 1, $type));
    }

    private function getLockPath(int $batchGroupId, LockTypeEnum $type): string
    {
        return sprintf(
            '%s/%s_%d.lock',
            $this->config->getGameSettings()->getTempDir(),
            $type->getName(),
            $batchGroupId
        );
    }

    private function getGroupCount(LockTypeEnum $type): int
    {
        switch ($type) {
            case LockTypeEnum::COLONY_GROUP:
                return $this->config->getGameSettings()->getColonySettings()->getTickWorker();
            case LockTypeEnum::SHIP_GROUP:

The function implicitly returns null when this case condition does not match. This is incompatible with the type-hinted return integer. Consider adding a default case to the switch.

                return 1;
        }
    }
}