Stu\Module\Commodity\Lib\CommodityCache

Complexity

Total Complexity

6

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

16.66%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	0	7	2
A	getAll()	0	11	3

<?php

declare(strict_types=1);

namespace Stu\Module\Commodity\Lib;

use Stu\Orm\Entity\CommodityInterface;
use Stu\Orm\Repository\CommodityRepositoryInterface;

final class CommodityCache implements CommodityCacheInterface
{
    private CommodityRepositoryInterface $commodityRepository;

    /**
     * @var array<int, CommodityInterface>|null
     */
    private ?array $commodityArray = null;

    public function __construct(
        CommodityRepositoryInterface $commodityRepository
    ) {
        $this->commodityRepository = $commodityRepository;
    }

    public function get(int $commodityId): CommodityInterface
    {
        if ($this->commodityArray === null) {
            $this->commodityArray = $this->commodityRepository->getAll();
        }

        return $this->commodityArray[$commodityId];
    }

    public function getAll(int $type = null): array
    {
        if ($this->commodityArray === null) {
            $this->commodityArray = $this->commodityRepository->getAll();
        }

        if ($type !== null) {
            return array_filter($this->commodityArray, fn (CommodityInterface $commodity) => $commodity->getType() === $type);

It seems like $this->commodityArray can also be of type null; however, parameter $array of array_filter() does only seem to accept array, maybe add an additional type check?

        }

        return $this->commodityArray;

The expression return $this->commodityArray could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}