| Conditions | 1 |
| Paths | 1 |
| Total Lines | 56 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 17 | public function up(Schema $schema): void |
||
| 18 | { |
||
| 19 | $this->addSql(<<<'SQL' |
||
| 20 | CREATE TABLE stu_rump_base_values (evade_chance SMALLINT NOT NULL, hit_chance SMALLINT NOT NULL, module_level SMALLINT NOT NULL, base_crew SMALLINT NOT NULL, base_eps SMALLINT NOT NULL, base_reactor SMALLINT NOT NULL, base_hull INT NOT NULL, base_shield INT NOT NULL, base_damage SMALLINT NOT NULL, base_sensor_range SMALLINT NOT NULL, base_warpdrive INT NOT NULL, special_slots INT NOT NULL, rump_id INT NOT NULL, PRIMARY KEY(rump_id)) |
||
| 21 | SQL); |
||
| 22 | $this->addSql(<<<'SQL' |
||
| 23 | INSERT INTO stu_rump_base_values |
||
| 24 | (rump_id, evade_chance, hit_chance, module_level, base_crew, base_eps, base_reactor, base_hull, base_shield, |
||
| 25 | base_damage, base_sensor_range, base_warpdrive, special_slots) |
||
| 26 | SELECT r.id, r.evade_chance, r.hit_chance, r.module_level, r.base_crew, r.base_eps, r.base_reactor, r.base_hull, r.base_shield, |
||
| 27 | r.base_damage, r.base_sensor_range, r.base_warpdrive, r.special_slots |
||
| 28 | FROM stu_rump r |
||
| 29 | SQL); |
||
| 30 | $this->addSql(<<<'SQL' |
||
| 31 | ALTER TABLE stu_rump_base_values ADD CONSTRAINT FK_C47ECAED2EE98D4C FOREIGN KEY (rump_id) REFERENCES stu_rump (id) ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE |
||
| 32 | SQL); |
||
| 33 | $this->addSql(<<<'SQL' |
||
| 34 | ALTER TABLE stu_rump DROP evade_chance |
||
| 35 | SQL); |
||
| 36 | $this->addSql(<<<'SQL' |
||
| 37 | ALTER TABLE stu_rump DROP hit_chance |
||
| 38 | SQL); |
||
| 39 | $this->addSql(<<<'SQL' |
||
| 40 | ALTER TABLE stu_rump DROP module_level |
||
| 41 | SQL); |
||
| 42 | $this->addSql(<<<'SQL' |
||
| 43 | ALTER TABLE stu_rump DROP base_crew |
||
| 44 | SQL); |
||
| 45 | $this->addSql(<<<'SQL' |
||
| 46 | ALTER TABLE stu_rump DROP base_eps |
||
| 47 | SQL); |
||
| 48 | $this->addSql(<<<'SQL' |
||
| 49 | ALTER TABLE stu_rump DROP base_reactor |
||
| 50 | SQL); |
||
| 51 | $this->addSql(<<<'SQL' |
||
| 52 | ALTER TABLE stu_rump DROP base_hull |
||
| 53 | SQL); |
||
| 54 | $this->addSql(<<<'SQL' |
||
| 55 | ALTER TABLE stu_rump DROP base_shield |
||
| 56 | SQL); |
||
| 57 | $this->addSql(<<<'SQL' |
||
| 58 | ALTER TABLE stu_rump DROP base_damage |
||
| 59 | SQL); |
||
| 60 | $this->addSql(<<<'SQL' |
||
| 61 | ALTER TABLE stu_rump DROP base_sensor_range |
||
| 62 | SQL); |
||
| 63 | $this->addSql(<<<'SQL' |
||
| 64 | ALTER TABLE stu_rump DROP base_warpdrive |
||
| 65 | SQL); |
||
| 66 | $this->addSql(<<<'SQL' |
||
| 67 | ALTER TABLE stu_rump DROP special_slots |
||
| 68 | SQL); |
||
| 69 | $this->addSql(<<<'SQL' |
||
| 70 | ALTER INDEX rump_role_idx RENAME TO IDX_AD2CDF30D60322AC |
||
| 71 | SQL); |
||
| 72 | $this->addSql(<<<'SQL' |
||
| 73 | ALTER INDEX rump_category_idx RENAME TO IDX_AD2CDF3012469DE2 |
||
| 175 |