SpacecraftTorpedoTrait::getMaxTorpedos() - Code Metrics - Inspection of "move base_damage to weapon system data" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 98511f...00baf5 )

by Janko

created 2025-06-03 17:48 UTC

SpacecraftTorpedoTrait::getMaxTorpedos() A

↳ Parent: SpacecraftTorpedoTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	5
ccs	4
cts	4
cp	1
crap	2
rs	10

<?php

namespace Stu\Component\Spacecraft\Trait;

use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Component\Spacecraft\System\Type\TorpedoStorageShipSystem;
filter:
    dependency_paths: ["lib/*"]
use Stu\Orm\Entity\TorpedoTypeInterface;

trait SpacecraftTorpedoTrait
{
    use SpacecraftTrait;
    use SpacecraftSystemHealthTrait;

    public function getTorpedoCount(): int
    {
        $torpedoStorage = $this->getThis()->getTorpedoStorage();
        if ($torpedoStorage === null) {
            return 0;
        }

        return $torpedoStorage->getStorage()->getAmount();
    }

    public function getTorpedo(): ?TorpedoTypeInterface
    {
        $torpedoStorage = $this->getThis()->getTorpedoStorage();
        if ($torpedoStorage === null) {
            return null;
        }

        return $torpedoStorage->getTorpedo();
    }

    public function getMaxTorpedos(): int
    {
        return $this->getThis()->getRump()->getBaseTorpedoStorage()
            + ($this->isSystemHealthy(SpacecraftSystemTypeEnum::TORPEDO_STORAGE)
                ? TorpedoStorageShipSystem::TORPEDO_CAPACITY : 0);
    }
}


1		<?php
2
3		namespace Stu\Component\Spacecraft\Trait;
4
5		use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
6		use Stu\Component\Spacecraft\System\Type\TorpedoStorageShipSystem;
		0 ignored issues – show Bug introduced 2024-12-14 23:56 UTC by Report Bug Copy Issue Report The type `Stu\Component\Spacecraft...orpedoStorageShipSystem` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7		use Stu\Orm\Entity\TorpedoTypeInterface;
8
9		trait SpacecraftTorpedoTrait
10		{
11		use SpacecraftTrait;
12		use SpacecraftSystemHealthTrait;
13
14		public function getTorpedoCount(): int
15		{
16		$torpedoStorage = $this->getThis()->getTorpedoStorage();
17		if ($torpedoStorage === null) {
18		return 0;
19		}
20
21		return $torpedoStorage->getStorage()->getAmount();
22		}
23
24	3	public function getTorpedo(): ?TorpedoTypeInterface
25		{
26	3	$torpedoStorage = $this->getThis()->getTorpedoStorage();
27	3	if ($torpedoStorage === null) {
28	3	return null;
29		}
30
31		return $torpedoStorage->getTorpedo();
32		}
33
34	3	public function getMaxTorpedos(): int
35		{
36	3	return $this->getThis()->getRump()->getBaseTorpedoStorage()
37	3	+ ($this->isSystemHealthy(SpacecraftSystemTypeEnum::TORPEDO_STORAGE)
38	3	? TorpedoStorageShipSystem::TORPEDO_CAPACITY : 0);
39		}
40		}
41

st-universe / core

Push — dev ( 98511f...00baf5 )

SpacecraftTorpedoTrait::getMaxTorpedos() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like