Stu\Module\Tick\Colony\Component\ProceedStorage::work()

Complexity

Conditions	11
Paths	28

Size

Total Lines	61
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	132

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function work(ColonyInterface $colony, array &$production, InformationInterface $information): void
    {
        $sum = $colony->getStorageSum();

        //DECREASE
        foreach ($production as $commodityId => $obj) {
            $amount = $obj->getProduction();
            $commodity = $this->commodityCache->get($commodityId);

            if ($amount < 0) {
                $amount = abs($amount);

                if ($commodity->isSaveable()) {
                    // STANDARD
                    $this->storageManager->lowerStorage(
                        $colony,
                        $this->commodityCache->get($commodityId),
                        $amount

It seems like $amount can also be of type double; however, parameter $amount of Stu\Lib\Transfer\Storage\StorageManagerInterface::lowerStorage() does only seem to accept integer, maybe add an additional type check?

                    );
                    $sum -= $amount;
                } else {
                    // EFFECTS
                    $depositMining = $this->colonyDepositMiningRepository->getCurrentUserDepositMinings($colony)[$commodityId];

                    $depositMining->setAmountLeft($depositMining->getAmountLeft() - $amount);

$depositMining->getAmountLeft() - $amount of type double is incompatible with the type integer expected by parameter $amountLeft of Stu\Orm\Entity\ColonyDepositMiningInterface::setAmountLeft().

                    $this->colonyDepositMiningRepository->save($depositMining);
                }
            }
        }

        foreach ($production as $commodityId => $obj) {

            $commodity = $this->commodityCache->get($commodityId);
            if ($obj->getProduction() <= 0 || !$commodity->isSaveable()) {
                continue;
            }

            $isStorageNotification = $this->userSettingsProvider->isStorageNotification($colony->getUser());
            if ($sum >= $colony->getMaxStorage()) {
                if ($isStorageNotification) {
                    $information->addInformation('Das Lager der Kolonie ist voll');
                }
                break;
            }
            if ($sum + $obj->getProduction() > $colony->getMaxStorage()) {
                $this->storageManager->upperStorage(
                    $colony,
                    $commodity,
                    $colony->getMaxStorage() - $sum
                );
                if ($isStorageNotification) {
                    $information->addInformation('Das Lager der Kolonie ist voll');
                }
                break;
            }
            $this->storageManager->upperStorage(
                $colony,
                $commodity,
                $obj->getProduction()
            );
            $sum += $obj->getProduction();
        }