Srmklive\PayPal\Traits\PayPalAPI\InvoicesSearch

Complexity

Total Complexity

2

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	searchInvoices()	0	16	2

<?php

namespace Srmklive\PayPal\Traits\PayPalAPI;

trait InvoicesSearch
{
    /**
     * Search and return existing invoices.
     *
     * @param array $filters
     * @param int $page
     * @param int $size
     * @param bool $totals
     * @param array $fields
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/invoicing/v2/#invoices_list
     */
    public function searchInvoices($filters, $page=1, $size=20, $totals=true, array $fields=[])
    {
        $fields_list = collect($fields);

        $fields = "";
        if ($fields_list->count() > 0)
            $fields = "&fields={$fields_list->implode(",")}";

        $this->apiEndPoint = "v2/invoicing/search-invoices?page={$page}&page_size={$size}&total_required={$totals}{$fields}";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->options['json'] = $filters;

The property options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'post';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();

It seems like doPayPalRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}