Srmklive\PayPal\Traits\PayPalAPI\CatalogProducts

Complexity

Total Complexity

4

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	updateProduct()	0	10	1
A	listProducts()	0	8	1
A	createProduct()	0	11	1
A	showProductDetails()	0	8	1

<?php

namespace Srmklive\PayPal\Traits\PayPalAPI;


trait CatalogProducts
{
    /**
     * Create a product.
     *
     * @param array $data
     * @param string $request_id
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/catalog-products/v1/#products_create
     */
    public function createProduct(array $data, $request_id)
    {
        $this->apiEndPoint = "v1/catalogs/products";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->options['headers']['PayPal-Request-Id'] = $request_id;

The property options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->options['json'] = $data;

        $this->verb = 'post';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();

It seems like doPayPalRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * List products.
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/catalog-products/v1/#products_list
     */
    public function listProducts()
    {
        $this->apiEndPoint = "v1/catalogs/products";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'get';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();
    }

    /**
     * Update a product.
     *
     * @param array $data
     * @param string $product_id
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/catalog-products/v1/#products_patch
     */
    public function updateProduct(array $data, $product_id)
    {
        $this->apiEndPoint = "v1/catalogs/products/{$product_id}";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->options['json'] = $data;

The property options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'patch';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();
    }

    /**
     * Get product details.
     *
     * @param string $product_id
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/catalog-products/v1/#products_get
     */
    public function showProductDetails($product_id)
    {
        $this->apiEndPoint = "v1/catalogs/products/{$product_id}";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'get';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();
    }
}