RecurringProfiles - Code Metrics - Inspection of "Adding the RecurringProfiles::createCustomSubscrip..." - srmklive/laravel-paypal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#241)

unknown

created 2018-10-04 19:45 UTC

RecurringProfiles A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	81
Duplicated Lines	32.1 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	1
dl	26
loc	81
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createCustomSubscription()	0	20	3
A	createMonthlySubscription()	13	13	1
A	createYearlySubscription()	13	13	1

How to fix Duplicated Code

<?php

namespace Srmklive\PayPal\Traits;

use Carbon\Carbon;

trait RecurringProfiles
{
    /**
     * Create recurring subscription on custom frequency basis.
     * The billing frequency is in months, i.e: if you want a monthly subscription, then your billing frequency would be 1.
     *
     * @param string $token
     * @param float $amount
     * @param string $description
     * @param int $billingFrequency
     * @param int $trialDays
     *
     * @return array
     */
    public function createCustomSubscription($token, $amount, $description, $billingFrequency, $trialDays = null)
    {
        $data = [
            'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
            'DESC'             => $description,
            'BILLINGPERIOD'    => 'Month',
            'BILLINGFREQUENCY' => $billingFrequency,
            'AMT'              => $amount,
            'CURRENCYCODE'     => $this->currency,
class MyClass { }

$x = new MyClass();
$x->foo = true;
        ];

        if (!is_null($trialDays) && is_numeric($trialDays)) {
            $data['TRIALBILLINGPERIOD'] = 'Day';
            $data['TRIALTOTALBILLINGCYCLES'] = $trialDays;
            $data['TRIALBILLINGFREQUENCY'] = 1;
            $data['TRIALAMT'] = 0;
        }

        return $this->createRecurringPaymentsProfile($data, $token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Create recurring subscription on monthly basis.
     *
     * @param string $token
     * @param float  $amount
     * @param string $description
     *
     * @return array
     */
    public function createMonthlySubscription($token, $amount, $description)

    {
        $data = [
            'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
            'DESC'             => $description,
            'BILLINGPERIOD'    => 'Month',
            'BILLINGFREQUENCY' => 1,
            'AMT'              => $amount,
            'CURRENCYCODE'     => $this->currency,
        ];

        return $this->createRecurringPaymentsProfile($data, $token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Create recurring subscription on yearly basis.
     *
     * @param string $token
     * @param float  $amount
     * @param string $description
     *
     * @return array
     */
    public function createYearlySubscription($token, $amount, $description)

    {
        $data = [
            'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
            'DESC'             => $description,
            'BILLINGPERIOD'    => 'Year',
            'BILLINGFREQUENCY' => 1,
            'AMT'              => $amount,
            'CURRENCYCODE'     => $this->currency,
        ];

        return $this->createRecurringPaymentsProfile($data, $token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Srmklive\PayPal\Traits;
4
5		use Carbon\Carbon;
6
7		trait RecurringProfiles
8		{
9		/**
10		* Create recurring subscription on custom frequency basis.
11		* The billing frequency is in months, i.e: if you want a monthly subscription, then your billing frequency would be 1.
12		*
13		* @param string $token
14		* @param float $amount
15		* @param string $description
16		* @param int $billingFrequency
17		* @param int $trialDays
18		*
19		* @return array
20		*/
21		public function createCustomSubscription($token, $amount, $description, $billingFrequency, $trialDays = null)
22		{
23		$data = [
24		'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
25		'DESC' => $description,
26		'BILLINGPERIOD' => 'Month',
27		'BILLINGFREQUENCY' => $billingFrequency,
28		'AMT' => $amount,
29		'CURRENCYCODE' => $this->currency,
		0 ignored issues – show Bug introduced 2017-04-06 14:56 UTC by Report Bug Copy Issue Report The property `currency` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30		];
31
32		if (!is_null($trialDays) && is_numeric($trialDays)) {
33		$data['TRIALBILLINGPERIOD'] = 'Day';
34		$data['TRIALTOTALBILLINGCYCLES'] = $trialDays;
35		$data['TRIALBILLINGFREQUENCY'] = 1;
36		$data['TRIALAMT'] = 0;
37		}
38
39		return $this->createRecurringPaymentsProfile($data, $token);
		0 ignored issues – show Bug introduced 2017-04-06 14:56 UTC by Report Bug Copy Issue Report It seems like `createRecurringPaymentsProfile()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		}
41
42		/**
43		* Create recurring subscription on monthly basis.
44		*
45		* @param string $token
46		* @param float $amount
47		* @param string $description
48		*
49		* @return array
50		*/
51	View Code Duplication	public function createMonthlySubscription($token, $amount, $description)
		0 ignored issues – show Duplication introduced 2017-08-04 07:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		$data = [
54		'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
55		'DESC' => $description,
56		'BILLINGPERIOD' => 'Month',
57		'BILLINGFREQUENCY' => 1,
58		'AMT' => $amount,
59		'CURRENCYCODE' => $this->currency,
60		];
61
62		return $this->createRecurringPaymentsProfile($data, $token);
		0 ignored issues – show Bug introduced 2017-04-06 14:56 UTC by Report Bug Copy Issue Report It seems like `createRecurringPaymentsProfile()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
63		}
64
65		/**
66		* Create recurring subscription on yearly basis.
67		*
68		* @param string $token
69		* @param float $amount
70		* @param string $description
71		*
72		* @return array
73		*/
74	View Code Duplication	public function createYearlySubscription($token, $amount, $description)
		0 ignored issues – show Duplication introduced 2017-08-04 07:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		$data = [
77		'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
78		'DESC' => $description,
79		'BILLINGPERIOD' => 'Year',
80		'BILLINGFREQUENCY' => 1,
81		'AMT' => $amount,
82		'CURRENCYCODE' => $this->currency,
83		];
84
85		return $this->createRecurringPaymentsProfile($data, $token);
		0 ignored issues – show Bug introduced 2018-10-04 19:47 UTC by Report Bug Copy Issue Report It seems like `createRecurringPaymentsProfile()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
86		}
87		}
88

srmklive / laravel-paypal

Pull Request — master (#241)

RecurringProfiles A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like