Issues in RecurringProfiles.php - All Issues - Inspection of "Apply fixes from StyleCI (#215)" - srmklive/laravel-paypal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4a0b03...f3c58e )

by Raza

created 2018-06-19 12:39 UTC

src/Traits/RecurringProfiles.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Srmklive\PayPal\Traits;

use Carbon\Carbon;

trait RecurringProfiles
{
    /**
     * Create recurring subscription on monthly basis.
     *
     * @param string $token
     * @param float  $amount
     * @param string $description
     *
     * @return array
     */
    public function createMonthlySubscription($token, $amount, $description)

    {
        $data = [
            'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
            'DESC'             => $description,
            'BILLINGPERIOD'    => 'Month',
            'BILLINGFREQUENCY' => 1,
            'AMT'              => $amount,
            'CURRENCYCODE'     => $this->currency,
class MyClass { }

$x = new MyClass();
$x->foo = true;
        ];

        return $this->createRecurringPaymentsProfile($data, $token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Create recurring subscription on yearly basis.
     *
     * @param string $token
     * @param float  $amount
     * @param string $description
     *
     * @return array
     */
    public function createYearlySubscription($token, $amount, $description)

    {
        $data = [
            'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
            'DESC'             => $description,
            'BILLINGPERIOD'    => 'Year',
            'BILLINGFREQUENCY' => 1,
            'AMT'              => $amount,
            'CURRENCYCODE'     => $this->currency,
        ];

        return $this->createRecurringPaymentsProfile($data, $token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Srmklive\PayPal\Traits;
4
5		use Carbon\Carbon;
6
7		trait RecurringProfiles
8		{
9		/**
10		* Create recurring subscription on monthly basis.
11		*
12		* @param string $token
13		* @param float $amount
14		* @param string $description
15		*
16		* @return array
17		*/
18	View Code Duplication	public function createMonthlySubscription($token, $amount, $description)
		0 ignored issues – show Duplication introduced 2017-08-04 07:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$data = [
21		'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
22		'DESC' => $description,
23		'BILLINGPERIOD' => 'Month',
24		'BILLINGFREQUENCY' => 1,
25		'AMT' => $amount,
26		'CURRENCYCODE' => $this->currency,
		0 ignored issues – show Bug introduced 2017-04-06 14:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currency` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27		];
28
29		return $this->createRecurringPaymentsProfile($data, $token);
		0 ignored issues – show Bug introduced 2017-04-06 14:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `createRecurringPaymentsProfile()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30		}
31
32		/**
33		* Create recurring subscription on yearly basis.
34		*
35		* @param string $token
36		* @param float $amount
37		* @param string $description
38		*
39		* @return array
40		*/
41	View Code Duplication	public function createYearlySubscription($token, $amount, $description)
		0 ignored issues – show Duplication introduced 2017-08-04 07:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		$data = [
44		'PROFILESTARTDATE' => Carbon::now()->toAtomString(),
45		'DESC' => $description,
46		'BILLINGPERIOD' => 'Year',
47		'BILLINGFREQUENCY' => 1,
48		'AMT' => $amount,
49		'CURRENCYCODE' => $this->currency,
50		];
51
52		return $this->createRecurringPaymentsProfile($data, $token);
		0 ignored issues – show Bug introduced 2017-04-06 14:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `createRecurringPaymentsProfile()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53		}
54		}
55

srmklive / laravel-paypal

Push — master ( 4a0b03...f3c58e )

src/Traits/RecurringProfiles.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like