Srmklive\PayPal\Traits\PayPalAPI\WebHooks::createWebHook()

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function createWebHook($url, array $events)
    {
        $this->apiEndPoint = 'v1/notifications/webhooks';

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $data = ['url' => $url];
        $data['event_types'] = collect($events)->map(function ($item) {
            return ['name' => $item];
        })->toArray();

        $this->options['json'] = $data;

The property options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'post';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();

It seems like doPayPalRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }