Srmklive\PayPal\Traits\PayPalAPI\Reporting

Complexity

Total Complexity

3

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	listTransactions()	0	8	1
A	listBalances()	0	10	2

<?php

namespace Srmklive\PayPal\Traits\PayPalAPI;

use Carbon\Carbon;

trait Reporting
{
    /**
     * List all transactions.
     *
     * @param int $page
     * @param int $page_size
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/transaction-search/v1/#transactions_get
     */
    public function listTransactions($page = 1, $page_size = 100)
    {
        $this->apiEndPoint = "v1/reporting/transactions?page={$page}&page_size={$page_size}";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'get';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();

It seems like doPayPalRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * List available balance.
     *
     * @param string $date
     *
     * @throws \Throwable
     *
     * @return array|\Psr\Http\Message\StreamInterface|string
     *
     * @see https://developer.paypal.com/docs/api/transaction-search/v1/#balances_get
     */
    public function listBalances($date = '')
    {
        $date = empty($date) ? Carbon::now()->toIso8601String() : Carbon::parse($date)->toIso8601String();

        $this->apiEndPoint = "v1/reporting/balances?currency_code={$this->currency}&as_of_date={$date}";

The property apiEndPoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->apiUrl = collect([$this->apiUrl, $this->apiEndPoint])->implode('/');

The property apiUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->verb = 'get';

The property verb does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->doPayPalRequest();
    }
}