DropboxAdapter::read() - Code Metrics - Inspection of "Refactoring & added new class to detect mimetype" - srmklive/flysystem-dropbox-v2 - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 15a3de...27de4e )

by Raza

created 2018-08-22 18:18 UTC

DropboxAdapter::read() A

↳ Parent: DropboxAdapter

Complexity

Conditions	2
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0625

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	6
cts	8
cp	0.75
rs	9.7666
c	0
b	0
f	0
cc	2
nc	4
nop	1
crap	2.0625

<?php

namespace Srmklive\Dropbox\Adapter;

use League\Flysystem\Adapter\AbstractAdapter;
use League\Flysystem\Adapter\Polyfill\NotSupportingVisibilityTrait;
use League\Flysystem\Config;
use Srmklive\Dropbox\Client\DropboxClient;
use Srmklive\Dropbox\MimeType;
use Srmklive\Dropbox\ParseResponse;

class DropboxAdapter extends AbstractAdapter
{
    use NotSupportingVisibilityTrait, ParseResponse;

    /** @var \Srmklive\Dropbox\Client\DropboxClient */
    protected $client;

    public function __construct(DropboxClient $client, $prefix = '')
    {
        $this->client = $client;

        $this->setPathPrefix($prefix);
    }

    /**
     * {@inheritdoc}
     */
    public function write($path, $contents, Config $config)
    {
        return $this->upload($path, $contents, 'add');
    }

    /**
     * {@inheritdoc}
     */
    public function writeStream($path, $resource, Config $config)
    {
        return $this->upload($path, $resource, 'add');
    }

    /**
     * {@inheritdoc}
     */
    public function update($path, $contents, Config $config)
    {
        return $this->upload($path, $contents, 'overwrite');
    }

    /**
     * {@inheritdoc}
     */
    public function updateStream($path, $resource, Config $config)
    {
        return $this->upload($path, $resource, 'overwrite');
    }

    /**
     * {@inheritdoc}
     */
    public function rename($path, $newPath)
    {
        $path = $this->applyPathPrefix($path);
        $newPath = $this->applyPathPrefix($newPath);

        try {
            $this->client->move($path, $newPath);

            return true;
        } catch (\Exception $e) {

        }

        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function copy($path, $newpath)

    {
        $path = $this->applyPathPrefix($path);
        $newpath = $this->applyPathPrefix($newpath);

        try {
            $this->client->copy($path, $newpath);

            return true;
        } catch (\Exception $e) {

        }

        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function delete($path)
    {
        $location = $this->applyPathPrefix($path);

        try {
            $this->client->delete($location);

            return true;
        } catch (\Exception $e) {

        }

        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function deleteDir($dirname)
    {
        return $this->delete($dirname);
    }

    /**
     * {@inheritdoc}
     */
    public function createDir($dirname, Config $config)

    {
        $path = $this->applyPathPrefix($dirname);
        $response = false;

        try {
            $object = $this->client->createFolder($path);

            $response = $this->normalizeResponse($object);
        } catch (\Exception $e) {

        }

        return $response;
    }

    /**
     * {@inheritdoc}
     */
    public function has($path)
    {
        return $this->getMetadata($path);
    }

    /**
     * {@inheritdoc}
     */
    public function read($path)
    {
        try {
            $object = $this->readStream($path);

            $object['contents'] = stream_get_contents($object['stream']);
            fclose($object['stream']);
            unset($object['stream']);

            return $object;
        } catch (\Exception $exception) {

        }

        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function readStream($path)
    {
        $path = $this->applyPathPrefix($path);
        $response = false;

        try {
            $stream = $this->client->download($path);

            $response = compact('stream');
        } catch (\Exception $e) {

        }

        return $response;
    }

    /**
     * {@inheritdoc}
     */
    public function listContents($directory = '', $recursive = false)
    {
        $response = [];

        try {
            $location = $this->applyPathPrefix($directory);

            $result = $this->client->listFolder($location, $recursive);

            $response = array_map(function ($entry) {
                return $this->normalizeResponse($entry);
            }, $result['entries']);
        } catch (\Exception $exception) {

        }

        return $response;
    }

    /**
     * {@inheritdoc}
     */
    public function getMetadata($path)

    {
        $path = $this->applyPathPrefix($path);

        try {
            $object = $this->client->getMetadata($path);

            return $this->normalizeResponse($object);
        } catch (\Exception  $e) {
            return false;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getSize($path)
    {
        return $this->getMetadata($path);
    }

    /**
     * {@inheritdoc}
     */
    public function getMimetype($path)
    {
        return ['mimetype' => MimeType::detectByFilename($path)];
    }

    /**
     * {@inheritdoc}
     */
    public function getTimestamp($path)
    {
        return $this->getMetadata($path);
    }

    /**
     * {@inheritdoc}
     */
    public function getTemporaryLink($path)
    {
        return $this->client->getTemporaryLink($path);
    }

    /**
     * {@inheritdoc}
     */
    public function getThumbnail($path, $format = 'jpeg', $size = 'w64h64')
    {
        return $this->client->getThumbnail($path, $format, $size);
    }

    /**
     * {@inheritdoc}
     */
    public function applyPathPrefix($path)
    {
        $path = parent::applyPathPrefix($path);

        return '/'.trim($path, '/');
    }

    /**
     * @return DropboxClient
     */
    public function getClient()
    {
        return $this->client;
    }

    /**
     * @param string          $path
     * @param resource|string $contents
     * @param string          $mode
     *
     * @throws \Exception
     *
     * @return array|false file metadata
     */
    protected function upload($path, $contents, $mode)

    {
        $path = $this->applyPathPrefix($path);

        try {
            $object = $this->client->upload($path, $contents, $mode);

            return $this->normalizeResponse($object);
        } catch (\Exception $e) {

        }

        return false;
    }
}


1			<?php
2
3			namespace Srmklive\Dropbox\Adapter;
4
5			use League\Flysystem\Adapter\AbstractAdapter;
6			use League\Flysystem\Adapter\Polyfill\NotSupportingVisibilityTrait;
7			use League\Flysystem\Config;
8			use Srmklive\Dropbox\Client\DropboxClient;
9			use Srmklive\Dropbox\MimeType;
10			use Srmklive\Dropbox\ParseResponse;
11
12			class DropboxAdapter extends AbstractAdapter
13			{
14			use NotSupportingVisibilityTrait, ParseResponse;
15
16			/** @var \Srmklive\Dropbox\Client\DropboxClient */
17			protected $client;
18
19	19		public function __construct(DropboxClient $client, $prefix = '')
20			{
21	19		$this->client = $client;
22
23	19		$this->setPathPrefix($prefix);
24	19		}
25
26			/**
27			* {@inheritdoc}
28			*/
29	1		public function write($path, $contents, Config $config)
30			{
31	1		return $this->upload($path, $contents, 'add');
32			}
33
34			/**
35			* {@inheritdoc}
36			*/
37	1		public function writeStream($path, $resource, Config $config)
38			{
39	1		return $this->upload($path, $resource, 'add');
40			}
41
42			/**
43			* {@inheritdoc}
44			*/
45	1		public function update($path, $contents, Config $config)
46			{
47	1		return $this->upload($path, $contents, 'overwrite');
48			}
49
50			/**
51			* {@inheritdoc}
52			*/
53	1		public function updateStream($path, $resource, Config $config)
54			{
55	1		return $this->upload($path, $resource, 'overwrite');
56			}
57
58			/**
59			* {@inheritdoc}
60			*/
61	2		public function rename($path, $newPath)
62			{
63	2		$path = $this->applyPathPrefix($path);
64	2		$newPath = $this->applyPathPrefix($newPath);
65
66			try {
67	2		$this->client->move($path, $newPath);
68
69	1		return true;
70	1		} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 18:20 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
71			}
72
73	1		return false;
74			}
75
76			/**
77			* {@inheritdoc}
78			*/
79	2	View Code Duplication	public function copy($path, $newpath)
			0 ignored issues – show Duplication introduced 2017-08-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80			{
81	2		$path = $this->applyPathPrefix($path);
82	2		$newpath = $this->applyPathPrefix($newpath);
83
84			try {
85	2		$this->client->copy($path, $newpath);
86
87	1		return true;
88	1		} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 18:20 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
89			}
90
91	1		return false;
92			}
93
94			/**
95			* {@inheritdoc}
96			*/
97	1		public function delete($path)
98			{
99	1		$location = $this->applyPathPrefix($path);
100
101			try {
102	1		$this->client->delete($location);
103
104	1		return true;
105			} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 18:20 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
106			}
107
108			return false;
109			}
110
111			/**
112			* {@inheritdoc}
113			*/
114	1		public function deleteDir($dirname)
115			{
116	1		return $this->delete($dirname);
117			}
118
119			/**
120			* {@inheritdoc}
121			*/
122	1	View Code Duplication	public function createDir($dirname, Config $config)
			0 ignored issues – show Duplication introduced 2017-08-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123			{
124	1		$path = $this->applyPathPrefix($dirname);
125	1		$response = false;
126
127			try {
128	1		$object = $this->client->createFolder($path);
129
130	1		$response = $this->normalizeResponse($object);
131	1		} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 17:51 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
132			}
133
134	1		return $response;
135			}
136
137			/**
138			* {@inheritdoc}
139			*/
140	2		public function has($path)
141			{
142	2		return $this->getMetadata($path);
143			}
144
145			/**
146			* {@inheritdoc}
147			*/
148	1		public function read($path)
149			{
150			try {
151	1		$object = $this->readStream($path);
152
153	1		$object['contents'] = stream_get_contents($object['stream']);
154	1		fclose($object['stream']);
155	1		unset($object['stream']);
156
157	1		return $object;
158			} catch (\Exception $exception) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 18:20 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
159			}
160
161			return false;
162			}
163
164			/**
165			* {@inheritdoc}
166			*/
167	2		public function readStream($path)
168			{
169	2		$path = $this->applyPathPrefix($path);
170	2		$response = false;
171
172			try {
173	2		$stream = $this->client->download($path);
174
175	2		$response = compact('stream');
176	2		} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 17:51 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
177			}
178
179	2		return $response;
180			}
181
182			/**
183			* {@inheritdoc}
184			*/
185	1		public function listContents($directory = '', $recursive = false)
186			{
187	1		$response = [];
188
189			try {
190	1		$location = $this->applyPathPrefix($directory);
191
192	1		$result = $this->client->listFolder($location, $recursive);
193
194	1		$response = array_map(function ($entry) {
195	1		return $this->normalizeResponse($entry);
196	1		}, $result['entries']);
197	1		} catch (\Exception $exception) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 17:51 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
198			}
199
200	1		return $response;
201			}
202
203			/**
204			* {@inheritdoc}
205			*/
206	5	View Code Duplication	public function getMetadata($path)
			0 ignored issues – show Duplication introduced 2017-08-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
207			{
208	5		$path = $this->applyPathPrefix($path);
209
210			try {
211	5		$object = $this->client->getMetadata($path);
212
213	4		return $this->normalizeResponse($object);
214	1		} catch (\Exception $e) {
215	1		return false;
216			}
217			}
218
219			/**
220			* {@inheritdoc}
221			*/
222	1		public function getSize($path)
223			{
224	1		return $this->getMetadata($path);
225			}
226
227			/**
228			* {@inheritdoc}
229			*/
230			public function getMimetype($path)
231			{
232			return ['mimetype' => MimeType::detectByFilename($path)];
233			}
234
235			/**
236			* {@inheritdoc}
237			*/
238	1		public function getTimestamp($path)
239			{
240	1		return $this->getMetadata($path);
241			}
242
243			/**
244			* {@inheritdoc}
245			*/
246			public function getTemporaryLink($path)
247			{
248			return $this->client->getTemporaryLink($path);
249			}
250
251			/**
252			* {@inheritdoc}
253			*/
254			public function getThumbnail($path, $format = 'jpeg', $size = 'w64h64')
255			{
256			return $this->client->getThumbnail($path, $format, $size);
257			}
258
259			/**
260			* {@inheritdoc}
261			*/
262	18		public function applyPathPrefix($path)
263			{
264	18		$path = parent::applyPathPrefix($path);
265
266	18		return '/'.trim($path, '/');
267			}
268
269			/**
270			* @return DropboxClient
271			*/
272	1		public function getClient()
273			{
274	1		return $this->client;
275			}
276
277			/**
278			* @param string $path
279			* @param resource\|string $contents
280			* @param string $mode
281			*
282			* @throws \Exception
283			*
284			* @return array\|false file metadata
285			*/
286	4	View Code Duplication	protected function upload($path, $contents, $mode)
			0 ignored issues – show Duplication introduced 2017-08-31 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
287			{
288	4		$path = $this->applyPathPrefix($path);
289
290			try {
291	4		$object = $this->client->upload($path, $contents, $mode);
292
293	4		return $this->normalizeResponse($object);
294			} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-08-22 18:20 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
295			}
296
297			return false;
298			}
299			}
300

srmklive / flysystem-dropbox-v2

Push — master ( 15a3de...27de4e )

DropboxAdapter::read() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like