View GitHub Repository flysystem-dropbox-v2

Schedule Inspection
Subscribe
Test Failed
Push — master ( 5cb5e4...15a3de )
by Raza
01:57
created

ParseResponse::normalizeResponse()   A

↳ Parent: ParseResponse

Complexity

Conditions 5
Paths 16

Size

Total Lines 15

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 10
CRAP Score 5

Importance

Changes 0
Metric Value
dl 0
loc 15
ccs 10
cts 10
cp 1
rs 9.4555
c 0
b 0
f 0
cc 5
nc 16
nop 1
crap 5
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Srmklive\Dropbox;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
trait ParseResponse

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
     * Parse response from Dropbox.

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
     *

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
     * @param array|\Psr\Http\Message\ResponseInterface $response

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
     *

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
     * @return array

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
     */

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                             10                         
                
                
                
    protected function normalizeResponse($response)

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                             10                         
                
                
                
        $normalizedPath = ltrim($this->removePathPrefix($response['path_display']), '/');

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
It seems like removePathPrefix() must be provided by classes using this trait. How about adding it as abstract method to this trait?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for methods that are used by a trait but not required by it.


To illustrate, let’s look at the following code example


trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}





The trait Idable provides a method equalsId that in turn relies on the
method getId(). If this method does not exist on a class mixing in this
trait, the method will fail.


Adding the getId() as an abstract method to the trait will make sure it
is available.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                             10                         
                
                
                
        $normalizedResponse = ['path' => $normalizedPath];

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                             10                         
                
                
                
        $normalizedResponse['timestamp'] = isset($response['server_modified']) ?

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                             10                         
                
                
                
            strtotime($response['server_modified']) : '';

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                             10                         
                
                
                
        $normalizedResponse['size'] = isset($response['size']) ? $response['size'] : 0;

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                             10                         
                
                
                
        $normalizedResponse['bytes'] = isset($response['size']) ? $response['size'] : 0;

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                             10                         
                
                
                
        $type = ($response['.tag'] === 'folder' ? 'dir' : 'file');

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                             10                         
                
                
                
        $normalizedResponse['type'] = $type;

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                             10                         
                
                
                
        return $normalizedResponse;

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    30