Srmklive\Dropbox\ParseResponse

Complexity

Total Complexity

5

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	normalizeResponse()	0	14	5

<?php

namespace Srmklive\Dropbox;

trait ParseResponse
{
    /**
     * Parse response from Dropbox.
     *
     * @param array|\Psr\Http\Message\ResponseInterface $response
     *
     * @return array
     */
    protected function normalizeResponse($response)
    {
        $normalizedPath = ltrim($this->removePathPrefix($response['path_display']), '/');

It seems like removePathPrefix() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $normalizedResponse = ['path' => $normalizedPath];
        $normalizedResponse['timestamp'] = isset($response['server_modified']) ?
            strtotime($response['server_modified']) : null;
        $normalizedResponse['size'] = isset($response['size']) ? $response['size'] : null;
        $normalizedResponse['bytes'] = isset($response['size']) ? $response['size'] : null;

        $type = ($response['.tag'] === 'folder' ? 'dir' : 'file');
        $normalizedResponse['type'] = $type;

        return array_filter($normalizedResponse);
    }
}