Srmklive\Chargify\Traits\ChargifyAPI\Products

Complexity

Total Complexity

5

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	product_details()	0	7	1
A	product_create()	0	11	1
A	product_archive()	0	7	1
A	product_update()	0	11	1
A	product_details_by_handle()	0	7	1

<?php

namespace Srmklive\Chargify\Traits\ChargifyAPI;

trait Products
{
    /**
     * Create a new product.
     *
     * @param string $product_family_id
     * @param array  $data
     *
     * @return array
     */
    public function product_create(string $product_family_id, array $data): array
    {
        $this->apiEndPoint = "/product_families/{$product_family_id}/products.json";

        $this->verb = 'post';

        $this->options['json'] = [

The property options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'product' => $data,
        ];

        return $this->doChargifyRequest();

It seems like doChargifyRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get product details.
     *
     * @param string $product_id
     *
     * @return array
     */
    public function product_details(string $product_id): array
    {
        $this->apiEndPoint = "/products/{$product_id}.json";

        $this->verb = 'get';

        return $this->doChargifyRequest();
    }

    /**
     * Get product details via API Handle.
     *
     * @param string $handle
     *
     * @return array
     */
    public function product_details_by_handle(string $handle): array
    {
        $this->apiEndPoint = "/products/handle/{$handle}.json";

        $this->verb = 'get';

        return $this->doChargifyRequest();
    }

    /**
     * Update product details.
     *
     * @param string $product_id
     * @param array  $data
     *
     * @return array
     */
    public function product_update(string $product_id, array $data): array
    {
        $this->apiEndPoint = "/products/{$product_id}.json";

        $this->verb = 'put';

        $this->options['json'] = [

The property options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'product' => $data,
        ];

        return $this->doChargifyRequest();
    }

    /**
     * Archive a product.
     *
     * @param string $product_id
     *
     * @return array
     */
    public function product_archive(string $product_id): array
    {
        $this->apiEndPoint = "/products/{$product_id}.json";

        $this->verb = 'delete';

        return $this->doChargifyRequest();
    }
}