SquareetLabs\LaravelOpenVidu\Builders\ConnectionBuilder::build()

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function build(array $properties, ?array $publishers = [], ?array $subscribers = [])

The parameter $properties is not used and could be removed.

    {
        return new Connection($connectionArray['connectionId'] ?? null,

The variable $connectionArray seems to never exist and therefore isset should always be false.

It seems like $connectionArray['connectionId'] ?? null can also be of type null; however, parameter $connectionId of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['createdAt'] ?? null,

It seems like $connectionArray['createdAt'] ?? null can also be of type null; however, parameter $createdAt of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept integer, maybe add an additional type check?

            $connectionArray['role'] ?? null,

It seems like $connectionArray['role'] ?? null can also be of type null; however, parameter $role of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['token'] ?? null,

It seems like $connectionArray['token'] ?? null can also be of type null; however, parameter $token of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['location'] ?? null,

It seems like $connectionArray['location'] ?? null can also be of type null; however, parameter $location of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['platform'] ?? null,

It seems like $connectionArray['platform'] ?? null can also be of type null; however, parameter $platform of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['serverData'] ?? null,

It seems like $connectionArray['serverData'] ?? null can also be of type null; however, parameter $serverData of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['clientData'] ?? null,

It seems like $connectionArray['clientData'] ?? null can also be of type null; however, parameter $clientData of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $publishers,
            $subscribers
        );
}