SquareetLabs\LaravelOpenVidu\Builders\ConnectionBuilder

Complexity

Total Complexity

1

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	build()	0	12	1

<?php
/**
 * Created by theQuizProject <https://www.thequizproject.com>
 * Developer: Jacobo Cantorna Cigarrán <https://es.linkedin.com/in/jacobocantornacigarran>
 * Date: 20/12/2019
 * Time: 20:50
 */

namespace SquareetLabs\LaravelOpenVidu\Builders;


use SquareetLabs\LaravelOpenVidu\Connection;

class ConnectionBuilder
{
    /**
     * @param array $properties
     * @param array $publishers
     * @param array $subscribers
     * @return Connection
     */
    public static function build(array $properties, ?array $publishers = [], ?array $subscribers = [])

The parameter $properties is not used and could be removed.

    {
        return new Connection($connectionArray['connectionId'] ?? null,

The variable $connectionArray seems to never exist and therefore isset should always be false.

It seems like $connectionArray['connectionId'] ?? null can also be of type null; however, parameter $connectionId of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['createdAt'] ?? null,

It seems like $connectionArray['createdAt'] ?? null can also be of type null; however, parameter $createdAt of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept integer, maybe add an additional type check?

            $connectionArray['role'] ?? null,

It seems like $connectionArray['role'] ?? null can also be of type null; however, parameter $role of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['token'] ?? null,

It seems like $connectionArray['token'] ?? null can also be of type null; however, parameter $token of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['location'] ?? null,

It seems like $connectionArray['location'] ?? null can also be of type null; however, parameter $location of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['platform'] ?? null,

It seems like $connectionArray['platform'] ?? null can also be of type null; however, parameter $platform of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['serverData'] ?? null,

It seems like $connectionArray['serverData'] ?? null can also be of type null; however, parameter $serverData of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $connectionArray['clientData'] ?? null,

It seems like $connectionArray['clientData'] ?? null can also be of type null; however, parameter $clientData of SquareetLabs\LaravelOpenVidu\Connection::__construct() does only seem to accept string, maybe add an additional type check?

            $publishers,
            $subscribers
        );
    }
}